From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64: lib: use C string functions with KASAN enabled.
Date: Fri, 7 Sep 2018 15:56:05 +0100 [thread overview]
Message-ID: <20180907145605.GE12788@arm.com> (raw)
In-Reply-To: <20180906170534.20726-1-aryabinin@virtuozzo.com>
On Thu, Sep 06, 2018 at 08:05:33PM +0300, Andrey Ryabinin wrote:
> ARM64 has asm implementations of memchr(), memcmp(), str[r]chr(),
> str[n]cmp(), str[n]len(). KASAN don't see memory accesses in asm
> code, thus it can potentially miss many bugs.
>
> Ifdef out __HAVE_ARCH_* defines of these functions when KASAN is
> enabled, so the generic implementations from lib/string.c will be used.
>
> Declare asm functions as weak instead of removing them because they
> still can be used by efistub.
I don't understand this bit: efistub uses the __pi_ prefixed versions of the
routines, so why do we need to declare them as weak?
Will
WARNING: multiple messages have this Message-ID (diff)
From: Will Deacon <will.deacon@arm.com>
To: Andrey Ryabinin <aryabinin@virtuozzo.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
Andrew Morton <akpm@linux-foundation.org>,
Kyeongdon Kim <kyeongdon.kim@lge.com>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Alexander Potapenko <glider@google.com>,
Dmitry Vyukov <dvyukov@google.com>,
kasan-dev@googlegroups.com, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: lib: use C string functions with KASAN enabled.
Date: Fri, 7 Sep 2018 15:56:05 +0100 [thread overview]
Message-ID: <20180907145605.GE12788@arm.com> (raw)
In-Reply-To: <20180906170534.20726-1-aryabinin@virtuozzo.com>
On Thu, Sep 06, 2018 at 08:05:33PM +0300, Andrey Ryabinin wrote:
> ARM64 has asm implementations of memchr(), memcmp(), str[r]chr(),
> str[n]cmp(), str[n]len(). KASAN don't see memory accesses in asm
> code, thus it can potentially miss many bugs.
>
> Ifdef out __HAVE_ARCH_* defines of these functions when KASAN is
> enabled, so the generic implementations from lib/string.c will be used.
>
> Declare asm functions as weak instead of removing them because they
> still can be used by efistub.
I don't understand this bit: efistub uses the __pi_ prefixed versions of the
routines, so why do we need to declare them as weak?
Will
next prev parent reply other threads:[~2018-09-07 14:56 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-06 17:05 [PATCH] arm64: lib: use C string functions with KASAN enabled Andrey Ryabinin
2018-09-06 17:05 ` Andrey Ryabinin
2018-09-06 17:05 ` [PATCH] lib/test_kasan: Add tests for several string/memory API functions Andrey Ryabinin
2018-09-06 17:05 ` Andrey Ryabinin
2018-09-07 14:56 ` Will Deacon [this message]
2018-09-07 14:56 ` [PATCH] arm64: lib: use C string functions with KASAN enabled Will Deacon
2018-09-07 15:48 ` Andrey Ryabinin
2018-09-07 15:48 ` Andrey Ryabinin
2018-09-10 11:33 ` Mark Rutland
2018-09-10 11:33 ` Mark Rutland
2018-09-10 12:53 ` Mark Rutland
2018-09-10 12:53 ` Mark Rutland
2018-09-10 13:06 ` Will Deacon
2018-09-10 13:06 ` Will Deacon
2018-09-11 13:01 ` Andrey Ryabinin
2018-09-11 13:01 ` Andrey Ryabinin
2018-09-14 15:28 ` Will Deacon
2018-09-14 15:28 ` Will Deacon
2018-09-20 13:56 ` [PATCH v2 1/3] linkage.h: Align weak symbols Andrey Ryabinin
2018-09-20 13:56 ` Andrey Ryabinin
2018-09-20 13:56 ` [PATCH v2 2/3] arm64: lib: use C string functions with KASAN enabled Andrey Ryabinin
2018-09-20 13:56 ` Andrey Ryabinin
2018-10-29 10:29 ` Will Deacon
2018-10-29 10:29 ` Will Deacon
2018-10-29 11:16 ` Andrey Ryabinin
2018-10-29 11:16 ` Andrey Ryabinin
2018-10-29 11:20 ` Will Deacon
2018-10-29 11:20 ` Will Deacon
2018-09-20 13:56 ` [PATCH v2 3/3] lib/test_kasan: Add tests for several string/memory API functions Andrey Ryabinin
2018-09-20 13:56 ` Andrey Ryabinin
2018-10-29 10:29 ` [PATCH v2 1/3] linkage.h: Align weak symbols Will Deacon
2018-10-29 10:29 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180907145605.GE12788@arm.com \
--to=will.deacon@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.