From: "Michael S. Tsirkin" <mst@redhat.com>
To: Peng Hao <peng.hao2@zte.com.cn>
Cc: qemu-devel@nongnu.org, pbonzini@redhat.com, ehabkost@redhat.com,
kvm@vger.kernel.org, rkrcmar@redhat.com
Subject: Re: [PATCH V5 1/4] target-i386: introduce coalesced_pio kvm header update
Date: Fri, 7 Sep 2018 17:01:17 -0400 [thread overview]
Message-ID: <20180907165909-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <1535706305-118115-5-git-send-email-peng.hao2@zte.com.cn> <1535706305-118115-4-git-send-email-peng.hao2@zte.com.cn> <1535706305-118115-3-git-send-email-peng.hao2@zte.com.cn> <1535706305-118115-2-git-send-email-peng.hao2@zte.com.cn>
On Fri, Aug 31, 2018 at 05:05:02PM +0800, Peng Hao wrote:
> add coalesced_pio's struct and KVM_CAP_COALESCED_PIO header.
>
> Signed-off-by: Peng Hao <peng.hao2@zte.com.cn>
Despite what the subject says, this is a kvm patch
not a target-i386 one. In fact none of these are.
And it does not add a header.
Please change subjects so correct people review your patches.
E.g. this one should be
kvm: add coalesced_pio support
Needs to be rebased too.
--
MST
WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Peng Hao <peng.hao2@zte.com.cn>
Cc: pbonzini@redhat.com, rkrcmar@redhat.com, ehabkost@redhat.com,
qemu-devel@nongnu.org, kvm@vger.kernel.org
Subject: Re: [Qemu-devel] [PATCH V5 1/4] target-i386: introduce coalesced_pio kvm header update
Date: Fri, 7 Sep 2018 17:01:17 -0400 [thread overview]
Message-ID: <20180907165909-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <1535706305-118115-5-git-send-email-peng.hao2@zte.com.cn> <1535706305-118115-4-git-send-email-peng.hao2@zte.com.cn> <1535706305-118115-3-git-send-email-peng.hao2@zte.com.cn> <1535706305-118115-2-git-send-email-peng.hao2@zte.com.cn>
On Fri, Aug 31, 2018 at 05:05:02PM +0800, Peng Hao wrote:
> add coalesced_pio's struct and KVM_CAP_COALESCED_PIO header.
>
> Signed-off-by: Peng Hao <peng.hao2@zte.com.cn>
Despite what the subject says, this is a kvm patch
not a target-i386 one. In fact none of these are.
And it does not add a header.
Please change subjects so correct people review your patches.
E.g. this one should be
kvm: add coalesced_pio support
Needs to be rebased too.
--
MST
next prev parent reply other threads:[~2018-09-07 21:01 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-31 9:05 [PATCH V5 0/4] introduce coalesced pio support Peng Hao
2018-08-31 9:05 ` [Qemu-devel] " Peng Hao
2018-08-31 9:05 ` [PATCH V5 1/4] target-i386: introduce coalesced_pio kvm header update Peng Hao
2018-08-31 9:05 ` [Qemu-devel] " Peng Hao
2018-09-07 21:01 ` Michael S. Tsirkin [this message]
2018-09-07 21:01 ` Michael S. Tsirkin
2018-09-07 21:02 ` Michael S. Tsirkin
2018-09-07 21:02 ` [Qemu-devel] " Michael S. Tsirkin
2018-10-17 1:37 ` [PATCH V5 1/4] target-i386: introduce coalesced_pio kvm headerupdate peng.hao2
2018-10-17 1:37 ` [Qemu-devel] " peng.hao2
2018-08-31 9:05 ` [PATCH V5 2/4] target-i386:add coalesced_pio API Peng Hao
2018-08-31 9:05 ` [Qemu-devel] " Peng Hao
2018-08-31 3:35 ` Michael S. Tsirkin
2018-08-31 3:35 ` [Qemu-devel] " Michael S. Tsirkin
2018-08-31 9:05 ` [PATCH V5 3/4] target-i386: add rtc 0x70 port as coalesced_pio Peng Hao
2018-08-31 9:05 ` [Qemu-devel] " Peng Hao
2018-08-31 9:05 ` [PATCH V5 4/4] target-i386: add i440fx 0xcf8 " Peng Hao
2018-08-31 9:05 ` [Qemu-devel] " Peng Hao
-- strict thread matches above, loose matches on Subject: below --
2018-08-30 15:50 [PATCH V5 0/4] introduce coalesced pio support Peng Hao
2018-08-30 15:50 ` [PATCH V5 1/4] target-i386: introduce coalesced_pio kvm header update Peng Hao
2018-08-30 19:04 ` Eduardo Habkost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180907165909-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=ehabkost@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=peng.hao2@zte.com.cn \
--cc=qemu-devel@nongnu.org \
--cc=rkrcmar@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.