From: Jean Delvare <jdelvare@suse.de>
To: zhong jiang <zhongjiang@huawei.com>
Cc: schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com,
jwi@linux.ibm.com, ubraun@linux.ibm.com,
linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] s390: vmlogrdr: Use ARRAY_SIZE instead of reimplementing its function
Date: Sat, 8 Sep 2018 15:00:55 +0200 [thread overview]
Message-ID: <20180908150055.1842ce99@endymion> (raw)
In-Reply-To: <1536402388-23872-2-git-send-email-zhongjiang@huawei.com>
On Sat, 8 Sep 2018 18:26:27 +0800, zhong jiang wrote:
> ARRAY_SIZE has implemented its function. we prefer to use the function
> rather than the open code.
>
> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
> ---
> drivers/s390/char/vmlogrdr.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/s390/char/vmlogrdr.c b/drivers/s390/char/vmlogrdr.c
> index 069b9ef..58333cb 100644
> --- a/drivers/s390/char/vmlogrdr.c
> +++ b/drivers/s390/char/vmlogrdr.c
> @@ -153,7 +153,7 @@ static void vmlogrdr_iucv_message_pending(struct iucv_path *,
> }
> };
>
> -#define MAXMINOR (sizeof(sys_ser)/sizeof(struct vmlogrdr_priv_t))
> +#define MAXMINOR ARRAY_SIZE(sys_ser)
>
> static char FENCE[] = {"EOR"};
> static int vmlogrdr_major = 0;
Reviewed-by: Jean Delvare <jdelvare@suse.de>
--
Jean Delvare
SUSE L3 Support
WARNING: multiple messages have this Message-ID (diff)
From: Jean Delvare <jdelvare@suse.de>
To: zhong jiang <zhongjiang@huawei.com>
Cc: <schwidefsky@de.ibm.com>, <heiko.carstens@de.ibm.com>,
<jwi@linux.ibm.com>, <ubraun@linux.ibm.com>,
<linux-s390@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] s390: vmlogrdr: Use ARRAY_SIZE instead of reimplementing its function
Date: Sat, 8 Sep 2018 15:00:55 +0200 [thread overview]
Message-ID: <20180908150055.1842ce99@endymion> (raw)
In-Reply-To: <1536402388-23872-2-git-send-email-zhongjiang@huawei.com>
On Sat, 8 Sep 2018 18:26:27 +0800, zhong jiang wrote:
> ARRAY_SIZE has implemented its function. we prefer to use the function
> rather than the open code.
>
> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
> ---
> drivers/s390/char/vmlogrdr.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/s390/char/vmlogrdr.c b/drivers/s390/char/vmlogrdr.c
> index 069b9ef..58333cb 100644
> --- a/drivers/s390/char/vmlogrdr.c
> +++ b/drivers/s390/char/vmlogrdr.c
> @@ -153,7 +153,7 @@ static void vmlogrdr_iucv_message_pending(struct iucv_path *,
> }
> };
>
> -#define MAXMINOR (sizeof(sys_ser)/sizeof(struct vmlogrdr_priv_t))
> +#define MAXMINOR ARRAY_SIZE(sys_ser)
>
> static char FENCE[] = {"EOR"};
> static int vmlogrdr_major = 0;
Reviewed-by: Jean Delvare <jdelvare@suse.de>
--
Jean Delvare
SUSE L3 Support
next prev parent reply other threads:[~2018-09-08 13:00 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-08 10:26 [PATCH 0/2] s390: Use ARRAY_SIZE instead of reimplementing its function zhong jiang
2018-09-08 10:26 ` zhong jiang
2018-09-08 10:26 ` [PATCH 1/2] s390: vmlogrdr: " zhong jiang
2018-09-08 10:26 ` zhong jiang
2018-09-08 13:00 ` Jean Delvare [this message]
2018-09-08 13:00 ` Jean Delvare
2018-09-08 10:26 ` [PATCH 2/2] s390: qeth_core_mpc: " zhong jiang
2018-09-08 10:26 ` zhong jiang
2018-09-08 13:11 ` Jean Delvare
2018-09-08 13:11 ` Jean Delvare
2018-09-10 6:37 ` [PATCH 0/2] s390: " Martin Schwidefsky
2018-09-10 6:37 ` Martin Schwidefsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180908150055.1842ce99@endymion \
--to=jdelvare@suse.de \
--cc=heiko.carstens@de.ibm.com \
--cc=jwi@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=schwidefsky@de.ibm.com \
--cc=ubraun@linux.ibm.com \
--cc=zhongjiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.