From: shawnguo@kernel.org (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/2] ARM: dts: imx6: RDU2: Use new CODEC reset pin name
Date: Mon, 10 Sep 2018 08:48:58 +0800 [thread overview]
Message-ID: <20180910004857.GF21218@dragon> (raw)
In-Reply-To: <20180904142018.4267-1-afd@ti.com>
On Tue, Sep 04, 2018 at 09:20:17AM -0500, Andrew F. Davis wrote:
> The correct DT property for specifying a GPIO used for reset
> is "reset-gpios", the driver now accepts this name use this here.
>
> Signed-off-by: Andrew F. Davis <afd@ti.com>
> ---
>
> Changes from v1:
> - Remove "fix" from commit message
>
> arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi b/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi
> index 7fff3717cf7c..a0f5cfda0055 100644
> --- a/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi
> @@ -384,7 +384,7 @@
> AVDD-supply = <®_3p3v>;
> IOVDD-supply = <®_3p3v>;
> DVDD-supply = <&vgen4_reg>;
> - gpio-reset = <&gpio1 2 GPIO_ACTIVE_HIGH>;
> + reset-gpios = <&gpio1 2 GPIO_ACTIVE_LOW>;
Is it intended to change the polarity?
Shawn
> };
>
> accel at 1c {
> @@ -572,7 +572,7 @@
> AVDD-supply = <®_3p3v>;
> IOVDD-supply = <®_3p3v>;
> DVDD-supply = <&vgen4_reg>;
> - gpio-reset = <&gpio1 0 GPIO_ACTIVE_HIGH>;
> + reset-gpios = <&gpio1 0 GPIO_ACTIVE_LOW>;
> };
>
> touchscreen at 20 {
> --
> 2.18.0
>
WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawnguo@kernel.org>
To: "Andrew F. Davis" <afd@ti.com>
Cc: Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <fabio.estevam@nxp.com>,
NXP Linux Team <linux-imx@nxp.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] ARM: dts: imx6: RDU2: Use new CODEC reset pin name
Date: Mon, 10 Sep 2018 08:48:58 +0800 [thread overview]
Message-ID: <20180910004857.GF21218@dragon> (raw)
In-Reply-To: <20180904142018.4267-1-afd@ti.com>
On Tue, Sep 04, 2018 at 09:20:17AM -0500, Andrew F. Davis wrote:
> The correct DT property for specifying a GPIO used for reset
> is "reset-gpios", the driver now accepts this name use this here.
>
> Signed-off-by: Andrew F. Davis <afd@ti.com>
> ---
>
> Changes from v1:
> - Remove "fix" from commit message
>
> arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi b/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi
> index 7fff3717cf7c..a0f5cfda0055 100644
> --- a/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi
> @@ -384,7 +384,7 @@
> AVDD-supply = <®_3p3v>;
> IOVDD-supply = <®_3p3v>;
> DVDD-supply = <&vgen4_reg>;
> - gpio-reset = <&gpio1 2 GPIO_ACTIVE_HIGH>;
> + reset-gpios = <&gpio1 2 GPIO_ACTIVE_LOW>;
Is it intended to change the polarity?
Shawn
> };
>
> accel@1c {
> @@ -572,7 +572,7 @@
> AVDD-supply = <®_3p3v>;
> IOVDD-supply = <®_3p3v>;
> DVDD-supply = <&vgen4_reg>;
> - gpio-reset = <&gpio1 0 GPIO_ACTIVE_HIGH>;
> + reset-gpios = <&gpio1 0 GPIO_ACTIVE_LOW>;
> };
>
> touchscreen@20 {
> --
> 2.18.0
>
next prev parent reply other threads:[~2018-09-10 0:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-04 14:20 [PATCH v2 1/2] ARM: dts: imx6: RDU2: Use new CODEC reset pin name Andrew F. Davis
2018-09-04 14:20 ` [PATCH v2 2/2] ARM: dts: imx: " Andrew F. Davis
2018-09-10 0:48 ` Shawn Guo [this message]
2018-09-10 0:48 ` [PATCH v2 1/2] ARM: dts: imx6: RDU2: " Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180910004857.GF21218@dragon \
--to=shawnguo@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.