From: clabbe@baylibre.com (LABBE Corentin)
To: cocci@systeme.lip6.fr
Subject: [Cocci] [PATCH 2/5] include: add setbits32/clrbits32/clrsetbits32/setbits64/clrbits64/clrsetbits64 in linux/setbits.h
Date: Mon, 10 Sep 2018 20:53:25 +0200 [thread overview]
Message-ID: <20180910185325.GC7819@Red> (raw)
In-Reply-To: <a1795266-5679-289d-5cce-1111babf3180@c-s.fr>
On Mon, Sep 10, 2018 at 07:22:04AM +0200, Christophe LEROY wrote:
>
>
> Le 07/09/2018 ? 21:41, Corentin Labbe a ?crit?:
> > This patch adds setbits32/clrbits32/clrsetbits32 and
> > setbits64/clrbits64/clrsetbits64 in linux/setbits.h header.
>
> So you changed the name of setbits32() ... to setbits32_be() and now you
> are adding new functions called setbits32() ... which do something
> different ?
>
> What will happen if any file has been forgotten during the conversion,
> or if anybody has outoftree drivers and missed this change ?
> They will silently successfully compile without any error or warning,
> and the result will be crap buggy.
>
> And why would it be more legitim to have setbits32() be implicitely LE
> instead of implicitely BE ?
>
> I really think those new functions should be called something like
> setbits_le32() ...
>
I believed that writel/readl was endian agnostic so it explain my mistake.
I will use xxxbits_le32 as you requests.
Thanks
Regards
WARNING: multiple messages have this Message-ID (diff)
From: clabbe@baylibre.com (LABBE Corentin)
To: linus-amlogic@lists.infradead.org
Subject: [PATCH 2/5] include: add setbits32/clrbits32/clrsetbits32/setbits64/clrbits64/clrsetbits64 in linux/setbits.h
Date: Mon, 10 Sep 2018 20:53:25 +0200 [thread overview]
Message-ID: <20180910185325.GC7819@Red> (raw)
In-Reply-To: <a1795266-5679-289d-5cce-1111babf3180@c-s.fr>
On Mon, Sep 10, 2018 at 07:22:04AM +0200, Christophe LEROY wrote:
>
>
> Le 07/09/2018 ? 21:41, Corentin Labbe a ?crit?:
> > This patch adds setbits32/clrbits32/clrsetbits32 and
> > setbits64/clrbits64/clrsetbits64 in linux/setbits.h header.
>
> So you changed the name of setbits32() ... to setbits32_be() and now you
> are adding new functions called setbits32() ... which do something
> different ?
>
> What will happen if any file has been forgotten during the conversion,
> or if anybody has outoftree drivers and missed this change ?
> They will silently successfully compile without any error or warning,
> and the result will be crap buggy.
>
> And why would it be more legitim to have setbits32() be implicitely LE
> instead of implicitely BE ?
>
> I really think those new functions should be called something like
> setbits_le32() ...
>
I believed that writel/readl was endian agnostic so it explain my mistake.
I will use xxxbits_le32 as you requests.
Thanks
Regards
WARNING: multiple messages have this Message-ID (diff)
From: LABBE Corentin <clabbe@baylibre.com>
To: Christophe LEROY <christophe.leroy@c-s.fr>
Cc: Gilles.Muller@lip6.fr, Julia.Lawall@lip6.fr, agust@denx.de,
alexandre.torgue@st.com, alistair@popple.id.au,
benh@kernel.crashing.org, carlo@caione.org, davem@davemloft.net,
galak@kernel.crashing.org, joabreu@synopsys.com,
khilman@baylibre.com, maxime.ripard@bootlin.com,
michal.lkml@markovi.net, mpe@ellerman.id.au,
mporter@kernel.crashing.org, nicolas.palix@imag.fr,
oss@buserror.net, paulus@samba.org, peppe.cavallaro@st.com,
tj@kernel.org, vitb@kernel.crashing.org, wens@csie.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-ide@vger.kernel.org, linux-sunxi@googlegroups.com,
linux-amlogic@lists.infradead.org, linuxppc-dev@lists.ozlabs.org,
cocci@systeme.lip6.fr, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/5] include: add setbits32/clrbits32/clrsetbits32/setbits64/clrbits64/clrsetbits64 in linux/setbits.h
Date: Mon, 10 Sep 2018 20:53:25 +0200 [thread overview]
Message-ID: <20180910185325.GC7819@Red> (raw)
In-Reply-To: <a1795266-5679-289d-5cce-1111babf3180@c-s.fr>
On Mon, Sep 10, 2018 at 07:22:04AM +0200, Christophe LEROY wrote:
>
>
> Le 07/09/2018 à 21:41, Corentin Labbe a écrit :
> > This patch adds setbits32/clrbits32/clrsetbits32 and
> > setbits64/clrbits64/clrsetbits64 in linux/setbits.h header.
>
> So you changed the name of setbits32() ... to setbits32_be() and now you
> are adding new functions called setbits32() ... which do something
> different ?
>
> What will happen if any file has been forgotten during the conversion,
> or if anybody has outoftree drivers and missed this change ?
> They will silently successfully compile without any error or warning,
> and the result will be crap buggy.
>
> And why would it be more legitim to have setbits32() be implicitely LE
> instead of implicitely BE ?
>
> I really think those new functions should be called something like
> setbits_le32() ...
>
I believed that writel/readl was endian agnostic so it explain my mistake.
I will use xxxbits_le32 as you requests.
Thanks
Regards
WARNING: multiple messages have this Message-ID (diff)
From: clabbe@baylibre.com (LABBE Corentin)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/5] include: add setbits32/clrbits32/clrsetbits32/setbits64/clrbits64/clrsetbits64 in linux/setbits.h
Date: Mon, 10 Sep 2018 20:53:25 +0200 [thread overview]
Message-ID: <20180910185325.GC7819@Red> (raw)
In-Reply-To: <a1795266-5679-289d-5cce-1111babf3180@c-s.fr>
On Mon, Sep 10, 2018 at 07:22:04AM +0200, Christophe LEROY wrote:
>
>
> Le 07/09/2018 ? 21:41, Corentin Labbe a ?crit?:
> > This patch adds setbits32/clrbits32/clrsetbits32 and
> > setbits64/clrbits64/clrsetbits64 in linux/setbits.h header.
>
> So you changed the name of setbits32() ... to setbits32_be() and now you
> are adding new functions called setbits32() ... which do something
> different ?
>
> What will happen if any file has been forgotten during the conversion,
> or if anybody has outoftree drivers and missed this change ?
> They will silently successfully compile without any error or warning,
> and the result will be crap buggy.
>
> And why would it be more legitim to have setbits32() be implicitely LE
> instead of implicitely BE ?
>
> I really think those new functions should be called something like
> setbits_le32() ...
>
I believed that writel/readl was endian agnostic so it explain my mistake.
I will use xxxbits_le32 as you requests.
Thanks
Regards
next prev parent reply other threads:[~2018-09-10 18:53 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-07 19:41 [Cocci] [PATCH 0/5] introduce setbits32/clrbits32/clrsetbits32/setbits64/clrbits64/clrsetbits64 functions Corentin Labbe
2018-09-07 19:41 ` Corentin Labbe
2018-09-07 19:41 ` Corentin Labbe
2018-09-07 19:41 ` Corentin Labbe
2018-09-07 19:41 ` [Cocci] [PATCH 1/5] powerpc: rename setbits32/clrbits32 to setbits32_be/clrbits32_be Corentin Labbe
2018-09-07 19:41 ` Corentin Labbe
2018-09-07 19:41 ` Corentin Labbe
2018-09-07 19:41 ` Corentin Labbe
2018-09-10 5:16 ` [Cocci] " Christophe LEROY
2018-09-10 5:16 ` Christophe LEROY
2018-09-10 5:16 ` Christophe LEROY
2018-09-10 5:16 ` Christophe LEROY
2018-09-10 18:50 ` [Cocci] " LABBE Corentin
2018-09-10 18:50 ` LABBE Corentin
2018-09-10 18:50 ` LABBE Corentin
2018-09-10 18:50 ` LABBE Corentin
2018-09-07 19:41 ` [Cocci] [PATCH 2/5] include: add setbits32/clrbits32/clrsetbits32/setbits64/clrbits64/clrsetbits64 in linux/setbits.h Corentin Labbe
2018-09-07 19:41 ` Corentin Labbe
2018-09-07 19:41 ` Corentin Labbe
2018-09-07 19:41 ` Corentin Labbe
2018-09-07 20:00 ` [Cocci] " Scott Wood
2018-09-07 20:00 ` Scott Wood
2018-09-07 20:00 ` Scott Wood
2018-09-07 20:00 ` Scott Wood
2018-09-10 18:49 ` [Cocci] " LABBE Corentin
2018-09-10 18:49 ` LABBE Corentin
2018-09-10 18:49 ` LABBE Corentin
2018-09-10 18:49 ` LABBE Corentin
2018-09-10 5:22 ` [Cocci] " Christophe LEROY
2018-09-10 5:22 ` Christophe LEROY
2018-09-10 5:22 ` Christophe LEROY
2018-09-10 5:22 ` Christophe LEROY
2018-09-10 18:53 ` LABBE Corentin [this message]
2018-09-10 18:53 ` LABBE Corentin
2018-09-10 18:53 ` LABBE Corentin
2018-09-10 18:53 ` LABBE Corentin
2018-09-07 19:41 ` [Cocci] [PATCH RFC 3/5] coccinelle: add xxxsetbitsXX converting spatch Corentin Labbe
2018-09-07 19:41 ` Corentin Labbe
2018-09-07 19:41 ` Corentin Labbe
2018-09-07 19:41 ` Corentin Labbe
2018-09-09 11:13 ` SF Markus Elfring
2018-09-09 11:13 ` SF Markus Elfring
2018-09-09 11:13 ` SF Markus Elfring
2018-09-09 11:13 ` SF Markus Elfring
2018-09-09 11:13 ` SF Markus Elfring
2018-09-09 11:13 ` SF Markus Elfring
2018-09-07 19:41 ` [Cocci] [PATCH 4/5] net: ethernet: stmmac: use xxxsetbits32 Corentin Labbe
2018-09-07 19:41 ` Corentin Labbe
2018-09-07 19:41 ` Corentin Labbe
2018-09-07 19:41 ` Corentin Labbe
2018-09-07 19:41 ` [Cocci] [PATCH 5/5] ata: ahci_sunxi: use xxxsetbits32 functions Corentin Labbe
2018-09-07 19:41 ` Corentin Labbe
2018-09-07 19:41 ` Corentin Labbe
2018-09-07 19:41 ` Corentin Labbe
2018-09-07 21:57 ` [Cocci] [PATCH 0/5] introduce setbits32/clrbits32/clrsetbits32/setbits64/clrbits64/clrsetbits64 functions David Miller
2018-09-07 21:57 ` David Miller
2018-09-07 21:57 ` David Miller
2018-09-07 21:57 ` David Miller
2018-09-10 5:24 ` [Cocci] " Christophe LEROY
2018-09-10 5:24 ` Christophe LEROY
2018-09-10 5:24 ` Christophe LEROY
2018-09-10 5:24 ` Christophe LEROY
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180910185325.GC7819@Red \
--to=clabbe@baylibre.com \
--cc=cocci@systeme.lip6.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.