From: Greg KH <greg@kroah.com>
To: Nicolas Ferre <nicolas.ferre@microchip.com>
Cc: sfr@canb.auug.org.au, Radu Pirea <radu_nicolae.pirea@upb.ro>,
linux-next@vger.kernel.org, lee.jones@linaro.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] mfd: at91-usart: fix missing mod_devicetable.h
Date: Tue, 11 Sep 2018 11:02:11 +0200 [thread overview]
Message-ID: <20180911090211.GA25358@kroah.com> (raw)
In-Reply-To: <20180911084448.17878-1-nicolas.ferre@microchip.com>
On Tue, Sep 11, 2018 at 10:44:48AM +0200, Nicolas Ferre wrote:
> Following the inclusion of the patch ac3167257b9f ("headers:
> separate linux/mod_devicetable.h from linux/platform_device.h"), there is a
> build issue:
>
> drivers/mfd/at91-usart.c:51:34: error: array type has incomplete element type
> 'struct of_device_id'
> static const struct of_device_id at91_usart_mode_of_match[] = {
>
> Before this patch, the definition was reached by its inclusion of
> linux/mfd/core.h.
>
> The build issue is solved by simply adding the mod_devicetable.h in this
> driver.
>
> Signed-off-by: Nicolas Ferre <nicolas.ferre@microchip.com>
> Cc: Radu Pirea <radu_nicolae.pirea@upb.ro>
You forgot a "reported-by" :(
I'll go add it...
WARNING: multiple messages have this Message-ID (diff)
From: greg@kroah.com (Greg KH)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] mfd: at91-usart: fix missing mod_devicetable.h
Date: Tue, 11 Sep 2018 11:02:11 +0200 [thread overview]
Message-ID: <20180911090211.GA25358@kroah.com> (raw)
In-Reply-To: <20180911084448.17878-1-nicolas.ferre@microchip.com>
On Tue, Sep 11, 2018 at 10:44:48AM +0200, Nicolas Ferre wrote:
> Following the inclusion of the patch ac3167257b9f ("headers:
> separate linux/mod_devicetable.h from linux/platform_device.h"), there is a
> build issue:
>
> drivers/mfd/at91-usart.c:51:34: error: array type has incomplete element type
> 'struct of_device_id'
> static const struct of_device_id at91_usart_mode_of_match[] = {
>
> Before this patch, the definition was reached by its inclusion of
> linux/mfd/core.h.
>
> The build issue is solved by simply adding the mod_devicetable.h in this
> driver.
>
> Signed-off-by: Nicolas Ferre <nicolas.ferre@microchip.com>
> Cc: Radu Pirea <radu_nicolae.pirea@upb.ro>
You forgot a "reported-by" :(
I'll go add it...
next prev parent reply other threads:[~2018-09-11 9:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-11 2:58 linux-next: build failure after merge of the tty tree Stephen Rothwell
2018-09-11 8:23 ` Greg KH
2018-09-11 8:25 ` Lee Jones
2018-09-11 8:32 ` Nicolas Ferre
2018-09-11 8:43 ` Lee Jones
2018-09-18 4:54 ` Andy Shevchenko
2018-09-11 8:44 ` [PATCH] mfd: at91-usart: fix missing mod_devicetable.h Nicolas Ferre
2018-09-11 8:44 ` Nicolas Ferre
2018-09-11 9:02 ` Greg KH [this message]
2018-09-11 9:02 ` Greg KH
2018-09-11 9:36 ` Lee Jones
2018-09-11 9:36 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180911090211.GA25358@kroah.com \
--to=greg@kroah.com \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-next@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=radu_nicolae.pirea@upb.ro \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.