From: Lee Jones <lee.jones@linaro.org>
To: Tony Xie <tony.xie@rock-chips.com>
Cc: heiko@sntech.de, broonie@kernel.org, robh+dt@kernel.org,
mark.rutland@arm.com, a.zummo@towertech.it,
alexandre.belloni@bootlin.com, sboyd@kernel.org,
linux-clk@vger.kernel.org, linux-rtc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, chenjh@rock-chips.com,
xsf@rock-chips.com, zhangqing@rock-chips.com,
huangtao@rock-chips.com
Subject: Re: [PATCH v4 1/5] mfd: rk808: Add RK817 and RK809 support
Date: Tue, 11 Sep 2018 13:39:07 +0100 [thread overview]
Message-ID: <20180911123907.GN4185@dell> (raw)
In-Reply-To: <1535968829-19418-2-git-send-email-tony.xie@rock-chips.com>
On Mon, 03 Sep 2018, Tony Xie wrote:
> The rk809 and rk817 are a Power Management IC (PMIC) for multimedia
> and handheld devices. It contains the following components:
>
> - Regulators
> - RTC
> - Clocking
>
> Both RK809 and RK817 chips are using a similar register map,
> so we can reuse the RTC and Clocking and regulators functionality.
>
> Signed-off-by: Tony Xie <tony.xie@rock-chips.com>
> ---
It's often helpful to place a Changelog in this space.
> drivers/mfd/Kconfig | 6 +-
> drivers/mfd/rk808.c | 218 +++++++++++++++++++++++++++++++++++++++++++++-
> include/linux/mfd/rk808.h | 172 ++++++++++++++++++++++++++++++++++++
> kernel/reboot.c | 1 +
> 4 files changed, 391 insertions(+), 6 deletions(-)
I just reviewed v4.
It looks like the review comments are still relevant.
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
WARNING: multiple messages have this Message-ID (diff)
From: lee.jones@linaro.org (Lee Jones)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 1/5] mfd: rk808: Add RK817 and RK809 support
Date: Tue, 11 Sep 2018 13:39:07 +0100 [thread overview]
Message-ID: <20180911123907.GN4185@dell> (raw)
In-Reply-To: <1535968829-19418-2-git-send-email-tony.xie@rock-chips.com>
On Mon, 03 Sep 2018, Tony Xie wrote:
> The rk809 and rk817 are a Power Management IC (PMIC) for multimedia
> and handheld devices. It contains the following components:
>
> - Regulators
> - RTC
> - Clocking
>
> Both RK809 and RK817 chips are using a similar register map,
> so we can reuse the RTC and Clocking and regulators functionality.
>
> Signed-off-by: Tony Xie <tony.xie@rock-chips.com>
> ---
It's often helpful to place a Changelog in this space.
> drivers/mfd/Kconfig | 6 +-
> drivers/mfd/rk808.c | 218 +++++++++++++++++++++++++++++++++++++++++++++-
> include/linux/mfd/rk808.h | 172 ++++++++++++++++++++++++++++++++++++
> kernel/reboot.c | 1 +
> 4 files changed, 391 insertions(+), 6 deletions(-)
I just reviewed v4.
It looks like the review comments are still relevant.
--
Lee Jones [???]
Linaro Services Technical Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2018-09-11 12:39 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-03 10:00 [PATCH v4 0/5] support a new type of PMIC,including two chips(rk817 and rk809) Tony Xie
2018-09-03 10:00 ` [PATCH v4 0/5] support a new type of PMIC, including " Tony Xie
2018-09-03 10:00 ` [PATCH v4 1/5] mfd: rk808: Add RK817 and RK809 support Tony Xie
2018-09-03 10:00 ` Tony Xie
2018-09-11 12:39 ` Lee Jones [this message]
2018-09-11 12:39 ` Lee Jones
2018-10-23 3:33 ` tony
2018-10-23 3:33 ` tony
2018-09-03 10:00 ` [PATCH v4 2/5] regulator: rk808: add RK809 and RK817 support Tony Xie
2018-09-03 10:00 ` Tony Xie
2018-09-03 13:41 ` Mark Brown
2018-09-03 13:41 ` Mark Brown
2018-09-03 10:00 ` [PATCH v4 3/5] dt-bindings: mfd: rk808: Add binding information for RK809 and RK817 Tony Xie
2018-09-03 10:00 ` Tony Xie
2018-09-03 10:00 ` [PATCH v4 4/5] rtc: rk808: add RK809 and RK817 support Tony Xie
2018-09-03 10:00 ` Tony Xie
2018-09-03 10:04 ` [PATCH v4 5/5] clk: RK808: " Tony Xie
2018-09-03 10:04 ` Tony Xie
2018-10-12 19:53 ` Stephen Boyd
2018-10-12 19:53 ` Stephen Boyd
2018-10-12 19:53 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180911123907.GN4185@dell \
--to=lee.jones@linaro.org \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=broonie@kernel.org \
--cc=chenjh@rock-chips.com \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=huangtao@rock-chips.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-rtc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=tony.xie@rock-chips.com \
--cc=xsf@rock-chips.com \
--cc=zhangqing@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.