From: Lee Jones <lee.jones@linaro.org>
To: Colin King <colin.king@canonical.com>
Cc: patches@opensource.cirrus.com, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mfd: arizona: make array mclk_name static, shrinks object size
Date: Tue, 11 Sep 2018 14:00:31 +0000 [thread overview]
Message-ID: <20180911140031.GT4185@dell> (raw)
In-Reply-To: <20180904141553.28000-1-colin.king@canonical.com>
On Tue, 04 Sep 2018, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Don't populate the array mclk_name on the stack but instead make it
> static. Makes the object code smaller by 23 bytes:
>
> Before:
> text data bss dec hex filename
> 38050 11604 64 49718 c236 linux/drivers/mfd/arizona-core.o
>
> After:
> text data bss dec hex filename
> 38027 11604 64 49695 c21f linux/drivers/mfd/arizona-core.o
>
> (gcc version 8.2.0 x86_64)
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/mfd/arizona-core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks.
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org>
To: Colin King <colin.king@canonical.com>
Cc: patches@opensource.cirrus.com, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mfd: arizona: make array mclk_name static, shrinks object size
Date: Tue, 11 Sep 2018 15:00:31 +0100 [thread overview]
Message-ID: <20180911140031.GT4185@dell> (raw)
In-Reply-To: <20180904141553.28000-1-colin.king@canonical.com>
On Tue, 04 Sep 2018, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Don't populate the array mclk_name on the stack but instead make it
> static. Makes the object code smaller by 23 bytes:
>
> Before:
> text data bss dec hex filename
> 38050 11604 64 49718 c236 linux/drivers/mfd/arizona-core.o
>
> After:
> text data bss dec hex filename
> 38027 11604 64 49695 c21f linux/drivers/mfd/arizona-core.o
>
> (gcc version 8.2.0 x86_64)
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/mfd/arizona-core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks.
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2018-09-11 14:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-04 14:15 [PATCH] mfd: arizona: make array mclk_name static, shrinks object size Colin King
2018-09-04 14:15 ` Colin King
2018-09-05 9:15 ` Charles Keepax
2018-09-05 9:15 ` Charles Keepax
2018-09-11 14:00 ` Lee Jones [this message]
2018-09-11 14:00 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180911140031.GT4185@dell \
--to=lee.jones@linaro.org \
--cc=colin.king@canonical.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.