* Re: [4.14.y] request commit 94a5d8790e79 ("arm64: cpu_errata: include required headers")
@ 2018-09-13 7:24 ` Jisheng Zhang
0 siblings, 0 replies; 12+ messages in thread
From: Jisheng Zhang @ 2018-09-13 7:24 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: linux-arm-kernel, stable, Arnd Bergmann
Hi Greg,
On Thu, 13 Sep 2018 09:12:16 +0200 Greg Kroah-Hartman wrote:
> On Tue, Sep 11, 2018 at 05:00:30PM +0800, Jisheng Zhang wrote:
> > Hi Greg,
> >
> > I think we missed the commit 94a5d8790e79 ("arm64: cpu_errata: include
> > required headers"), could you please include it in next stable release?
>
> Really, you are seeing build failures on 4.14.y without this patch
> applied? I haven't gotten any reports of this, what is wrong with our
yes. I see similar build errors as the commit mentioned. Per my test, setting
CONFIG_ARM64_SSBD as y will trigger the errors.
Thanks
> build tests that this isn't being caught?
>
> thanks,
>
> greg k-h
^ permalink raw reply [flat|nested] 12+ messages in thread* [4.14.y] request commit 94a5d8790e79 ("arm64: cpu_errata: include required headers")
2018-09-13 7:24 ` Jisheng Zhang
@ 2018-09-13 7:33 ` Jisheng Zhang
-1 siblings, 0 replies; 12+ messages in thread
From: Jisheng Zhang @ 2018-09-13 7:33 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, 13 Sep 2018 15:24:20 +0800 Jisheng Zhang wrote:
> Hi Greg,
>
> On Thu, 13 Sep 2018 09:12:16 +0200 Greg Kroah-Hartman wrote:
>
> > On Tue, Sep 11, 2018 at 05:00:30PM +0800, Jisheng Zhang wrote:
> > > Hi Greg,
> > >
> > > I think we missed the commit 94a5d8790e79 ("arm64: cpu_errata: include
> > > required headers"), could you please include it in next stable release?
> >
> > Really, you are seeing build failures on 4.14.y without this patch
> > applied? I haven't gotten any reports of this, what is wrong with our
>
> yes. I see similar build errors as the commit mentioned. Per my test, setting
> CONFIG_ARM64_SSBD as y will trigger the errors.
hmm, it looks like the defconfig in arch/arm64/configs can't trigger the
build errors. But my version could, I attach it for reference.
>
> Thanks
>
> > build tests that this isn't being caught?
> >
> > thanks,
> >
> > greg k-h
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: config_bad.gz
Type: application/gzip
Size: 12599 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20180913/df4b8b49/attachment-0001.gz>
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [4.14.y] request commit 94a5d8790e79 ("arm64: cpu_errata: include required headers")
@ 2018-09-13 7:33 ` Jisheng Zhang
0 siblings, 0 replies; 12+ messages in thread
From: Jisheng Zhang @ 2018-09-13 7:33 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: linux-arm-kernel, stable, Arnd Bergmann
[-- Attachment #1: Type: text/plain, Size: 913 bytes --]
On Thu, 13 Sep 2018 15:24:20 +0800 Jisheng Zhang wrote:
> Hi Greg,
>
> On Thu, 13 Sep 2018 09:12:16 +0200 Greg Kroah-Hartman wrote:
>
> > On Tue, Sep 11, 2018 at 05:00:30PM +0800, Jisheng Zhang wrote:
> > > Hi Greg,
> > >
> > > I think we missed the commit 94a5d8790e79 ("arm64: cpu_errata: include
> > > required headers"), could you please include it in next stable release?
> >
> > Really, you are seeing build failures on 4.14.y without this patch
> > applied? I haven't gotten any reports of this, what is wrong with our
>
> yes. I see similar build errors as the commit mentioned. Per my test, setting
> CONFIG_ARM64_SSBD as y will trigger the errors.
hmm, it looks like the defconfig in arch/arm64/configs can't trigger the
build errors. But my version could, I attach it for reference.
>
> Thanks
>
> > build tests that this isn't being caught?
> >
> > thanks,
> >
> > greg k-h
>
[-- Attachment #2: config_bad.gz --]
[-- Type: application/gzip, Size: 12599 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread
* [4.14.y] request commit 94a5d8790e79 ("arm64: cpu_errata: include required headers")
2018-09-13 7:24 ` Jisheng Zhang
@ 2018-09-13 7:38 ` Greg Kroah-Hartman
-1 siblings, 0 replies; 12+ messages in thread
From: Greg Kroah-Hartman @ 2018-09-13 7:38 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Sep 13, 2018 at 03:24:20PM +0800, Jisheng Zhang wrote:
> Hi Greg,
>
> On Thu, 13 Sep 2018 09:12:16 +0200 Greg Kroah-Hartman wrote:
>
> > On Tue, Sep 11, 2018 at 05:00:30PM +0800, Jisheng Zhang wrote:
> > > Hi Greg,
> > >
> > > I think we missed the commit 94a5d8790e79 ("arm64: cpu_errata: include
> > > required headers"), could you please include it in next stable release?
> >
> > Really, you are seeing build failures on 4.14.y without this patch
> > applied? I haven't gotten any reports of this, what is wrong with our
>
> yes. I see similar build errors as the commit mentioned. Per my test, setting
> CONFIG_ARM64_SSBD as y will trigger the errors.
Odd that no one else is seeing this, perhaps you might want to look into
that :)
Anyway, it's a safe patch, now queued up.
greg k-h
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [4.14.y] request commit 94a5d8790e79 ("arm64: cpu_errata: include required headers")
@ 2018-09-13 7:38 ` Greg Kroah-Hartman
0 siblings, 0 replies; 12+ messages in thread
From: Greg Kroah-Hartman @ 2018-09-13 7:38 UTC (permalink / raw)
To: Jisheng Zhang; +Cc: linux-arm-kernel, stable, Arnd Bergmann
On Thu, Sep 13, 2018 at 03:24:20PM +0800, Jisheng Zhang wrote:
> Hi Greg,
>
> On Thu, 13 Sep 2018 09:12:16 +0200 Greg Kroah-Hartman wrote:
>
> > On Tue, Sep 11, 2018 at 05:00:30PM +0800, Jisheng Zhang wrote:
> > > Hi Greg,
> > >
> > > I think we missed the commit 94a5d8790e79 ("arm64: cpu_errata: include
> > > required headers"), could you please include it in next stable release?
> >
> > Really, you are seeing build failures on 4.14.y without this patch
> > applied? I haven't gotten any reports of this, what is wrong with our
>
> yes. I see similar build errors as the commit mentioned. Per my test, setting
> CONFIG_ARM64_SSBD as y will trigger the errors.
Odd that no one else is seeing this, perhaps you might want to look into
that :)
Anyway, it's a safe patch, now queued up.
greg k-h
^ permalink raw reply [flat|nested] 12+ messages in thread* [4.14.y] request commit 94a5d8790e79 ("arm64: cpu_errata: include required headers")
2018-09-13 7:38 ` Greg Kroah-Hartman
@ 2018-09-13 7:40 ` Arnd Bergmann
-1 siblings, 0 replies; 12+ messages in thread
From: Arnd Bergmann @ 2018-09-13 7:40 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Sep 13, 2018 at 9:38 AM Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
>
> On Thu, Sep 13, 2018 at 03:24:20PM +0800, Jisheng Zhang wrote:
> > Hi Greg,
> >
> > On Thu, 13 Sep 2018 09:12:16 +0200 Greg Kroah-Hartman wrote:
> >
> > > On Tue, Sep 11, 2018 at 05:00:30PM +0800, Jisheng Zhang wrote:
> > > > Hi Greg,
> > > >
> > > > I think we missed the commit 94a5d8790e79 ("arm64: cpu_errata: include
> > > > required headers"), could you please include it in next stable release?
> > >
> > > Really, you are seeing build failures on 4.14.y without this patch
> > > applied? I haven't gotten any reports of this, what is wrong with our
> >
> > yes. I see similar build errors as the commit mentioned. Per my test, setting
> > CONFIG_ARM64_SSBD as y will trigger the errors.
>
> Odd that no one else is seeing this, perhaps you might want to look into
> that :)
>
> Anyway, it's a safe patch, now queued up.
It's a fairly unusual configuration, but not hard to hit in randconfig
builds. I've been meaning to resume doing randconfig builds on stable
kernels for a while to catch more of those, hopefully after Linux Connect
I'll get to that.
Arnd
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [4.14.y] request commit 94a5d8790e79 ("arm64: cpu_errata: include required headers")
@ 2018-09-13 7:40 ` Arnd Bergmann
0 siblings, 0 replies; 12+ messages in thread
From: Arnd Bergmann @ 2018-09-13 7:40 UTC (permalink / raw)
To: gregkh; +Cc: Jisheng Zhang, Linux ARM, # 3.4.x
On Thu, Sep 13, 2018 at 9:38 AM Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
>
> On Thu, Sep 13, 2018 at 03:24:20PM +0800, Jisheng Zhang wrote:
> > Hi Greg,
> >
> > On Thu, 13 Sep 2018 09:12:16 +0200 Greg Kroah-Hartman wrote:
> >
> > > On Tue, Sep 11, 2018 at 05:00:30PM +0800, Jisheng Zhang wrote:
> > > > Hi Greg,
> > > >
> > > > I think we missed the commit 94a5d8790e79 ("arm64: cpu_errata: include
> > > > required headers"), could you please include it in next stable release?
> > >
> > > Really, you are seeing build failures on 4.14.y without this patch
> > > applied? I haven't gotten any reports of this, what is wrong with our
> >
> > yes. I see similar build errors as the commit mentioned. Per my test, setting
> > CONFIG_ARM64_SSBD as y will trigger the errors.
>
> Odd that no one else is seeing this, perhaps you might want to look into
> that :)
>
> Anyway, it's a safe patch, now queued up.
It's a fairly unusual configuration, but not hard to hit in randconfig
builds. I've been meaning to resume doing randconfig builds on stable
kernels for a while to catch more of those, hopefully after Linux Connect
I'll get to that.
Arnd
^ permalink raw reply [flat|nested] 12+ messages in thread