From: Tony Lindgren <tony@atomide.com>
To: Linus Walleij <linus.walleij@linaro.org>,
Alexandre Courbot <gnurou@gmail.com>
Cc: Grygorii Strashko <grygorii.strashko@ti.com>,
Aaro Koskinen <aaro.koskinen@iki.fi>, Keerthy <j-keerthy@ti.com>,
Tero Kristo <t-kristo@ti.com>,
linux-gpio@vger.kernel.org, Ladislav Michl <ladis@linux-mips.org>,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] gpio: omap: Remove custom PM calls and use cpu_pm instead
Date: Tue, 11 Sep 2018 16:34:29 -0700 [thread overview]
Message-ID: <20180911233429.GF5662@atomide.com> (raw)
In-Reply-To: <20180911183729.17110-1-tony@atomide.com>
* Tony Lindgren <tony@atomide.com> [180911 18:41]:
> For omap2, we don't need to save context and don't want to remove any
> triggering so let's add a quirk flag for that.
...
> + switch (cmd) {
> + case CPU_CLUSTER_PM_ENTER:
> + /* Gets cleard on runtime_suspend */
> + bank->power_mode = OFF_MODE;
Oops I forgot to check for OMAP_GPIO_QUIRK_IDLE_REMOVE_TRIGGER
here, this should be:
if (bank->quirks & OMAP_GPIO_QUIRK_IDLE_REMOVE_TRIGGER)
bank->power_mode = OFF_MODE;
Regards,
Tony
WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] gpio: omap: Remove custom PM calls and use cpu_pm instead
Date: Tue, 11 Sep 2018 16:34:29 -0700 [thread overview]
Message-ID: <20180911233429.GF5662@atomide.com> (raw)
In-Reply-To: <20180911183729.17110-1-tony@atomide.com>
* Tony Lindgren <tony@atomide.com> [180911 18:41]:
> For omap2, we don't need to save context and don't want to remove any
> triggering so let's add a quirk flag for that.
...
> + switch (cmd) {
> + case CPU_CLUSTER_PM_ENTER:
> + /* Gets cleard on runtime_suspend */
> + bank->power_mode = OFF_MODE;
Oops I forgot to check for OMAP_GPIO_QUIRK_IDLE_REMOVE_TRIGGER
here, this should be:
if (bank->quirks & OMAP_GPIO_QUIRK_IDLE_REMOVE_TRIGGER)
bank->power_mode = OFF_MODE;
Regards,
Tony
next prev parent reply other threads:[~2018-09-11 23:34 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-11 18:37 [PATCH] gpio: omap: Remove custom PM calls and use cpu_pm instead Tony Lindgren
2018-09-11 18:37 ` Tony Lindgren
2018-09-11 19:40 ` Ladislav Michl
2018-09-11 19:40 ` Ladislav Michl
2018-09-11 23:28 ` Tony Lindgren
2018-09-11 23:28 ` Tony Lindgren
2018-09-11 23:34 ` Tony Lindgren [this message]
2018-09-11 23:34 ` Tony Lindgren
2018-09-12 0:29 ` Grygorii Strashko
2018-09-12 0:29 ` Grygorii Strashko
2018-09-12 0:41 ` Tony Lindgren
2018-09-12 0:41 ` Tony Lindgren
2018-09-14 9:09 ` Linus Walleij
2018-09-14 9:09 ` Linus Walleij
2018-09-14 13:20 ` Tony Lindgren
2018-09-14 13:20 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180911233429.GF5662@atomide.com \
--to=tony@atomide.com \
--cc=aaro.koskinen@iki.fi \
--cc=gnurou@gmail.com \
--cc=grygorii.strashko@ti.com \
--cc=j-keerthy@ti.com \
--cc=ladis@linux-mips.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=t-kristo@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.