All of lore.kernel.org
 help / color / mirror / Atom feed
From: shawnguo@kernel.org (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 06/11] dts: arm: imx7{d,s}: Update coresight binding for hardware ports
Date: Wed, 12 Sep 2018 10:21:57 +0800	[thread overview]
Message-ID: <20180912022152.GG28469@dragon> (raw)
In-Reply-To: <1536661032-30481-7-git-send-email-suzuki.poulose@arm.com>

On Tue, Sep 11, 2018 at 11:17:07AM +0100, Suzuki K Poulose wrote:
> Switch to the updated coresight bindings.
> 
> Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: Sascha Hauer <s.hauer@pengutronix.de>
> Cc: Pengutronix Kernel Team <kernel@pengutronix.de>
> Cc: Fabio Estevam <fabio.estevam@nxp.com>
> Cc: Mathieu Poirier <mathieu.poirier@linaro.org>
> Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>

As per the convention we use for subject prefix, I suggest you use

  'ARM: dts: imx7: ...'

Shawn

> ---
>  arch/arm/boot/dts/imx7d.dtsi | 11 ++++---
>  arch/arm/boot/dts/imx7s.dtsi | 78 ++++++++++++++++++++++++++------------------
>  2 files changed, 53 insertions(+), 36 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/imx7d.dtsi b/arch/arm/boot/dts/imx7d.dtsi
> index 7cbc2ff..4ced17c 100644
> --- a/arch/arm/boot/dts/imx7d.dtsi
> +++ b/arch/arm/boot/dts/imx7d.dtsi
> @@ -63,9 +63,11 @@
>  			clocks = <&clks IMX7D_MAIN_AXI_ROOT_CLK>;
>  			clock-names = "apb_pclk";
>  
> -			port {
> -				etm1_out_port: endpoint {
> -					remote-endpoint = <&ca_funnel_in_port1>;
> +			out-ports {
> +				port {
> +					etm1_out_port: endpoint {
> +						remote-endpoint = <&ca_funnel_in_port1>;
> +					};
>  				};
>  			};
>  		};
> @@ -148,11 +150,10 @@
>  	};
>  };
>  
> -&ca_funnel_ports {
> +&ca_funnel_in_ports {
>  	port at 1 {
>  		reg = <1>;
>  		ca_funnel_in_port1: endpoint {
> -			slave-mode;
>  			remote-endpoint = <&etm1_out_port>;
>  		};
>  	};
> diff --git a/arch/arm/boot/dts/imx7s.dtsi b/arch/arm/boot/dts/imx7s.dtsi
> index a052198..9176885 100644
> --- a/arch/arm/boot/dts/imx7s.dtsi
> +++ b/arch/arm/boot/dts/imx7s.dtsi
> @@ -106,7 +106,7 @@
>  		 */
>  		compatible = "arm,coresight-replicator";
>  
> -		ports {
> +		out-ports {
>  			#address-cells = <1>;
>  			#size-cells = <0>;
>  				/* replicator output ports */
> @@ -123,12 +123,15 @@
>  					remote-endpoint = <&etr_in_port>;
>  				};
>  			};
> +		};
>  
> -			/* replicator input port */
> -			port at 2 {
> +		in-ports {
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +
> +			port at 0 {
>  				reg = <0>;
>  				replicator_in_port0: endpoint {
> -					slave-mode;
>  					remote-endpoint = <&etf_out_port>;
>  				};
>  			};
> @@ -168,28 +171,31 @@
>  			clocks = <&clks IMX7D_MAIN_AXI_ROOT_CLK>;
>  			clock-names = "apb_pclk";
>  
> -			ca_funnel_ports: ports {
> +			ca_funnel_in_ports: in-ports {
>  				#address-cells = <1>;
>  				#size-cells = <0>;
>  
> -				/* funnel input ports */
>  				port at 0 {
>  					reg = <0>;
>  					ca_funnel_in_port0: endpoint {
> -						slave-mode;
>  						remote-endpoint = <&etm0_out_port>;
>  					};
>  				};
>  
> -				/* funnel output port */
> -				port at 2 {
> +				/* the other input ports are not connect to anything */
> +			};
> +
> +			out-ports {
> +				#address-cells = <1>;
> +				#size-cells = <0>;
> +
> +				port at 0 {
>  					reg = <0>;
>  					ca_funnel_out_port0: endpoint {
>  						remote-endpoint = <&hugo_funnel_in_port0>;
>  					};
>  				};
>  
> -				/* the other input ports are not connect to anything */
>  			};
>  		};
>  
> @@ -200,9 +206,11 @@
>  			clocks = <&clks IMX7D_MAIN_AXI_ROOT_CLK>;
>  			clock-names = "apb_pclk";
>  
> -			port {
> -				etm0_out_port: endpoint {
> -					remote-endpoint = <&ca_funnel_in_port0>;
> +			out-ports {
> +				port {
> +					etm0_out_port: endpoint {
> +						remote-endpoint = <&ca_funnel_in_port0>;
> +					};
>  				};
>  			};
>  		};
> @@ -213,15 +221,13 @@
>  			clocks = <&clks IMX7D_MAIN_AXI_ROOT_CLK>;
>  			clock-names = "apb_pclk";
>  
> -			ports {
> +			in-ports {
>  				#address-cells = <1>;
>  				#size-cells = <0>;
>  
> -				/* funnel input ports */
>  				port at 0 {
>  					reg = <0>;
>  					hugo_funnel_in_port0: endpoint {
> -						slave-mode;
>  						remote-endpoint = <&ca_funnel_out_port0>;
>  					};
>  				};
> @@ -229,18 +235,22 @@
>  				port at 1 {
>  					reg = <1>;
>  					hugo_funnel_in_port1: endpoint {
> -						slave-mode; /* M4 input */
> +						/* M4 input */
>  					};
>  				};
> +				/* the other input ports are not connect to anything */
> +			};
>  
> -				port at 2 {
> +			out-ports {
> +				#address-cells = <1>;
> +				#size-cells = <0>;
> +
> +				port at 0 {
>  					reg = <0>;
>  					hugo_funnel_out_port0: endpoint {
>  						remote-endpoint = <&etf_in_port>;
>  					};
>  				};
> -
> -				/* the other input ports are not connect to anything */
>  			};
>  		};
>  
> @@ -250,19 +260,23 @@
>  			clocks = <&clks IMX7D_MAIN_AXI_ROOT_CLK>;
>  			clock-names = "apb_pclk";
>  
> -			ports {
> +			in-ports {
>  				#address-cells = <1>;
>  				#size-cells = <0>;
>  
>  				port at 0 {
>  					reg = <0>;
>  					etf_in_port: endpoint {
> -						slave-mode;
>  						remote-endpoint = <&hugo_funnel_out_port0>;
>  					};
>  				};
> +			};
>  
> -				port at 1 {
> +			out-ports {
> +				#address-cells = <1>;
> +				#size-cells = <0>;
> +
> +				port at 0 {
>  					reg = <0>;
>  					etf_out_port: endpoint {
>  						remote-endpoint = <&replicator_in_port0>;
> @@ -277,10 +291,11 @@
>  			clocks = <&clks IMX7D_MAIN_AXI_ROOT_CLK>;
>  			clock-names = "apb_pclk";
>  
> -			port {
> -				etr_in_port: endpoint {
> -					slave-mode;
> -					remote-endpoint = <&replicator_out_port1>;
> +			in-ports {
> +				port {
> +					etr_in_port: endpoint {
> +						remote-endpoint = <&replicator_out_port1>;
> +					};
>  				};
>  			};
>  		};
> @@ -291,10 +306,11 @@
>  			clocks = <&clks IMX7D_MAIN_AXI_ROOT_CLK>;
>  			clock-names = "apb_pclk";
>  
> -			port {
> -				tpiu_in_port: endpoint {
> -					slave-mode;
> -					remote-endpoint = <&replicator_out_port0>;
> +			in-ports {
> +				port {
> +					tpiu_in_port: endpoint {
> +						remote-endpoint = <&replicator_out_port0>;
> +					};
>  				};
>  			};
>  		};
> -- 
> 2.7.4
> 

WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawnguo@kernel.org>
To: Suzuki K Poulose <suzuki.poulose@arm.com>
Cc: linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, robh@kernel.org,
	frowand.list@gmail.com, devicetree@vger.kernel.org,
	mathieu.poirier@linaro.org, arm@kernel.org, sudeep.holla@arm.com,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Fabio Estevam <fabio.estevam@nxp.com>
Subject: Re: [PATCH 06/11] dts: arm: imx7{d,s}: Update coresight binding for hardware ports
Date: Wed, 12 Sep 2018 10:21:57 +0800	[thread overview]
Message-ID: <20180912022152.GG28469@dragon> (raw)
In-Reply-To: <1536661032-30481-7-git-send-email-suzuki.poulose@arm.com>

On Tue, Sep 11, 2018 at 11:17:07AM +0100, Suzuki K Poulose wrote:
> Switch to the updated coresight bindings.
> 
> Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: Sascha Hauer <s.hauer@pengutronix.de>
> Cc: Pengutronix Kernel Team <kernel@pengutronix.de>
> Cc: Fabio Estevam <fabio.estevam@nxp.com>
> Cc: Mathieu Poirier <mathieu.poirier@linaro.org>
> Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>

As per the convention we use for subject prefix, I suggest you use

  'ARM: dts: imx7: ...'

Shawn

> ---
>  arch/arm/boot/dts/imx7d.dtsi | 11 ++++---
>  arch/arm/boot/dts/imx7s.dtsi | 78 ++++++++++++++++++++++++++------------------
>  2 files changed, 53 insertions(+), 36 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/imx7d.dtsi b/arch/arm/boot/dts/imx7d.dtsi
> index 7cbc2ff..4ced17c 100644
> --- a/arch/arm/boot/dts/imx7d.dtsi
> +++ b/arch/arm/boot/dts/imx7d.dtsi
> @@ -63,9 +63,11 @@
>  			clocks = <&clks IMX7D_MAIN_AXI_ROOT_CLK>;
>  			clock-names = "apb_pclk";
>  
> -			port {
> -				etm1_out_port: endpoint {
> -					remote-endpoint = <&ca_funnel_in_port1>;
> +			out-ports {
> +				port {
> +					etm1_out_port: endpoint {
> +						remote-endpoint = <&ca_funnel_in_port1>;
> +					};
>  				};
>  			};
>  		};
> @@ -148,11 +150,10 @@
>  	};
>  };
>  
> -&ca_funnel_ports {
> +&ca_funnel_in_ports {
>  	port@1 {
>  		reg = <1>;
>  		ca_funnel_in_port1: endpoint {
> -			slave-mode;
>  			remote-endpoint = <&etm1_out_port>;
>  		};
>  	};
> diff --git a/arch/arm/boot/dts/imx7s.dtsi b/arch/arm/boot/dts/imx7s.dtsi
> index a052198..9176885 100644
> --- a/arch/arm/boot/dts/imx7s.dtsi
> +++ b/arch/arm/boot/dts/imx7s.dtsi
> @@ -106,7 +106,7 @@
>  		 */
>  		compatible = "arm,coresight-replicator";
>  
> -		ports {
> +		out-ports {
>  			#address-cells = <1>;
>  			#size-cells = <0>;
>  				/* replicator output ports */
> @@ -123,12 +123,15 @@
>  					remote-endpoint = <&etr_in_port>;
>  				};
>  			};
> +		};
>  
> -			/* replicator input port */
> -			port@2 {
> +		in-ports {
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +
> +			port@0 {
>  				reg = <0>;
>  				replicator_in_port0: endpoint {
> -					slave-mode;
>  					remote-endpoint = <&etf_out_port>;
>  				};
>  			};
> @@ -168,28 +171,31 @@
>  			clocks = <&clks IMX7D_MAIN_AXI_ROOT_CLK>;
>  			clock-names = "apb_pclk";
>  
> -			ca_funnel_ports: ports {
> +			ca_funnel_in_ports: in-ports {
>  				#address-cells = <1>;
>  				#size-cells = <0>;
>  
> -				/* funnel input ports */
>  				port@0 {
>  					reg = <0>;
>  					ca_funnel_in_port0: endpoint {
> -						slave-mode;
>  						remote-endpoint = <&etm0_out_port>;
>  					};
>  				};
>  
> -				/* funnel output port */
> -				port@2 {
> +				/* the other input ports are not connect to anything */
> +			};
> +
> +			out-ports {
> +				#address-cells = <1>;
> +				#size-cells = <0>;
> +
> +				port@0 {
>  					reg = <0>;
>  					ca_funnel_out_port0: endpoint {
>  						remote-endpoint = <&hugo_funnel_in_port0>;
>  					};
>  				};
>  
> -				/* the other input ports are not connect to anything */
>  			};
>  		};
>  
> @@ -200,9 +206,11 @@
>  			clocks = <&clks IMX7D_MAIN_AXI_ROOT_CLK>;
>  			clock-names = "apb_pclk";
>  
> -			port {
> -				etm0_out_port: endpoint {
> -					remote-endpoint = <&ca_funnel_in_port0>;
> +			out-ports {
> +				port {
> +					etm0_out_port: endpoint {
> +						remote-endpoint = <&ca_funnel_in_port0>;
> +					};
>  				};
>  			};
>  		};
> @@ -213,15 +221,13 @@
>  			clocks = <&clks IMX7D_MAIN_AXI_ROOT_CLK>;
>  			clock-names = "apb_pclk";
>  
> -			ports {
> +			in-ports {
>  				#address-cells = <1>;
>  				#size-cells = <0>;
>  
> -				/* funnel input ports */
>  				port@0 {
>  					reg = <0>;
>  					hugo_funnel_in_port0: endpoint {
> -						slave-mode;
>  						remote-endpoint = <&ca_funnel_out_port0>;
>  					};
>  				};
> @@ -229,18 +235,22 @@
>  				port@1 {
>  					reg = <1>;
>  					hugo_funnel_in_port1: endpoint {
> -						slave-mode; /* M4 input */
> +						/* M4 input */
>  					};
>  				};
> +				/* the other input ports are not connect to anything */
> +			};
>  
> -				port@2 {
> +			out-ports {
> +				#address-cells = <1>;
> +				#size-cells = <0>;
> +
> +				port@0 {
>  					reg = <0>;
>  					hugo_funnel_out_port0: endpoint {
>  						remote-endpoint = <&etf_in_port>;
>  					};
>  				};
> -
> -				/* the other input ports are not connect to anything */
>  			};
>  		};
>  
> @@ -250,19 +260,23 @@
>  			clocks = <&clks IMX7D_MAIN_AXI_ROOT_CLK>;
>  			clock-names = "apb_pclk";
>  
> -			ports {
> +			in-ports {
>  				#address-cells = <1>;
>  				#size-cells = <0>;
>  
>  				port@0 {
>  					reg = <0>;
>  					etf_in_port: endpoint {
> -						slave-mode;
>  						remote-endpoint = <&hugo_funnel_out_port0>;
>  					};
>  				};
> +			};
>  
> -				port@1 {
> +			out-ports {
> +				#address-cells = <1>;
> +				#size-cells = <0>;
> +
> +				port@0 {
>  					reg = <0>;
>  					etf_out_port: endpoint {
>  						remote-endpoint = <&replicator_in_port0>;
> @@ -277,10 +291,11 @@
>  			clocks = <&clks IMX7D_MAIN_AXI_ROOT_CLK>;
>  			clock-names = "apb_pclk";
>  
> -			port {
> -				etr_in_port: endpoint {
> -					slave-mode;
> -					remote-endpoint = <&replicator_out_port1>;
> +			in-ports {
> +				port {
> +					etr_in_port: endpoint {
> +						remote-endpoint = <&replicator_out_port1>;
> +					};
>  				};
>  			};
>  		};
> @@ -291,10 +306,11 @@
>  			clocks = <&clks IMX7D_MAIN_AXI_ROOT_CLK>;
>  			clock-names = "apb_pclk";
>  
> -			port {
> -				tpiu_in_port: endpoint {
> -					slave-mode;
> -					remote-endpoint = <&replicator_out_port0>;
> +			in-ports {
> +				port {
> +					tpiu_in_port: endpoint {
> +						remote-endpoint = <&replicator_out_port0>;
> +					};
>  				};
>  			};
>  		};
> -- 
> 2.7.4
> 

  reply	other threads:[~2018-09-12  2:21 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-11 10:17 [PATCH 00/11] dts: Update coresight device tree bindings Suzuki K Poulose
2018-09-11 10:17 ` Suzuki K Poulose
2018-09-11 10:17 ` Suzuki K Poulose
2018-09-11 10:17 ` [PATCH 01/11] Documentation: dts: Update coresight binding examples Suzuki K Poulose
2018-09-11 10:17   ` Suzuki K Poulose
2018-09-11 10:17   ` Suzuki K Poulose
2018-09-17  5:45   ` Rob Herring
2018-09-17  5:45     ` Rob Herring
2018-09-11 10:17 ` [PATCH 02/11] dts: hisilicon: Update coresight bindings for hardware ports Suzuki K Poulose
2018-09-11 10:17   ` Suzuki K Poulose
2018-09-12 10:47   ` leo.yan at linaro.org
2018-09-12 10:47     ` leo.yan
2018-09-12 12:42     ` Suzuki K Poulose
2018-09-12 12:42       ` Suzuki K Poulose
2018-09-11 10:17 ` [PATCH 03/11] dts: spreadtrum: " Suzuki K Poulose
2018-09-11 10:17   ` Suzuki K Poulose
2018-09-11 10:17 ` [PATCH 04/11] dts: qcom: " Suzuki K Poulose
2018-09-11 10:17   ` Suzuki K Poulose
2018-09-12 10:17   ` leo.yan at linaro.org
2018-09-12 10:17     ` leo.yan
2018-09-12 10:31     ` Suzuki K Poulose
2018-09-12 10:31       ` Suzuki K Poulose
2018-09-11 10:17 ` [PATCH 05/11] dts: arm: hisilicon: " Suzuki K Poulose
2018-09-11 10:17   ` Suzuki K Poulose
2018-09-11 10:17 ` [PATCH 06/11] dts: arm: imx7{d, s}: Update coresight binding " Suzuki K Poulose
2018-09-11 10:17   ` [PATCH 06/11] dts: arm: imx7{d,s}: " Suzuki K Poulose
2018-09-12  2:21   ` Shawn Guo [this message]
2018-09-12  2:21     ` Shawn Guo
2018-09-12  8:28     ` Suzuki K Poulose
2018-09-12  8:28       ` Suzuki K Poulose
2018-09-11 10:17 ` [PATCH 07/11] dts: arm: omap: Update coresight bindings " Suzuki K Poulose
2018-09-11 10:17   ` Suzuki K Poulose
2018-09-11 10:17 ` [PATCH 08/11] dts: arm: qcom: " Suzuki K Poulose
2018-09-11 10:17   ` Suzuki K Poulose
2018-09-11 10:17 ` [PATCH 09/11] dts: sama5d2: " Suzuki K Poulose
2018-09-11 10:17   ` Suzuki K Poulose
2018-09-11 10:17 ` [PATCH 10/11] dts: ste-dbx5x0: Update coresight bindings for hardware port Suzuki K Poulose
2018-09-11 10:17   ` Suzuki K Poulose
2018-09-11 10:17 ` [PATCH 11/11] dts: tc2: Update coresight bindings for hardware ports Suzuki K Poulose
2018-09-11 10:17   ` Suzuki K Poulose
2018-09-11 17:01   ` Sudeep Holla
2018-09-11 17:01     ` Sudeep Holla
2018-09-11 17:15     ` Suzuki K Poulose
2018-09-11 17:15       ` Suzuki K Poulose
2018-09-11 17:23       ` Sudeep Holla
2018-09-11 17:23         ` Sudeep Holla
2018-09-11 17:30         ` Suzuki K Poulose
2018-09-11 17:30           ` Suzuki K Poulose
2018-09-11 21:21 ` [PATCH 00/11] dts: Update coresight device tree bindings Suzuki K Poulose
2018-09-11 21:21   ` Suzuki K Poulose
2018-09-11 21:21   ` Suzuki K Poulose

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180912022152.GG28469@dragon \
    --to=shawnguo@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.