Re: [rocko/master][PATCH v6 2/5] arm-compute-library: Machine Learning library for ARM.

From: Denys Dmytriyenko <denys@ti.com>
To: Jacob Stiffler <j-stiffler@ti.com>
Cc: meta-arago@arago-project.org
Subject: Re: [rocko/master][PATCH v6 2/5] arm-compute-library: Machine Learning library for ARM.
Date: Thu, 13 Sep 2018 14:22:15 -0400	[thread overview]
Message-ID: <20180913182215.GD12296@beryl> (raw)
In-Reply-To: <d5bb480e-d0a4-d442-68e6-444ab01c9187@ti.com>

On Thu, Sep 13, 2018 at 02:21:25PM -0400, Jacob Stiffler wrote:
> 
> 
> On 9/13/2018 2:12 PM, Denys Dmytriyenko wrote:
> >On Thu, Sep 13, 2018 at 01:56:24PM -0400, Jacob Stiffler wrote:
> >>From: Qin Su <qsu@ti.com>
> >>
> >>The ARM Computer Vision and Machine Learning library is a set of functions
> >>optimised for both ARM CPUs and GPUs using SIMD technologies.
> >>
> >>Signed-off-by: Qin Su <qsu@ti.com>
> >>Signed-off-by: Jacob Stiffler <j-stiffler@ti.com>
> >>---
> >>Changes from previous versions:
> >>* Add "_git" suffix to recipe name.
> >>* Add version.
> >>* Add branch option for SRC_URI.
> >>* For installation, use install by looping over libraries.
> >>* Remove unnecessary checksums for SRC_URI.
> >>* Set armv7a as COMPATIBLE_MACHINE as this is hardcoded in
> >>   EXTRA_OESCONS.
> >^^^ Thanks a lot for all the fixes!
> >
> >BTW, is this recipe available in any other layer?
> 
> I did a quick search and could not find anything existing, but I did find a
> request for one on the github [1].
> 
> [1] https://github.com/ARM-software/ComputeLibrary/issues/512

Ok, thanks. Let's add it here and then try to upstream it to meta-oe.

> >>  .../arm-compute-library/arm-compute-library_git.bb | 44 ++++++++++++++++++++++
> >>  1 file changed, 44 insertions(+)
> >>  create mode 100644 meta-arago-extras/recipes-support/arm-compute-library/arm-compute-library_git.bb
> >>
> >>diff --git a/meta-arago-extras/recipes-support/arm-compute-library/arm-compute-library_git.bb b/meta-arago-extras/recipes-support/arm-compute-library/arm-compute-library_git.bb
> >>new file mode 100644
> >>index 0000000..23e31cd
> >>--- /dev/null
> >>+++ b/meta-arago-extras/recipes-support/arm-compute-library/arm-compute-library_git.bb
> >>@@ -0,0 +1,44 @@
> >>+DESCRIPTION = "The ARM Computer Vision and Machine Learning library is a set of functions optimised for both ARM CPUs and GPUs."

Please provide short SUMMARY as well, maybe just first 8 words.

Again, longer DESCRIPTION is optional, but shorter SUMMARY is required.

> >>+LICENSE = "MIT"
> >>+LIC_FILES_CHKSUM = "file://LICENSE;md5=e2c93841b20cd522af621cabaea3aef8"
> >>+
> >>+COMPATIBLE_MACHINE = "armv7a"
> >>+
> >>+SRC_URI = " \
> >>+    git://github.com/ARM-software/ComputeLibrary.git;branch=${BRANCH} \
> >>+"
> >>+
> >>+PV  = "18.05"
> >>+
> >>+BRANCH = "master"
> >>+SRCREV = "e2542c9f35ca427286822cd0c9296f49914f78b0"
> >>+
> >>+S = "${WORKDIR}/git"
> >>+
> >>+do_compile_prepend() {
> >>+    unset CC CXX
> >>+}
> >>+
> >>+inherit scons
> >>+
> >>+EXTRA_OESCONS = "arch=armv7a extra_cxx_flags="-fPIC" benchmark_tests=1 validation_tests=0 neon=1 openmp=1 opencl=0"
> >>+
> >>+LIBS += "-larmpl_lp64_mp"
> >>+
> >>+do_install() {
> >>+    CP_ARGS="-Prf --preserve=mode,timestamps --no-preserve=ownership"
> >>+
> >>+    install -d ${D}${libdir}
> >>+    for lib in ${S}/build/*.so
> >>+    do
> >>+        install -m 0644 $lib ${D}${libdir}
> >>+    done
> >>+
> >>+    install -d ${D}${datadir}/${PN}
> >>+    cp $CP_ARGS ${S}/. ${D}${datadir}/${PN}
> >>+}
> >>+
> >>+INSANE_SKIP_${PN}-dev = "dev-elf"
> >>+
> >>+PACKAGES =+ "${PN}-source"
> >>+FILES_${PN}-source = "${datadir}/${PN}"
> >>-- 
> >>2.7.4
> >>
> >>_______________________________________________
> >>meta-arago mailing list
> >>meta-arago@arago-project.org
> >>http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
> 