Re: [rocko/master][PATCH v6 4/5] armnn-tensorflow: tensorflow protobuf files for building tensorflow models in armnn

From: Denys Dmytriyenko <denys@ti.com>
To: Jacob Stiffler <j-stiffler@ti.com>
Cc: meta-arago@arago-project.org
Subject: Re: [rocko/master][PATCH v6 4/5] armnn-tensorflow: tensorflow protobuf files for building tensorflow models in armnn
Date: Thu, 13 Sep 2018 15:34:06 -0400	[thread overview]
Message-ID: <20180913193406.GN12296@beryl> (raw)
In-Reply-To: <1536861387-7418-5-git-send-email-j-stiffler@ti.com>

On Thu, Sep 13, 2018 at 01:56:26PM -0400, Jacob Stiffler wrote:
> From: Qin Su <qsu@ti.com>
> 
> Signed-off-by: Qin Su <qsu@ti.com>
> Signed-off-by: Jacob Stiffler <j-stiffler@ti.com>
> ---
> Changes from previous versions:
> * Add "_git" suffix to recipe name.
> * Add version.
> * DESCRIPTION --> SUMMARY.
> * Add branch option for SRC_URI.
> * Add dependency on protobuf-native
> * Add Apache license version (Apache-2.0)
> 
>  .../armnn-tensorflow/armnn-tensorflow_git.bb       | 25 ++++++++++++++++++++++
>  1 file changed, 25 insertions(+)
>  create mode 100644 meta-arago-extras/recipes-support/armnn-tensorflow/armnn-tensorflow_git.bb
> 
> diff --git a/meta-arago-extras/recipes-support/armnn-tensorflow/armnn-tensorflow_git.bb b/meta-arago-extras/recipes-support/armnn-tensorflow/armnn-tensorflow_git.bb
> new file mode 100644
> index 0000000..f85c6a8
> --- /dev/null
> +++ b/meta-arago-extras/recipes-support/armnn-tensorflow/armnn-tensorflow_git.bb
> @@ -0,0 +1,25 @@
> +SUMMARY = "Tensorflow protobuf files - used in ARMNN for Tensorflow network models"
> +LICENSE = "Apache-2.0"
> +LIC_FILES_CHKSUM = "file://LICENSE;md5=01e86893010a1b87e69a213faa753ebd"
> +
> +SRC_URI = " \
> +    git://github.com/tensorflow/tensorflow.git;name=tensorflow; \
> +    git://github.com/ARM-software/armnn.git;name=armnn;subdir=${WORKDIR}/armnn;destsuffix=armnn \
> +"
> +
> +PV = "1.10.0"
> +
> +SRCREV_tensorflow = "aed8f42bafabf11c5d92ce4109a5e0408b31f9c5"
> +SRCREV_armnn = "4c7098bfeab1ffe1cdc77f6c15548d3e73274746"

Do you need to specify SRCREV_FORMAT here?

> +DEPENDS = "protobuf-native"
> +
> +S = "${WORKDIR}/git"
> +
> +do_install() {
> +    install -d ${D}${datadir}/${PN}
> +    ${WORKDIR}/armnn/scripts/generate_tensorflow_protobuf.sh ${D}${datadir}/${PN} ${STAGING_DIR_NATIVE}${prefix}
> +}
> +
> +PACKAGES =+ "${PN}-source"
> +FILES_${PN}-source = "${datadir}/${PN}"

Hmm, what are those files, what are these sources? Should there be some 
description about what is being the output of this packages and what and where 
that gets installed?

> -- 
> 2.7.4
> 
> _______________________________________________
> meta-arago mailing list
> meta-arago@arago-project.org
> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago