All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wolfram Sang <wsa@the-dreams.de>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>,
	dmaengine@vger.kernel.org,
	Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
	Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Subject: [RFC] dmaengine: rcar-dmac: set scatter/gather max segment size
Date: Fri, 14 Sep 2018 15:35:18 +0200	[thread overview]
Message-ID: <20180914133518.GA1413@kunai> (raw)

Hi Geert,

> > +       dmac->dev->dma_parms = &dmac->parms;
> > +       dma_set_max_seg_size(dmac->dev, 0x01000000);
> 
> That is one too much, cfr.
> 
>     drivers/dma/sh/rcar-dmac.c:#define RCAR_DMATCR_MASK             0x00ffffff

I see. Will fix and send an updated patch. Nice to see that I was not
totally wrong but just off-by-one.

> And yes, this depends on the data length, which is not known at probe time.
> Of course, dma_set_max_seg_size(dmac->dev, RCAR_DMATCR_MASK)
> should be safe, albeit (slightly) suboptimal.

True. But still *way* better than the current default of 64K.

Thanks for the heads up!

Regards,

   Wolfram

WARNING: multiple messages have this Message-ID (diff)
From: Wolfram Sang <wsa@the-dreams.de>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>,
	dmaengine@vger.kernel.org,
	Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
	Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Subject: Re: [RFC PATCH] dmaengine: rcar-dmac: set scatter/gather max segment size
Date: Fri, 14 Sep 2018 15:35:18 +0200	[thread overview]
Message-ID: <20180914133518.GA1413@kunai> (raw)
In-Reply-To: <CAMuHMdWDKapncucL2t_hGDop_XfgJrLmEUOwC5zxZOBKD7PQtQ@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 665 bytes --]

Hi Geert,

> > +       dmac->dev->dma_parms = &dmac->parms;
> > +       dma_set_max_seg_size(dmac->dev, 0x01000000);
> 
> That is one too much, cfr.
> 
>     drivers/dma/sh/rcar-dmac.c:#define RCAR_DMATCR_MASK             0x00ffffff

I see. Will fix and send an updated patch. Nice to see that I was not
totally wrong but just off-by-one.

> And yes, this depends on the data length, which is not known at probe time.
> Of course, dma_set_max_seg_size(dmac->dev, RCAR_DMATCR_MASK)
> should be safe, albeit (slightly) suboptimal.

True. But still *way* better than the current default of 64K.

Thanks for the heads up!

Regards,

   Wolfram


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

             reply	other threads:[~2018-09-14 13:35 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-14 13:35 Wolfram Sang [this message]
2018-09-14 13:35 ` [RFC PATCH] dmaengine: rcar-dmac: set scatter/gather max segment size Wolfram Sang
  -- strict thread matches above, loose matches on Subject: below --
2018-09-14 12:13 [RFC] " Geert Uytterhoeven
2018-09-14 12:13 ` [RFC PATCH] " Geert Uytterhoeven
2018-09-13 14:52 [RFC] " Wolfram Sang
2018-09-13 14:52 ` [RFC PATCH] " Wolfram Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180914133518.GA1413@kunai \
    --to=wsa@the-dreams.de \
    --cc=dmaengine@vger.kernel.org \
    --cc=geert@linux-m68k.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=wsa+renesas@sang-engineering.com \
    --cc=yoshihiro.shimoda.uh@renesas.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.