From: "Theodore Y. Ts'o" <tytso-3s7WtUTddSA@public.gmane.org>
To: Toshi Kani <toshi.kani-ZPxbGqLxI0U@public.gmane.org>
Cc: jack-AlSwsSmVLrQ@public.gmane.org,
linux-nvdimm-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
adilger.kernel-m1MBpc4rdrD3fQ9qLvQP4Q@public.gmane.org,
linux-ext4-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v2 2/3] ext4, dax: set ext4_dax_aops for dax files
Date: Sat, 15 Sep 2018 21:56:46 -0400 [thread overview]
Message-ID: <20180916015646.GE8652@thunk.org> (raw)
In-Reply-To: <20180914145114.11122-3-toshi.kani-ZPxbGqLxI0U@public.gmane.org>
On Fri, Sep 14, 2018 at 08:51:13AM -0600, Toshi Kani wrote:
> Sync syscall to DAX file needs to flush processor cache, but it
> currently does not flush to existing DAX files. This is because
> 'ext4_da_aops' is set to address_space_operations of existing DAX
> files, instead of 'ext4_dax_aops', since S_DAX flag is set after
> ext4_set_aops() in the open path.
>
> New file
> --------
> lookup_open
> ext4_create
> __ext4_new_inode
> ext4_set_inode_flags // Set S_DAX flag
> ext4_set_aops // Set aops to ext4_dax_aops
>
> Existing file
> -------------
> lookup_open
> ext4_lookup
> ext4_iget
> ext4_set_aops // Set aops to ext4_da_aops
> ext4_set_inode_flags // Set S_DAX flag
>
> Change ext4_iget() to initialize i_flags before ext4_set_aops().
>
> Fixes: 5f0663bb4a64 ("ext4, dax: introduce ext4_dax_aops")
> Signed-off-by: Toshi Kani <toshi.kani-ZPxbGqLxI0U@public.gmane.org>
> Suggested-by: Jan Kara <jack-AlSwsSmVLrQ@public.gmane.org>
> Cc: Jan Kara <jack-AlSwsSmVLrQ@public.gmane.org>
> Cc: Dan Williams <dan.j.williams-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> Cc: "Theodore Ts'o" <tytso-3s7WtUTddSA@public.gmane.org>
> Cc: Andreas Dilger <adilger.kernel-m1MBpc4rdrD3fQ9qLvQP4Q@public.gmane.org>
> Cc: <stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Thanks, applied.
- Ted
WARNING: multiple messages have this Message-ID (diff)
From: "Theodore Y. Ts'o" <tytso@mit.edu>
To: Toshi Kani <toshi.kani@hpe.com>
Cc: jack@suse.cz, linux-nvdimm@lists.01.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org,
adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org
Subject: Re: [PATCH v2 2/3] ext4, dax: set ext4_dax_aops for dax files
Date: Sat, 15 Sep 2018 21:56:46 -0400 [thread overview]
Message-ID: <20180916015646.GE8652@thunk.org> (raw)
In-Reply-To: <20180914145114.11122-3-toshi.kani@hpe.com>
On Fri, Sep 14, 2018 at 08:51:13AM -0600, Toshi Kani wrote:
> Sync syscall to DAX file needs to flush processor cache, but it
> currently does not flush to existing DAX files. This is because
> 'ext4_da_aops' is set to address_space_operations of existing DAX
> files, instead of 'ext4_dax_aops', since S_DAX flag is set after
> ext4_set_aops() in the open path.
>
> New file
> --------
> lookup_open
> ext4_create
> __ext4_new_inode
> ext4_set_inode_flags // Set S_DAX flag
> ext4_set_aops // Set aops to ext4_dax_aops
>
> Existing file
> -------------
> lookup_open
> ext4_lookup
> ext4_iget
> ext4_set_aops // Set aops to ext4_da_aops
> ext4_set_inode_flags // Set S_DAX flag
>
> Change ext4_iget() to initialize i_flags before ext4_set_aops().
>
> Fixes: 5f0663bb4a64 ("ext4, dax: introduce ext4_dax_aops")
> Signed-off-by: Toshi Kani <toshi.kani@hpe.com>
> Suggested-by: Jan Kara <jack@suse.cz>
> Cc: Jan Kara <jack@suse.cz>
> Cc: Dan Williams <dan.j.williams@intel.com>
> Cc: "Theodore Ts'o" <tytso@mit.edu>
> Cc: Andreas Dilger <adilger.kernel@dilger.ca>
> Cc: <stable@vger.kernel.org>
Thanks, applied.
- Ted
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
WARNING: multiple messages have this Message-ID (diff)
From: "Theodore Y. Ts'o" <tytso@mit.edu>
To: Toshi Kani <toshi.kani@hpe.com>
Cc: jack@suse.cz, dan.j.williams@intel.com, adilger.kernel@dilger.ca,
linux-ext4@vger.kernel.org, linux-nvdimm@lists.01.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH v2 2/3] ext4, dax: set ext4_dax_aops for dax files
Date: Sat, 15 Sep 2018 21:56:46 -0400 [thread overview]
Message-ID: <20180916015646.GE8652@thunk.org> (raw)
In-Reply-To: <20180914145114.11122-3-toshi.kani@hpe.com>
On Fri, Sep 14, 2018 at 08:51:13AM -0600, Toshi Kani wrote:
> Sync syscall to DAX file needs to flush processor cache, but it
> currently does not flush to existing DAX files. This is because
> 'ext4_da_aops' is set to address_space_operations of existing DAX
> files, instead of 'ext4_dax_aops', since S_DAX flag is set after
> ext4_set_aops() in the open path.
>
> New file
> --------
> lookup_open
> ext4_create
> __ext4_new_inode
> ext4_set_inode_flags // Set S_DAX flag
> ext4_set_aops // Set aops to ext4_dax_aops
>
> Existing file
> -------------
> lookup_open
> ext4_lookup
> ext4_iget
> ext4_set_aops // Set aops to ext4_da_aops
> ext4_set_inode_flags // Set S_DAX flag
>
> Change ext4_iget() to initialize i_flags before ext4_set_aops().
>
> Fixes: 5f0663bb4a64 ("ext4, dax: introduce ext4_dax_aops")
> Signed-off-by: Toshi Kani <toshi.kani@hpe.com>
> Suggested-by: Jan Kara <jack@suse.cz>
> Cc: Jan Kara <jack@suse.cz>
> Cc: Dan Williams <dan.j.williams@intel.com>
> Cc: "Theodore Ts'o" <tytso@mit.edu>
> Cc: Andreas Dilger <adilger.kernel@dilger.ca>
> Cc: <stable@vger.kernel.org>
Thanks, applied.
- Ted
next prev parent reply other threads:[~2018-09-16 1:56 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-14 14:51 [PATCH v2 0/3] fix sync to flush processor cache for ext2/4 DAX files Toshi Kani
2018-09-14 14:51 ` Toshi Kani
2018-09-14 14:51 ` Toshi Kani
[not found] ` <20180914145114.11122-1-toshi.kani-ZPxbGqLxI0U@public.gmane.org>
2018-09-14 14:51 ` [PATCH v2 1/3] ext4, dax: add ext4_bmap to ext4_dax_aops Toshi Kani
2018-09-14 14:51 ` Toshi Kani
2018-09-14 14:51 ` Toshi Kani
2018-09-16 1:32 ` Theodore Y. Ts'o
2018-09-16 1:32 ` Theodore Y. Ts'o
2018-09-14 14:51 ` [PATCH v2 2/3] ext4, dax: set ext4_dax_aops for dax files Toshi Kani
2018-09-14 14:51 ` Toshi Kani
2018-09-14 14:51 ` Toshi Kani
[not found] ` <20180914145114.11122-3-toshi.kani-ZPxbGqLxI0U@public.gmane.org>
2018-09-16 1:56 ` Theodore Y. Ts'o [this message]
2018-09-16 1:56 ` Theodore Y. Ts'o
2018-09-16 1:56 ` Theodore Y. Ts'o
2018-09-14 14:51 ` [PATCH v2 3/3] ext2, dax: set ext2_dax_aops " Toshi Kani
2018-09-14 14:51 ` Toshi Kani
2018-09-14 14:51 ` Toshi Kani
2018-09-17 16:37 ` Jan Kara
2018-09-17 16:37 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180916015646.GE8652@thunk.org \
--to=tytso-3s7wtutddsa@public.gmane.org \
--cc=adilger.kernel-m1MBpc4rdrD3fQ9qLvQP4Q@public.gmane.org \
--cc=jack-AlSwsSmVLrQ@public.gmane.org \
--cc=linux-ext4-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-nvdimm-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org \
--cc=stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=toshi.kani-ZPxbGqLxI0U@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.