* [PATCH] media: platform: remove redundant null pointer check before of_node_put
@ 2018-09-16 13:16 zhong jiang
2018-09-16 15:43 ` Benoit Parrot
0 siblings, 1 reply; 2+ messages in thread
From: zhong jiang @ 2018-09-16 13:16 UTC (permalink / raw)
To: mchehab; +Cc: bparrot, linux-media, linux-kernel
of_node_put has taken the null pinter check into account. So it is
safe to remove the duplicated check before of_node_put.
Signed-off-by: zhong jiang <zhongjiang@huawei.com>
---
drivers/media/platform/ti-vpe/cal.c | 12 ++++--------
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/drivers/media/platform/ti-vpe/cal.c b/drivers/media/platform/ti-vpe/cal.c
index cc052b2..5f9d4e0 100644
--- a/drivers/media/platform/ti-vpe/cal.c
+++ b/drivers/media/platform/ti-vpe/cal.c
@@ -1747,14 +1747,10 @@ static int of_cal_create_instance(struct cal_ctx *ctx, int inst)
}
cleanup_exit:
- if (remote_ep)
- of_node_put(remote_ep);
- if (sensor_node)
- of_node_put(sensor_node);
- if (ep_node)
- of_node_put(ep_node);
- if (port)
- of_node_put(port);
+ of_node_put(remote_ep);
+ of_node_put(sensor_node);
+ of_node_put(ep_node);
+ of_node_put(port);
return ret;
}
--
1.7.12.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] media: platform: remove redundant null pointer check before of_node_put
2018-09-16 13:16 [PATCH] media: platform: remove redundant null pointer check before of_node_put zhong jiang
@ 2018-09-16 15:43 ` Benoit Parrot
0 siblings, 0 replies; 2+ messages in thread
From: Benoit Parrot @ 2018-09-16 15:43 UTC (permalink / raw)
To: zhong jiang; +Cc: mchehab, linux-media, linux-kernel
Zhong,
Thank you for the patch.
zhong jiang <zhongjiang@huawei.com> wrote on Sun [2018-Sep-16 21:16:51 +0800]:
> of_node_put has taken the null pinter check into account. So it is
s/pinter/pointer/
> safe to remove the duplicated check before of_node_put.
>
> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
with the above change,
Reviewed-by: Benoit Parrot <bparrot@ti.com>
> ---
> drivers/media/platform/ti-vpe/cal.c | 12 ++++--------
> 1 file changed, 4 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/media/platform/ti-vpe/cal.c b/drivers/media/platform/ti-vpe/cal.c
> index cc052b2..5f9d4e0 100644
> --- a/drivers/media/platform/ti-vpe/cal.c
> +++ b/drivers/media/platform/ti-vpe/cal.c
> @@ -1747,14 +1747,10 @@ static int of_cal_create_instance(struct cal_ctx *ctx, int inst)
> }
>
> cleanup_exit:
> - if (remote_ep)
> - of_node_put(remote_ep);
> - if (sensor_node)
> - of_node_put(sensor_node);
> - if (ep_node)
> - of_node_put(ep_node);
> - if (port)
> - of_node_put(port);
> + of_node_put(remote_ep);
> + of_node_put(sensor_node);
> + of_node_put(ep_node);
> + of_node_put(port);
>
> return ret;
> }
> --
> 1.7.12.4
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-09-16 21:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-09-16 13:16 [PATCH] media: platform: remove redundant null pointer check before of_node_put zhong jiang
2018-09-16 15:43 ` Benoit Parrot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.