From: gregkh@linuxfoundation.org (Greg Kroah-Hartman)
Subject: [PATCH 0/8] staging: erofs: error handing and more tracepoints
Date: Tue, 18 Sep 2018 15:09:11 +0200 [thread overview]
Message-ID: <20180918130911.GA16187@kroah.com> (raw)
In-Reply-To: <20180918130337.jtq6ziqp6efr3fq4@mwanda>
On Tue, Sep 18, 2018@04:03:37PM +0300, Dan Carpenter wrote:
> On Tue, Sep 18, 2018@08:31:22PM +0800, Gao Xiang wrote:
> > (I have no clang environment to build kernel yet... :( I will try later, but I have no idea why it happens,
> > and it seems a false warning).
> >
> > Thanks,
> > Gao Xiang
> >
> > >
> > > Or is gcc just being "dumb" here? What about clang, have you tried
> > > building it with that compiler as well?
>
> Yeah. Gcc is wrong. Gcc used to be extra conservative and missed a
> bunch of bugs, but I guess now they're going in to opposite direction?
>
> Smatch gets this correct, but you have to rebuild the cross function DB
> twice to make the warning go away. It could be because it starts out
> with the old vle_get_logical_extent_head() information so it thinks it
> knows how that function works.
Ok, thanks for checking (both of you). Just initialize the variable to
keep gcc from printing foolish warnings.
thanks,
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Gao Xiang <gaoxiang25@huawei.com>,
devel@driverdev.osuosl.org, Miao Xie <miaoxie@huawei.com>,
Chao Yu <yuchao0@huawei.com>, LKML <linux-kernel@vger.kernel.org>,
weidu.du@huawei.com, linux-erofs@lists.ozlabs.org
Subject: Re: [PATCH 0/8] staging: erofs: error handing and more tracepoints
Date: Tue, 18 Sep 2018 15:09:11 +0200 [thread overview]
Message-ID: <20180918130911.GA16187@kroah.com> (raw)
In-Reply-To: <20180918130337.jtq6ziqp6efr3fq4@mwanda>
On Tue, Sep 18, 2018 at 04:03:37PM +0300, Dan Carpenter wrote:
> On Tue, Sep 18, 2018 at 08:31:22PM +0800, Gao Xiang wrote:
> > (I have no clang environment to build kernel yet... :( I will try later, but I have no idea why it happens,
> > and it seems a false warning).
> >
> > Thanks,
> > Gao Xiang
> >
> > >
> > > Or is gcc just being "dumb" here? What about clang, have you tried
> > > building it with that compiler as well?
>
> Yeah. Gcc is wrong. Gcc used to be extra conservative and missed a
> bunch of bugs, but I guess now they're going in to opposite direction?
>
> Smatch gets this correct, but you have to rebuild the cross function DB
> twice to make the warning go away. It could be because it starts out
> with the old vle_get_logical_extent_head() information so it thinks it
> knows how that function works.
Ok, thanks for checking (both of you). Just initialize the variable to
keep gcc from printing foolish warnings.
thanks,
greg k-h
next prev parent reply other threads:[~2018-09-18 13:09 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-14 14:40 [PATCH 0/8] staging: erofs: error handing and more tracepoints Gao Xiang
2018-09-14 14:40 ` Gao Xiang
2018-09-14 14:40 ` [PATCH 1/8] staging: erofs: fix a missing endian conversion Gao Xiang
2018-09-14 14:40 ` Gao Xiang
2018-09-14 14:40 ` [PATCH 2/8] staging: erofs: clean up z_erofs_map_blocks_iter Gao Xiang
2018-09-14 14:40 ` Gao Xiang
2018-09-14 14:40 ` [PATCH 3/8] staging: erofs: complete error handing of z_erofs_map_blocks_iter Gao Xiang
2018-09-14 14:40 ` Gao Xiang
2018-09-14 14:40 ` [PATCH 4/8] staging: erofs: fix a bug when appling cache strategy Gao Xiang
2018-09-14 14:40 ` Gao Xiang
2018-09-14 14:40 ` [PATCH 5/8] staging: erofs: complete error handing of z_erofs_do_read_page Gao Xiang
2018-09-14 14:40 ` Gao Xiang
2018-09-14 14:40 ` [PATCH 6/8] staging: erofs: avoid magic constants when initializing clusterbits Gao Xiang
2018-09-14 14:40 ` Gao Xiang
2018-09-14 14:40 ` [PATCH 7/8] staging: erofs: add trace points for reading zipped data Gao Xiang
2018-09-14 14:40 ` Gao Xiang
2018-09-14 14:40 ` [PATCH 8/8] staging: erofs: replace BUG_ON with DBG_BUGON in data.c Gao Xiang
2018-09-14 14:40 ` Gao Xiang
2018-09-18 11:19 ` [PATCH 0/8] staging: erofs: error handing and more tracepoints Greg Kroah-Hartman
2018-09-18 11:19 ` Greg Kroah-Hartman
2018-09-18 12:02 ` Gao Xiang
2018-09-18 12:02 ` Gao Xiang
2018-09-18 12:14 ` Greg Kroah-Hartman
2018-09-18 12:14 ` Greg Kroah-Hartman
2018-09-18 12:31 ` Gao Xiang
2018-09-18 12:31 ` Gao Xiang
2018-09-18 13:03 ` Dan Carpenter
2018-09-18 13:03 ` Dan Carpenter
2018-09-18 13:09 ` Greg Kroah-Hartman [this message]
2018-09-18 13:09 ` Greg Kroah-Hartman
2018-09-18 13:20 ` Gao Xiang
2018-09-18 13:20 ` Gao Xiang
2018-09-18 13:44 ` [PATCH] staging: erofs: initialize `pblk' with 0 first in `z_erofs_map_blocks_iter' Gao Xiang
2018-09-18 13:44 ` Gao Xiang
2018-09-18 13:57 ` Greg Kroah-Hartman
2018-09-18 13:57 ` Greg Kroah-Hartman
2018-09-18 14:06 ` Gao Xiang
2018-09-18 14:06 ` Gao Xiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180918130911.GA16187@kroah.com \
--to=gregkh@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.