All of lore.kernel.org
 help / color / mirror / Atom feed
From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH RESEND 3/6] arm64: add sysfs vulnerability show for spectre v1
Date: Tue, 18 Sep 2018 18:15:51 +0100	[thread overview]
Message-ID: <20180918171550.GN16498@arm.com> (raw)
In-Reply-To: <20180918095226.GJ3795@rric.localdomain>

On Tue, Sep 18, 2018 at 11:52:27AM +0200, Robert Richter wrote:
> On 18.09.18 09:38:05, Will Deacon wrote:
> > On Mon, Sep 17, 2018 at 07:22:07PM +0200, Robert Richter wrote:
> > > On 27.08.18 16:33:07, Mian Yousaf Kaukab wrote:
> > > > Hard-coded since patches are merged and there are no configuration
> > > > options.
> > >
> > > Could you add a list of upstream patches to the description that are
> > > required to solve this? This would be a strict definition for the
> > > mitigation being enabled and makes it easier to check if backports are
> > > affected or not. A build-time check would be ideal (e.g. checking for
> > > certain macros).
> > 
> > Hmm, I don't grok what you're proposing here. Why do we need a build-time
> > check (and to check what?)
> 
> My concern is, that for kernel backports (esp. distro kernels) there
> could be various interpretations of what "Mitigation: __user pointer
> sanitization" means. So a list of upstream patches that need to be
> backported in addition to this patch as a requirement would be good to
> agree on. That should be documented in the patch description.
> 
> If these mitigations are available in a kernel backport, that could be
> even checked at build time. E.g. we could have a sanity check if the
> macro array_index_nospec() is defined. But such a check does not
> replace a code review of a kernel backport.
> 
> I hope that makes sense?

Ok, I see what you mean now, thanks. However, it doesn't sound much
different than backporting a patch with dependencies, so I'd rather
avoid adding additional code to treat this case specially.

Will

WARNING: multiple messages have this Message-ID (diff)
From: Will Deacon <will.deacon@arm.com>
To: Robert Richter <robert.richter@cavium.com>
Cc: Mian Yousaf Kaukab <ykaukab@suse.de>,
	marc.zyngier@arm.com, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, cwu@amperecomputing.com
Subject: Re: [PATCH RESEND 3/6] arm64: add sysfs vulnerability show for spectre v1
Date: Tue, 18 Sep 2018 18:15:51 +0100	[thread overview]
Message-ID: <20180918171550.GN16498@arm.com> (raw)
In-Reply-To: <20180918095226.GJ3795@rric.localdomain>

On Tue, Sep 18, 2018 at 11:52:27AM +0200, Robert Richter wrote:
> On 18.09.18 09:38:05, Will Deacon wrote:
> > On Mon, Sep 17, 2018 at 07:22:07PM +0200, Robert Richter wrote:
> > > On 27.08.18 16:33:07, Mian Yousaf Kaukab wrote:
> > > > Hard-coded since patches are merged and there are no configuration
> > > > options.
> > >
> > > Could you add a list of upstream patches to the description that are
> > > required to solve this? This would be a strict definition for the
> > > mitigation being enabled and makes it easier to check if backports are
> > > affected or not. A build-time check would be ideal (e.g. checking for
> > > certain macros).
> > 
> > Hmm, I don't grok what you're proposing here. Why do we need a build-time
> > check (and to check what?)
> 
> My concern is, that for kernel backports (esp. distro kernels) there
> could be various interpretations of what "Mitigation: __user pointer
> sanitization" means. So a list of upstream patches that need to be
> backported in addition to this patch as a requirement would be good to
> agree on. That should be documented in the patch description.
> 
> If these mitigations are available in a kernel backport, that could be
> even checked at build time. E.g. we could have a sanity check if the
> macro array_index_nospec() is defined. But such a check does not
> replace a code review of a kernel backport.
> 
> I hope that makes sense?

Ok, I see what you mean now, thanks. However, it doesn't sound much
different than backporting a patch with dependencies, so I'd rather
avoid adding additional code to treat this case specially.

Will

  reply	other threads:[~2018-09-18 17:15 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-27 14:33 [PATCH RESEND 0/6] arm64: add support for generic cpu vulnerabilities Mian Yousaf Kaukab
2018-08-27 14:33 ` Mian Yousaf Kaukab
2018-08-27 14:33 ` [PATCH RESEND 1/6] arm64: kpti: move check for non-vulnerable CPUs to a function Mian Yousaf Kaukab
2018-08-27 14:33   ` Mian Yousaf Kaukab
2018-08-27 14:33 ` [PATCH RESEND 2/6] arm64: add sysfs vulnerability show for meltdown Mian Yousaf Kaukab
2018-08-27 14:33   ` Mian Yousaf Kaukab
2018-09-17 13:30   ` Will Deacon
2018-09-17 13:30     ` Will Deacon
2018-08-27 14:33 ` [PATCH RESEND 3/6] arm64: add sysfs vulnerability show for spectre v1 Mian Yousaf Kaukab
2018-08-27 14:33   ` Mian Yousaf Kaukab
2018-09-17 17:22   ` Robert Richter
2018-09-17 17:22     ` Robert Richter
2018-09-18  8:38     ` Will Deacon
2018-09-18  8:38       ` Will Deacon
2018-09-18  9:52       ` Robert Richter
2018-09-18  9:52         ` Robert Richter
2018-09-18 17:15         ` Will Deacon [this message]
2018-09-18 17:15           ` Will Deacon
2018-09-19  6:57           ` Robert Richter
2018-09-19  6:57             ` Robert Richter
2018-08-27 14:33 ` [PATCH RESEND 4/6] arm64: add sysfs vulnerability show for spectre v2 Mian Yousaf Kaukab
2018-08-27 14:33   ` Mian Yousaf Kaukab
2018-09-17 13:30   ` Will Deacon
2018-09-17 13:30     ` Will Deacon
2018-08-27 14:33 ` [PATCH RESEND 5/6] arm64: add sysfs vulnerability show for speculative store bypass Mian Yousaf Kaukab
2018-08-27 14:33   ` Mian Yousaf Kaukab
2018-09-17 13:30   ` Will Deacon
2018-09-17 13:30     ` Will Deacon
2018-08-27 14:33 ` [PATCH RESEND 6/6] arm64: enable generic CPU vulnerabilites support Mian Yousaf Kaukab
2018-08-27 14:33   ` Mian Yousaf Kaukab
2018-09-05  9:25 ` [PATCH RESEND 0/6] arm64: add support for generic cpu vulnerabilities Mian Yousaf Kaukab
2018-09-05  9:25   ` Mian Yousaf Kaukab
2018-09-17 13:35   ` Will Deacon
2018-09-17 13:35     ` Will Deacon
2018-09-24 10:06     ` Mian Yousaf Kaukab
2018-09-24 10:06       ` Mian Yousaf Kaukab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180918171550.GN16498@arm.com \
    --to=will.deacon@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.