* [U-Boot] [PATCH] ARM: mach-omap2: Don't initialize I2C if DM_I2C is enabled @ 2018-08-21 1:34 Adam Ford 2018-08-23 10:45 ` Simon Glass 2018-09-18 21:25 ` [U-Boot] " Tom Rini 0 siblings, 2 replies; 3+ messages in thread From: Adam Ford @ 2018-08-21 1:34 UTC (permalink / raw) To: u-boot boot-common.c checks to see if I2C is enabled in SPL, but it doens't check for DM_I2C before initializing it. This will now only initialize the I2C is the DM_I2C is not enabled to avoid initializing it more than once. Signed-off-by: Adam Ford <aford173@gmail.com> diff --git a/arch/arm/mach-omap2/boot-common.c b/arch/arm/mach-omap2/boot-common.c index d4a1e2e42c..176d4f67cb 100644 --- a/arch/arm/mach-omap2/boot-common.c +++ b/arch/arm/mach-omap2/boot-common.c @@ -202,7 +202,7 @@ void spl_board_init(void) #if defined(CONFIG_SPL_NAND_SUPPORT) || defined(CONFIG_SPL_ONENAND_SUPPORT) gpmc_init(); #endif -#ifdef CONFIG_SPL_I2C_SUPPORT +#if defined(CONFIG_SPL_I2C_SUPPORT) && !defined(CONFIG_DM_I2C) i2c_init(CONFIG_SYS_OMAP24_I2C_SPEED, CONFIG_SYS_OMAP24_I2C_SLAVE); #endif #if defined(CONFIG_AM33XX) && defined(CONFIG_SPL_MUSB_NEW_SUPPORT) -- 2.17.1 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH] ARM: mach-omap2: Don't initialize I2C if DM_I2C is enabled 2018-08-21 1:34 [U-Boot] [PATCH] ARM: mach-omap2: Don't initialize I2C if DM_I2C is enabled Adam Ford @ 2018-08-23 10:45 ` Simon Glass 2018-09-18 21:25 ` [U-Boot] " Tom Rini 1 sibling, 0 replies; 3+ messages in thread From: Simon Glass @ 2018-08-23 10:45 UTC (permalink / raw) To: u-boot On 20 August 2018 at 19:34, Adam Ford <aford173@gmail.com> wrote: > boot-common.c checks to see if I2C is enabled in SPL, but > it doens't check for DM_I2C before initializing it. This > will now only initialize the I2C is the DM_I2C is not enabled > to avoid initializing it more than once. > > Signed-off-by: Adam Ford <aford173@gmail.com> Reviewed-by: Simon Glass <sjg@chromium.org> ^ permalink raw reply [flat|nested] 3+ messages in thread
* [U-Boot] ARM: mach-omap2: Don't initialize I2C if DM_I2C is enabled 2018-08-21 1:34 [U-Boot] [PATCH] ARM: mach-omap2: Don't initialize I2C if DM_I2C is enabled Adam Ford 2018-08-23 10:45 ` Simon Glass @ 2018-09-18 21:25 ` Tom Rini 1 sibling, 0 replies; 3+ messages in thread From: Tom Rini @ 2018-09-18 21:25 UTC (permalink / raw) To: u-boot On Mon, Aug 20, 2018 at 08:34:00PM -0500, Adam Ford wrote: > boot-common.c checks to see if I2C is enabled in SPL, but > it doens't check for DM_I2C before initializing it. This > will now only initialize the I2C is the DM_I2C is not enabled > to avoid initializing it more than once. > > Signed-off-by: Adam Ford <aford173@gmail.com> > Reviewed-by: Simon Glass <sjg@chromium.org> > > diff --git a/arch/arm/mach-omap2/boot-common.c b/arch/arm/mach-omap2/boot-common.c > index d4a1e2e42c..176d4f67cb 100644 Applied to u-boot/master, thanks! -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: not available URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180918/44deb91a/attachment.sig> ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-09-18 21:25 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2018-08-21 1:34 [U-Boot] [PATCH] ARM: mach-omap2: Don't initialize I2C if DM_I2C is enabled Adam Ford 2018-08-23 10:45 ` Simon Glass 2018-09-18 21:25 ` [U-Boot] " Tom Rini
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.