All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] x86/paravirt: fix some warning messages
@ 2018-09-19 10:35 ` Dan Carpenter
  0 siblings, 0 replies; 5+ messages in thread
From: Dan Carpenter @ 2018-09-19 10:35 UTC (permalink / raw)
  To: Juergen Gross, Peter Zijlstra
  Cc: x86, kernel-janitors, virtualization, Ingo Molnar, H. Peter Anvin,
	Alok Kataria, Thomas Gleixner

The first argument to WARN_ONCE() is a condition.

Fixes: 5800dc5c19f3 ("x86/paravirt: Fix spectre-v2 mitigations for paravirt guests")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

diff --git a/arch/x86/kernel/paravirt.c b/arch/x86/kernel/paravirt.c
index bbf006fe78d7..e4d4df37922a 100644
--- a/arch/x86/kernel/paravirt.c
+++ b/arch/x86/kernel/paravirt.c
@@ -89,7 +89,7 @@ static unsigned paravirt_patch_call(void *insnbuf, const void *target,
 
 	if (len < 5) {
 #ifdef CONFIG_RETPOLINE
-		WARN_ONCE("Failing to patch indirect CALL in %ps\n", (void *)addr);
+		WARN_ONCE(1, "Failing to patch indirect CALL in %ps\n", (void *)addr);
 #endif
 		return len;	/* call too long for patch site */
 	}
@@ -110,7 +110,7 @@ static unsigned paravirt_patch_jmp(void *insnbuf, const void *target,
 
 	if (len < 5) {
 #ifdef CONFIG_RETPOLINE
-		WARN_ONCE("Failing to patch indirect JMP in %ps\n", (void *)addr);
+		WARN_ONCE(1, "Failing to patch indirect JMP in %ps\n", (void *)addr);
 #endif
 		return len;	/* call too long for patch site */
 	}

^ permalink raw reply related	[flat|nested] 5+ messages in thread
* [PATCH] x86/paravirt: fix some warning messages
@ 2018-09-19 10:35 ` Dan Carpenter
  0 siblings, 0 replies; 5+ messages in thread
From: Dan Carpenter @ 2018-09-19 10:35 UTC (permalink / raw)
  To: Juergen Gross, Peter Zijlstra
  Cc: x86, kernel-janitors, virtualization, Ingo Molnar, H. Peter Anvin,
	Alok Kataria, Thomas Gleixner

The first argument to WARN_ONCE() is a condition.

Fixes: 5800dc5c19f3 ("x86/paravirt: Fix spectre-v2 mitigations for paravirt guests")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

diff --git a/arch/x86/kernel/paravirt.c b/arch/x86/kernel/paravirt.c
index bbf006fe78d7..e4d4df37922a 100644
--- a/arch/x86/kernel/paravirt.c
+++ b/arch/x86/kernel/paravirt.c
@@ -89,7 +89,7 @@ static unsigned paravirt_patch_call(void *insnbuf, const void *target,
 
 	if (len < 5) {
 #ifdef CONFIG_RETPOLINE
-		WARN_ONCE("Failing to patch indirect CALL in %ps\n", (void *)addr);
+		WARN_ONCE(1, "Failing to patch indirect CALL in %ps\n", (void *)addr);
 #endif
 		return len;	/* call too long for patch site */
 	}
@@ -110,7 +110,7 @@ static unsigned paravirt_patch_jmp(void *insnbuf, const void *target,
 
 	if (len < 5) {
 #ifdef CONFIG_RETPOLINE
-		WARN_ONCE("Failing to patch indirect JMP in %ps\n", (void *)addr);
+		WARN_ONCE(1, "Failing to patch indirect JMP in %ps\n", (void *)addr);
 #endif
 		return len;	/* call too long for patch site */
 	}

^ permalink raw reply related	[flat|nested] 5+ messages in thread
* Re: [PATCH] x86/paravirt: fix some warning messages
  2018-09-19 10:35 ` Dan Carpenter
@ 2018-09-19 10:47   ` Juergen Gross
  -1 siblings, 0 replies; 5+ messages in thread
From: Juergen Gross @ 2018-09-19 10:47 UTC (permalink / raw)
  To: Dan Carpenter, Peter Zijlstra
  Cc: x86, kernel-janitors, virtualization, Ingo Molnar, H. Peter Anvin,
	Alok Kataria, Thomas Gleixner

On 19/09/18 12:35, Dan Carpenter wrote:
> The first argument to WARN_ONCE() is a condition.
> 
> Fixes: 5800dc5c19f3 ("x86/paravirt: Fix spectre-v2 mitigations for paravirt guests")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Reviewed-by: Juergen Gross <jgross@suse.com>


Juergen

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH] x86/paravirt: fix some warning messages
@ 2018-09-19 10:47   ` Juergen Gross
  0 siblings, 0 replies; 5+ messages in thread
From: Juergen Gross @ 2018-09-19 10:47 UTC (permalink / raw)
  To: Dan Carpenter, Peter Zijlstra
  Cc: x86, kernel-janitors, virtualization, Ingo Molnar, H. Peter Anvin,
	Alok Kataria, Thomas Gleixner

On 19/09/18 12:35, Dan Carpenter wrote:
> The first argument to WARN_ONCE() is a condition.
> 
> Fixes: 5800dc5c19f3 ("x86/paravirt: Fix spectre-v2 mitigations for paravirt guests")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Reviewed-by: Juergen Gross <jgross@suse.com>


Juergen

^ permalink raw reply	[flat|nested] 5+ messages in thread
* [tip:x86/urgent] x86/paravirt: Fix some warning messages
  2018-09-19 10:35 ` Dan Carpenter
  (?)
  (?)
@ 2018-09-19 11:27 ` tip-bot for Dan Carpenter
  -1 siblings, 0 replies; 5+ messages in thread
From: tip-bot for Dan Carpenter @ 2018-09-19 11:27 UTC (permalink / raw)
  To: linux-tip-commits
  Cc: hpa, jgross, dan.carpenter, tglx, linux-kernel, mingo, akataria,
	peterz

Commit-ID:  571d0563c8881595f4ab027aef9ed1c55e3e7b7c
Gitweb:     https://git.kernel.org/tip/571d0563c8881595f4ab027aef9ed1c55e3e7b7c
Author:     Dan Carpenter <dan.carpenter@oracle.com>
AuthorDate: Wed, 19 Sep 2018 13:35:53 +0300
Committer:  Thomas Gleixner <tglx@linutronix.de>
CommitDate: Wed, 19 Sep 2018 13:22:04 +0200

x86/paravirt: Fix some warning messages

The first argument to WARN_ONCE() is a condition.

Fixes: 5800dc5c19f3 ("x86/paravirt: Fix spectre-v2 mitigations for paravirt guests")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Juergen Gross <jgross@suse.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Alok Kataria <akataria@vmware.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: virtualization@lists.linux-foundation.org
Cc: kernel-janitors@vger.kernel.org
Link: https://lkml.kernel.org/r/20180919103553.GD9238@mwanda


---
 arch/x86/kernel/paravirt.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/x86/kernel/paravirt.c b/arch/x86/kernel/paravirt.c
index afdb303285f8..8dc69d82567e 100644
--- a/arch/x86/kernel/paravirt.c
+++ b/arch/x86/kernel/paravirt.c
@@ -91,7 +91,7 @@ unsigned paravirt_patch_call(void *insnbuf,
 
 	if (len < 5) {
 #ifdef CONFIG_RETPOLINE
-		WARN_ONCE("Failing to patch indirect CALL in %ps\n", (void *)addr);
+		WARN_ONCE(1, "Failing to patch indirect CALL in %ps\n", (void *)addr);
 #endif
 		return len;	/* call too long for patch site */
 	}
@@ -111,7 +111,7 @@ unsigned paravirt_patch_jmp(void *insnbuf, const void *target,
 
 	if (len < 5) {
 #ifdef CONFIG_RETPOLINE
-		WARN_ONCE("Failing to patch indirect JMP in %ps\n", (void *)addr);
+		WARN_ONCE(1, "Failing to patch indirect JMP in %ps\n", (void *)addr);
 #endif
 		return len;	/* call too long for patch site */
 	}

^ permalink raw reply related	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-09-19 11:28 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-09-19 10:35 [PATCH] x86/paravirt: fix some warning messages Dan Carpenter
2018-09-19 10:35 ` Dan Carpenter
2018-09-19 10:47 ` Juergen Gross
2018-09-19 10:47   ` Juergen Gross
2018-09-19 11:27 ` [tip:x86/urgent] x86/paravirt: Fix " tip-bot for Dan Carpenter

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.