* [PATCH] mt76x0: run vco calibration for each channel configuration
@ 2018-09-07 21:13 ` Lorenzo Bianconi
0 siblings, 0 replies; 14+ messages in thread
From: Lorenzo Bianconi @ 2018-09-07 21:13 UTC (permalink / raw)
To: nbd-Vt+b4OUoWG0
Cc: linux-wireless-u79uwXL29TY76Z2rM5mHXA,
linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
sgruszka-H+wXaHxf7aLQT0dZR+AlfA
According to vendor sdk, vco calibration has to be executed
for each channel configuration whereas mcu calibration has to be
performed during channel scanning. This patch fixes the mt76x0
monitor mode issue since in that configuration vco calibration
was never executed
Fixes: 10de7a8b4ab9 ("mt76x0: phy files")
Tested-by: Sid Hayn <sidhayn-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
---
drivers/net/wireless/mediatek/mt76/mt76x0/phy.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/mediatek/mt76/mt76x0/phy.c b/drivers/net/wireless/mediatek/mt76/mt76x0/phy.c
index 5da7bfbe907f..14e8c575f6c3 100644
--- a/drivers/net/wireless/mediatek/mt76/mt76x0/phy.c
+++ b/drivers/net/wireless/mediatek/mt76/mt76x0/phy.c
@@ -757,10 +757,10 @@ __mt76x0_phy_set_channel(struct mt76x0_dev *dev,
/* Vendor driver don't do it */
/* mt76x0_phy_set_tx_power(dev, channel, rf_bw_band); */
+ mt76x0_vco_cal(dev, channel);
if (scan)
- mt76x0_vco_cal(dev, channel);
+ mt76x0_mcu_calibrate(dev, MCU_CAL_RXDCOC, 1);
- mt76x0_mcu_calibrate(dev, MCU_CAL_RXDCOC, 1);
mt76x0_phy_set_chan_pwr(dev, channel);
dev->mt76.chandef = *chandef;
--
2.18.0
^ permalink raw reply related [flat|nested] 14+ messages in thread* [PATCH] mt76x0: run vco calibration for each channel configuration
@ 2018-09-07 21:13 ` Lorenzo Bianconi
0 siblings, 0 replies; 14+ messages in thread
From: Lorenzo Bianconi @ 2018-09-07 21:13 UTC (permalink / raw)
To: nbd; +Cc: sgruszka, linux-wireless, linux-mediatek
According to vendor sdk, vco calibration has to be executed
for each channel configuration whereas mcu calibration has to be
performed during channel scanning. This patch fixes the mt76x0
monitor mode issue since in that configuration vco calibration
was never executed
Fixes: 10de7a8b4ab9 ("mt76x0: phy files")
Tested-by: Sid Hayn <sidhayn@gmail.com>
Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
---
drivers/net/wireless/mediatek/mt76/mt76x0/phy.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/mediatek/mt76/mt76x0/phy.c b/drivers/net/wireless/mediatek/mt76/mt76x0/phy.c
index 5da7bfbe907f..14e8c575f6c3 100644
--- a/drivers/net/wireless/mediatek/mt76/mt76x0/phy.c
+++ b/drivers/net/wireless/mediatek/mt76/mt76x0/phy.c
@@ -757,10 +757,10 @@ __mt76x0_phy_set_channel(struct mt76x0_dev *dev,
/* Vendor driver don't do it */
/* mt76x0_phy_set_tx_power(dev, channel, rf_bw_band); */
+ mt76x0_vco_cal(dev, channel);
if (scan)
- mt76x0_vco_cal(dev, channel);
+ mt76x0_mcu_calibrate(dev, MCU_CAL_RXDCOC, 1);
- mt76x0_mcu_calibrate(dev, MCU_CAL_RXDCOC, 1);
mt76x0_phy_set_chan_pwr(dev, channel);
dev->mt76.chandef = *chandef;
--
2.18.0
^ permalink raw reply related [flat|nested] 14+ messages in thread[parent not found: <20180907211312.17918-1-lorenzo.bianconi-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>]
* Re: [PATCH] mt76x0: run vco calibration for each channel configuration
2018-09-07 21:13 ` Lorenzo Bianconi
@ 2018-09-18 11:43 ` Stanislaw Gruszka
-1 siblings, 0 replies; 14+ messages in thread
From: Stanislaw Gruszka @ 2018-09-18 11:43 UTC (permalink / raw)
To: Lorenzo Bianconi
Cc: nbd-Vt+b4OUoWG0, linux-wireless-u79uwXL29TY76Z2rM5mHXA,
linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r
On Fri, Sep 07, 2018 at 11:13:12PM +0200, Lorenzo Bianconi wrote:
> According to vendor sdk, vco calibration has to be executed
> for each channel configuration whereas mcu calibration has to be
> performed during channel scanning. This patch fixes the mt76x0
> monitor mode issue since in that configuration vco calibration
> was never executed
>
> Fixes: 10de7a8b4ab9 ("mt76x0: phy files")
> Tested-by: Sid Hayn <sidhayn-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Acked-by: Stanislaw Gruszka <sgruszka-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [PATCH] mt76x0: run vco calibration for each channel configuration
@ 2018-09-18 11:43 ` Stanislaw Gruszka
0 siblings, 0 replies; 14+ messages in thread
From: Stanislaw Gruszka @ 2018-09-18 11:43 UTC (permalink / raw)
To: Lorenzo Bianconi; +Cc: nbd, linux-wireless, linux-mediatek
On Fri, Sep 07, 2018 at 11:13:12PM +0200, Lorenzo Bianconi wrote:
> According to vendor sdk, vco calibration has to be executed
> for each channel configuration whereas mcu calibration has to be
> performed during channel scanning. This patch fixes the mt76x0
> monitor mode issue since in that configuration vco calibration
> was never executed
>
> Fixes: 10de7a8b4ab9 ("mt76x0: phy files")
> Tested-by: Sid Hayn <sidhayn@gmail.com>
> Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
Acked-by: Stanislaw Gruszka <sgruszka@redhat.com>
^ permalink raw reply [flat|nested] 14+ messages in thread[parent not found: <20180918114356.GB15285-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>]
* Re: [PATCH] mt76x0: run vco calibration for each channel configuration
2018-09-18 11:43 ` Stanislaw Gruszka
@ 2018-09-18 12:02 ` Stanislaw Gruszka
-1 siblings, 0 replies; 14+ messages in thread
From: Stanislaw Gruszka @ 2018-09-18 12:02 UTC (permalink / raw)
To: Lorenzo Bianconi, Kalle Valo
Cc: nbd-Vt+b4OUoWG0, linux-wireless-u79uwXL29TY76Z2rM5mHXA,
linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r
On Tue, Sep 18, 2018 at 01:43:56PM +0200, Stanislaw Gruszka wrote:
> On Fri, Sep 07, 2018 at 11:13:12PM +0200, Lorenzo Bianconi wrote:
> > According to vendor sdk, vco calibration has to be executed
> > for each channel configuration whereas mcu calibration has to be
> > performed during channel scanning. This patch fixes the mt76x0
> > monitor mode issue since in that configuration vco calibration
> > was never executed
> >
> > Fixes: 10de7a8b4ab9 ("mt76x0: phy files")
> > Tested-by: Sid Hayn <sidhayn-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> > Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
>
> Acked-by: Stanislaw Gruszka <sgruszka-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
For the record this is 4.19 material.
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [PATCH] mt76x0: run vco calibration for each channel configuration
@ 2018-09-18 12:02 ` Stanislaw Gruszka
0 siblings, 0 replies; 14+ messages in thread
From: Stanislaw Gruszka @ 2018-09-18 12:02 UTC (permalink / raw)
To: Lorenzo Bianconi, Kalle Valo; +Cc: nbd, linux-wireless, linux-mediatek
On Tue, Sep 18, 2018 at 01:43:56PM +0200, Stanislaw Gruszka wrote:
> On Fri, Sep 07, 2018 at 11:13:12PM +0200, Lorenzo Bianconi wrote:
> > According to vendor sdk, vco calibration has to be executed
> > for each channel configuration whereas mcu calibration has to be
> > performed during channel scanning. This patch fixes the mt76x0
> > monitor mode issue since in that configuration vco calibration
> > was never executed
> >
> > Fixes: 10de7a8b4ab9 ("mt76x0: phy files")
> > Tested-by: Sid Hayn <sidhayn@gmail.com>
> > Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
>
> Acked-by: Stanislaw Gruszka <sgruszka@redhat.com>
For the record this is 4.19 material.
^ permalink raw reply [flat|nested] 14+ messages in thread[parent not found: <20180918120234.GD15285-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>]
* Re: [PATCH] mt76x0: run vco calibration for each channel configuration
2018-09-18 12:02 ` Stanislaw Gruszka
@ 2018-09-18 12:40 ` Kalle Valo
-1 siblings, 0 replies; 14+ messages in thread
From: Kalle Valo @ 2018-09-18 12:40 UTC (permalink / raw)
To: Stanislaw Gruszka
Cc: Lorenzo Bianconi, nbd-Vt+b4OUoWG0,
linux-wireless-u79uwXL29TY76Z2rM5mHXA,
linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r
Stanislaw Gruszka <sgruszka-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> writes:
> On Tue, Sep 18, 2018 at 01:43:56PM +0200, Stanislaw Gruszka wrote:
>> On Fri, Sep 07, 2018 at 11:13:12PM +0200, Lorenzo Bianconi wrote:
>> > According to vendor sdk, vco calibration has to be executed
>> > for each channel configuration whereas mcu calibration has to be
>> > performed during channel scanning. This patch fixes the mt76x0
>> > monitor mode issue since in that configuration vco calibration
>> > was never executed
>> >
>> > Fixes: 10de7a8b4ab9 ("mt76x0: phy files")
>> > Tested-by: Sid Hayn <sidhayn-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>> > Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
>>
>> Acked-by: Stanislaw Gruszka <sgruszka-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
>
> For the record this is 4.19 material.
I really want to minimise conflicts and because of so many mt76 patches
conflicts are likely to happen, so I'm keeping the bar high for mt76
patches going 4.19. Is this a regression from 4.18? If not, I think this
should go to -next and cc stable. And besides, monitor mode isn't that
critical anyway.
--
Kalle Valo
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [PATCH] mt76x0: run vco calibration for each channel configuration
@ 2018-09-18 12:40 ` Kalle Valo
0 siblings, 0 replies; 14+ messages in thread
From: Kalle Valo @ 2018-09-18 12:40 UTC (permalink / raw)
To: Stanislaw Gruszka; +Cc: Lorenzo Bianconi, nbd, linux-wireless, linux-mediatek
Stanislaw Gruszka <sgruszka@redhat.com> writes:
> On Tue, Sep 18, 2018 at 01:43:56PM +0200, Stanislaw Gruszka wrote:
>> On Fri, Sep 07, 2018 at 11:13:12PM +0200, Lorenzo Bianconi wrote:
>> > According to vendor sdk, vco calibration has to be executed
>> > for each channel configuration whereas mcu calibration has to be
>> > performed during channel scanning. This patch fixes the mt76x0
>> > monitor mode issue since in that configuration vco calibration
>> > was never executed
>> >
>> > Fixes: 10de7a8b4ab9 ("mt76x0: phy files")
>> > Tested-by: Sid Hayn <sidhayn@gmail.com>
>> > Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
>>
>> Acked-by: Stanislaw Gruszka <sgruszka@redhat.com>
>
> For the record this is 4.19 material.
I really want to minimise conflicts and because of so many mt76 patches
conflicts are likely to happen, so I'm keeping the bar high for mt76
patches going 4.19. Is this a regression from 4.18? If not, I think this
should go to -next and cc stable. And besides, monitor mode isn't that
critical anyway.
--
Kalle Valo
^ permalink raw reply [flat|nested] 14+ messages in thread[parent not found: <871s9r2d3g.fsf-HodKDYzPHsUD5k0oWYwrnHL1okKdlPRT@public.gmane.org>]
* Re: [PATCH] mt76x0: run vco calibration for each channel configuration
2018-09-18 12:40 ` Kalle Valo
@ 2018-09-18 14:26 ` Sid Hayn
-1 siblings, 0 replies; 14+ messages in thread
From: Sid Hayn @ 2018-09-18 14:26 UTC (permalink / raw)
To: Kalle Valo
Cc: sgruszka-H+wXaHxf7aLQT0dZR+AlfA, Lorenzo Bianconi, Felix Fietkau,
linux-wireless, linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r
mt76x0 isn't in 4.18 at all, it's being added in 4.19 isn't it? I'm
not sure you can call it a regression, but adding a new driver with a
known bug that breaks an entire use case (monitor mode) seems silly
when a small and tested fix is available. Pretty please.
Thanks,
Zero
On Tue, Sep 18, 2018 at 8:43 AM Kalle Valo <kvalo-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org> wrote:
>
> Stanislaw Gruszka <sgruszka-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> writes:
>
> > On Tue, Sep 18, 2018 at 01:43:56PM +0200, Stanislaw Gruszka wrote:
> >> On Fri, Sep 07, 2018 at 11:13:12PM +0200, Lorenzo Bianconi wrote:
> >> > According to vendor sdk, vco calibration has to be executed
> >> > for each channel configuration whereas mcu calibration has to be
> >> > performed during channel scanning. This patch fixes the mt76x0
> >> > monitor mode issue since in that configuration vco calibration
> >> > was never executed
> >> >
> >> > Fixes: 10de7a8b4ab9 ("mt76x0: phy files")
> >> > Tested-by: Sid Hayn <sidhayn-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> >> > Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> >>
> >> Acked-by: Stanislaw Gruszka <sgruszka-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> >
> > For the record this is 4.19 material.
>
> I really want to minimise conflicts and because of so many mt76 patches
> conflicts are likely to happen, so I'm keeping the bar high for mt76
> patches going 4.19. Is this a regression from 4.18? If not, I think this
> should go to -next and cc stable. And besides, monitor mode isn't that
> critical anyway.
>
> --
> Kalle Valo
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [PATCH] mt76x0: run vco calibration for each channel configuration
@ 2018-09-18 14:26 ` Sid Hayn
0 siblings, 0 replies; 14+ messages in thread
From: Sid Hayn @ 2018-09-18 14:26 UTC (permalink / raw)
To: Kalle Valo
Cc: sgruszka, Lorenzo Bianconi, Felix Fietkau, linux-wireless,
linux-mediatek
mt76x0 isn't in 4.18 at all, it's being added in 4.19 isn't it? I'm
not sure you can call it a regression, but adding a new driver with a
known bug that breaks an entire use case (monitor mode) seems silly
when a small and tested fix is available. Pretty please.
Thanks,
Zero
On Tue, Sep 18, 2018 at 8:43 AM Kalle Valo <kvalo@codeaurora.org> wrote:
>
> Stanislaw Gruszka <sgruszka@redhat.com> writes:
>
> > On Tue, Sep 18, 2018 at 01:43:56PM +0200, Stanislaw Gruszka wrote:
> >> On Fri, Sep 07, 2018 at 11:13:12PM +0200, Lorenzo Bianconi wrote:
> >> > According to vendor sdk, vco calibration has to be executed
> >> > for each channel configuration whereas mcu calibration has to be
> >> > performed during channel scanning. This patch fixes the mt76x0
> >> > monitor mode issue since in that configuration vco calibration
> >> > was never executed
> >> >
> >> > Fixes: 10de7a8b4ab9 ("mt76x0: phy files")
> >> > Tested-by: Sid Hayn <sidhayn@gmail.com>
> >> > Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
> >>
> >> Acked-by: Stanislaw Gruszka <sgruszka@redhat.com>
> >
> > For the record this is 4.19 material.
>
> I really want to minimise conflicts and because of so many mt76 patches
> conflicts are likely to happen, so I'm keeping the bar high for mt76
> patches going 4.19. Is this a regression from 4.18? If not, I think this
> should go to -next and cc stable. And besides, monitor mode isn't that
> critical anyway.
>
> --
> Kalle Valo
^ permalink raw reply [flat|nested] 14+ messages in thread[parent not found: <CAM0KTbAPHPK04SntA9UL0rGaaNjTy=E2hRoO7xiRkbMcq9b7Sw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>]
* Re: [PATCH] mt76x0: run vco calibration for each channel configuration
2018-09-18 14:26 ` Sid Hayn
@ 2018-09-19 11:24 ` Stanislaw Gruszka
-1 siblings, 0 replies; 14+ messages in thread
From: Stanislaw Gruszka @ 2018-09-19 11:24 UTC (permalink / raw)
To: Sid Hayn
Cc: Kalle Valo, Lorenzo Bianconi, Felix Fietkau, linux-wireless,
linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r
On Tue, Sep 18, 2018 at 10:26:09AM -0400, Sid Hayn wrote:
> mt76x0 isn't in 4.18 at all, it's being added in 4.19 isn't it? I'm
> not sure you can call it a regression, but adding a new driver with a
> known bug that breaks an entire use case (monitor mode) seems silly
> when a small and tested fix is available. Pretty please.
Patch conflict with pending mt76 -next patches. Apply it and rebase
all other patches on top of it, is a lot of work. I agree with
Kalle that it will be better to apply this patch on top of -next
and CC stable. Problem should be fixed in 4.19.1 or 4.19.2 .
Regards
Stanislaw
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] mt76x0: run vco calibration for each channel configuration
@ 2018-09-19 11:24 ` Stanislaw Gruszka
0 siblings, 0 replies; 14+ messages in thread
From: Stanislaw Gruszka @ 2018-09-19 11:24 UTC (permalink / raw)
To: Sid Hayn
Cc: Kalle Valo, Lorenzo Bianconi, Felix Fietkau, linux-wireless,
linux-mediatek
On Tue, Sep 18, 2018 at 10:26:09AM -0400, Sid Hayn wrote:
> mt76x0 isn't in 4.18 at all, it's being added in 4.19 isn't it? I'm
> not sure you can call it a regression, but adding a new driver with a
> known bug that breaks an entire use case (monitor mode) seems silly
> when a small and tested fix is available. Pretty please.
Patch conflict with pending mt76 -next patches. Apply it and rebase
all other patches on top of it, is a lot of work. I agree with
Kalle that it will be better to apply this patch on top of -next
and CC stable. Problem should be fixed in 4.19.1 or 4.19.2 .
Regards
Stanislaw
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] mt76x0: run vco calibration for each channel configuration
2018-09-18 14:26 ` Sid Hayn
@ 2018-09-19 12:03 ` Kalle Valo
-1 siblings, 0 replies; 14+ messages in thread
From: Kalle Valo @ 2018-09-19 12:03 UTC (permalink / raw)
To: Sid Hayn
Cc: sgruszka-H+wXaHxf7aLQT0dZR+AlfA, Lorenzo Bianconi, Felix Fietkau,
linux-wireless, linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r
Sid Hayn <sidhayn-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> writes:
> mt76x0 isn't in 4.18 at all, it's being added in 4.19 isn't it? I'm
> not sure you can call it a regression, but adding a new driver with a
> known bug that breaks an entire use case (monitor mode) seems silly
> when a small and tested fix is available. Pretty please.
Unfortunately it's not that simple as you think. And do take into
account that the maintainers need to deal with a lot of patches and
email so keeping things simple is important.
And please do not top post:
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#do_not_top_post_and_edit_your_quotes
--
Kalle Valo
^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2018-09-19 17:41 UTC | newest]
Thread overview: 14+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-09-07 21:13 [PATCH] mt76x0: run vco calibration for each channel configuration Lorenzo Bianconi
2018-09-07 21:13 ` Lorenzo Bianconi
[not found] ` <20180907211312.17918-1-lorenzo.bianconi-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2018-09-18 11:43 ` Stanislaw Gruszka
2018-09-18 11:43 ` Stanislaw Gruszka
[not found] ` <20180918114356.GB15285-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2018-09-18 12:02 ` Stanislaw Gruszka
2018-09-18 12:02 ` Stanislaw Gruszka
[not found] ` <20180918120234.GD15285-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2018-09-18 12:40 ` Kalle Valo
2018-09-18 12:40 ` Kalle Valo
[not found] ` <871s9r2d3g.fsf-HodKDYzPHsUD5k0oWYwrnHL1okKdlPRT@public.gmane.org>
2018-09-18 14:26 ` Sid Hayn
2018-09-18 14:26 ` Sid Hayn
[not found] ` <CAM0KTbAPHPK04SntA9UL0rGaaNjTy=E2hRoO7xiRkbMcq9b7Sw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-09-19 11:24 ` Stanislaw Gruszka
2018-09-19 11:24 ` Stanislaw Gruszka
2018-09-19 12:03 ` Kalle Valo
2018-09-19 12:03 ` Kalle Valo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.