All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Roger Quadros <rogerq@ti.com>
Cc: Zeng Tao <prime.zeng@hisilicon.com>,
	stern@rowland.harvard.edu, mathias.nyman@linux.intel.com,
	drinkcat@chromium.org, felipe.balbi@linux.intel.com,
	drake@endlessm.com, ravisadineni@chromium.org, joe@perches.com,
	Jonathan Corbet <corbet@lwn.net>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@kernel.org>,
	"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
	Marc Zyngier <marc.zyngier@arm.com>,
	Kai-Heng Feng <kai.heng.feng@canonical.com>,
	Thymo van Beers <thymovanbeers@gmail.com>,
	Frederic Weisbecker <frederic@kernel.org>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	David Rientjes <rientjes@google.com>,
	Mike Looijmans <mike.looijmans@topic.nl>,
	linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-usb@vger.kernel.org
Subject: Re: [PATCH v3] usb: hub: try old enumeration scheme first for high speed devices
Date: Thu, 20 Sep 2018 12:37:42 +0200	[thread overview]
Message-ID: <20180920103742.GD14252@kroah.com> (raw)
In-Reply-To: <535e6c93-4369-c01e-953c-35e7041129e8@ti.com>

On Mon, Aug 20, 2018 at 09:55:49AM +0300, Roger Quadros wrote:
> On 20/08/18 13:04, Zeng Tao wrote:
> > The new scheme is required just to support legacy low and full-speed
> > devices. For high speed devices, it will slower the enumeration speed.
> > So in this patch we try the "old" enumeration scheme first for high speed
> > devices, and this is what Windows does since Windows 8.
> > 
> > Signed-off-by: Zeng Tao <prime.zeng@hisilicon.com>
> 
> You need to add Alan's Ack here. I don't think you need to resend though.
> 
> Reviewed-by: Roger Quadros <rogerq@ti.com>

Please resend, I need his ack here :)

thanks,

greg k-h

WARNING: multiple messages have this Message-ID (diff)
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Roger Quadros <rogerq@ti.com>
Cc: Zeng Tao <prime.zeng@hisilicon.com>,
	stern@rowland.harvard.edu, mathias.nyman@linux.intel.com,
	drinkcat@chromium.org, felipe.balbi@linux.intel.com,
	drake@endlessm.com, ravisadineni@chromium.org, joe@perches.com,
	Jonathan Corbet <corbet@lwn.net>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@kernel.org>,
	"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
	Marc Zyngier <marc.zyngier@arm.com>,
	Kai-Heng Feng <kai.heng.feng@canonical.com>,
	Thymo van Beers <thymovanbeers@gmail.com>,
	Frederic Weisbecker <frederic@kernel.org>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	David Rientjes <rientjes@google.com>,
	Mike Looijmans <mike.looijmans@topic.nl>,
	linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-usb@vger.kernel.org
Subject: [v3] usb: hub: try old enumeration scheme first for high speed devices
Date: Thu, 20 Sep 2018 12:37:42 +0200	[thread overview]
Message-ID: <20180920103742.GD14252@kroah.com> (raw)

On Mon, Aug 20, 2018 at 09:55:49AM +0300, Roger Quadros wrote:
> On 20/08/18 13:04, Zeng Tao wrote:
> > The new scheme is required just to support legacy low and full-speed
> > devices. For high speed devices, it will slower the enumeration speed.
> > So in this patch we try the "old" enumeration scheme first for high speed
> > devices, and this is what Windows does since Windows 8.
> > 
> > Signed-off-by: Zeng Tao <prime.zeng@hisilicon.com>
> 
> You need to add Alan's Ack here. I don't think you need to resend though.
> 
> Reviewed-by: Roger Quadros <rogerq@ti.com>

Please resend, I need his ack here :)

thanks,

greg k-h

  reply	other threads:[~2018-09-20 10:37 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-20 10:04 [PATCH v3] usb: hub: try old enumeration scheme first for high speed devices Zeng Tao
2018-08-20 10:04 ` [v3] " Zengtao (B)
2018-08-20  6:55 ` [PATCH v3] " Roger Quadros
2018-08-20  6:55   ` [v3] " Roger Quadros
2018-09-20 10:37   ` Greg KH [this message]
2018-09-20 10:37     ` Greg Kroah-Hartman
2018-09-28  3:24     ` [PATCH v3] " Zengtao (B)
2018-09-28  3:24       ` [v3] " Zengtao (B)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180920103742.GD14252@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=corbet@lwn.net \
    --cc=drake@endlessm.com \
    --cc=drinkcat@chromium.org \
    --cc=felipe.balbi@linux.intel.com \
    --cc=frederic@kernel.org \
    --cc=joe@perches.com \
    --cc=kai.heng.feng@canonical.com \
    --cc=konrad.wilk@oracle.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=marc.zyngier@arm.com \
    --cc=mathias.nyman@linux.intel.com \
    --cc=mike.looijmans@topic.nl \
    --cc=mingo@kernel.org \
    --cc=prime.zeng@hisilicon.com \
    --cc=rafael.j.wysocki@intel.com \
    --cc=ravisadineni@chromium.org \
    --cc=rientjes@google.com \
    --cc=rogerq@ti.com \
    --cc=stern@rowland.harvard.edu \
    --cc=tglx@linutronix.de \
    --cc=thymovanbeers@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.