From: Pavel Machek <pavel@ucw.cz>
To: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
Cc: Sakari Ailus <sakari.ailus@iki.fi>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-media <linux-media@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Hans Verkuil <hans.verkuil@cisco.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Subject: Re: [PATCH v2 2/4] [media] ad5820: Add support for enable pin
Date: Thu, 20 Sep 2018 22:21:22 +0200 [thread overview]
Message-ID: <20180920202122.GA30748@amd> (raw)
In-Reply-To: <20180920201420.GA28766@amd>
[-- Attachment #1: Type: text/plain, Size: 1063 bytes --]
Hi!
> > > > ad5820: dac@0c {
> > > > compatible = "adi,ad5820";
> > > > reg = <0x0c>;
> > > >
> > > > VANA-supply = <&pm8994_l23>;
> > > > enable-gpios = <&msmgpio 26 GPIO_ACTIVE_HIGH>;
> > > > };
> > >
> > > Well, I'm sure you could have gpio-based regulator powered from
> > > pm8994_l23, and outputting to ad5820.
> > >
> > > Does ad5820 chip have a gpio input for enable?
> >
> > xshutdown pin:
> > http://www.analog.com/media/en/technical-documentation/data-sheets/AD5821.pdf
> >
> > (AD5820,AD5821, and AD5823 are compatibles, or at least that is waht
> > the module manufacturer says :)
>
> Aha, sorry for the noise.
>
> 2,3: Acked-by: Pavel Machek <pavel@ucw.cz>
And I forgot to mention. If ad5821 and ad5823 are compatible, it would
be good to mention it somewhere where it is easy to find... That can
save quite a bit of work to someone.
Thanks,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2018-09-21 2:06 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-20 16:19 [PATCH 1/4] [media] ad5820: Define entity function Ricardo Ribalda Delgado
2018-09-20 16:19 ` [PATCH 2/4] [media] ad5820: Add support for enable pin Ricardo Ribalda Delgado
2018-09-20 18:40 ` Sakari Ailus
2018-09-20 18:47 ` Ricardo Ribalda Delgado
2018-09-20 18:45 ` [PATCH v2 " Ricardo Ribalda Delgado
2018-09-20 18:54 ` Pavel Machek
2018-09-20 19:06 ` Ricardo Ribalda Delgado
2018-09-20 19:08 ` Pavel Machek
2018-09-20 19:12 ` Ricardo Ribalda Delgado
2018-09-20 20:04 ` Laurent Pinchart
2018-09-20 20:04 ` Laurent Pinchart
2018-09-20 20:14 ` Pavel Machek
2018-09-20 20:21 ` Pavel Machek [this message]
2018-09-20 20:32 ` Ricardo Ribalda Delgado
2018-09-20 16:19 ` [PATCH 3/4] [media] ad5820: DT new optional field enable-gpios Ricardo Ribalda Delgado
2018-09-20 20:21 ` Laurent Pinchart
2018-09-20 20:23 ` Laurent Pinchart
2018-09-20 20:25 ` Ricardo Ribalda Delgado
2018-09-20 20:28 ` Pavel Machek
2018-09-20 16:19 ` [PATCH 4/4] [media] ad5820: Add support for of-autoload Ricardo Ribalda Delgado
2018-09-20 18:31 ` [PATCH v2 " Ricardo Ribalda Delgado
2018-09-20 18:55 ` Pavel Machek
2018-09-20 20:10 ` Laurent Pinchart
2018-09-20 20:18 ` Sakari Ailus
2018-09-20 20:22 ` [PATCH 1/4] [media] ad5820: Define entity function Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180920202122.GA30748@amd \
--to=pavel@ucw.cz \
--cc=hans.verkuil@cisco.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=ricardo.ribalda@gmail.com \
--cc=sakari.ailus@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.