All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: "Souza, Jose" <jose.souza@intel.com>
Cc: "Nikula, Jani" <jani.nikula@intel.com>,
	"intel-gfx@lists.freedesktop.org"
	<intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] drm/i915: Add AML id into KBL_ULX support list
Date: Fri, 21 Sep 2018 14:14:39 -0700	[thread overview]
Message-ID: <20180921211439.GD2420@intel.com> (raw)
In-Reply-To: <c9e00132b6e2f6336a70c7c883f7d627f0115c46.camel@intel.com>

On Fri, Sep 21, 2018 at 10:46:43AM -0700, Souza, Jose wrote:
> On Fri, 2018-09-21 at 09:17 -0700, Lee, Shawn C wrote:
> > According to patch "drm/i915/aml: Introducing Amber Lake platform"
> > (e364672477a1). Amber Lake uses the same gen graphics as Kaby Lake.
> > And it is the member of KBL ULX series.
> > 
> > So far, IS_KBL_ULX macro did not include AML platform. It may caused
> > driver load DDI translation table for KBL H/S series for AML system.
> > The change will lead driver to apply translation table for KBL Y for
> > AML device to avoid unexpected eDP/DP signal quality issue.
> > 
> > Cc: Jani Nikula <jani.nikula@intel.com>
> > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> > Cc: Jose Roberto de Souza <jose.souza@intel.com>
> > Signed-off-by: Lee, Shawn C <shawn.c.lee@intel.com>
> > ---
> >  drivers/gpu/drm/i915/i915_drv.h | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> > 
> > diff --git a/drivers/gpu/drm/i915/i915_drv.h
> > b/drivers/gpu/drm/i915/i915_drv.h
> > index 808204a7ca7c..0388de4d64a2 100644
> > --- a/drivers/gpu/drm/i915/i915_drv.h
> > +++ b/drivers/gpu/drm/i915/i915_drv.h
> > @@ -2460,7 +2460,9 @@ intel_info(const struct drm_i915_private
> > *dev_priv)
> >  				 INTEL_DEVID(dev_priv) == 0x5926)
> >  #define IS_KBL_ULX(dev_priv)	(INTEL_DEVID(dev_priv) == 0x590E || \
> >  				 INTEL_DEVID(dev_priv) == 0x5915 || \
> > -				 INTEL_DEVID(dev_priv) == 0x591E)
> > +				 INTEL_DEVID(dev_priv) == 0x591E || \
> > +				 INTEL_DEVID(dev_priv) == 0x591C || \
> > +				 INTEL_DEVID(dev_priv) == 0x87C0)
> 
> I guess we should keep the AML/WHL pattern, so could you create
> IS_AML_ULX() add AML IDs and then include add IS_AML_ULX() to
> IS_KBL_ULX()?

I have a mixed feeling with patterns. I like them, but BDW times
showed they get sometimes hidden hence forgotten so it is hard
to maintain.

Anyway, defining as ITS_OWN_PLATFORM_ULX and them embedded them
here or using there directly on the code NEW_ULX || KBL_ULX
is desired.

Otherwise if we define here inside KBL ULX we might thing this is
KBL. :/

> 
> >  #define IS_SKL_GT2(dev_priv)	(IS_SKYLAKE(dev_priv) && \
> >  				 (dev_priv)->info.gt == 2)
> >  #define IS_SKL_GT3(dev_priv)	(IS_SKYLAKE(dev_priv) && \
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

      reply	other threads:[~2018-09-21 21:14 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-21 16:17 [PATCH] drm/i915: Add AML id into KBL_ULX support list Lee, Shawn C
2018-09-21 15:51 ` ✗ Fi.CI.SPARSE: warning for " Patchwork
2018-09-21 16:11 ` ✓ Fi.CI.BAT: success " Patchwork
2018-09-21 17:44 ` ✓ Fi.CI.IGT: " Patchwork
2018-09-21 17:46 ` [PATCH] " Souza, Jose
2018-09-21 21:14   ` Rodrigo Vivi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180921211439.GD2420@intel.com \
    --to=rodrigo.vivi@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jani.nikula@intel.com \
    --cc=jose.souza@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.