* [PATCH] drm/i915: Add AML id into KBL_ULX support list
@ 2018-09-21 16:17 Lee, Shawn C
2018-09-21 15:51 ` ✗ Fi.CI.SPARSE: warning for " Patchwork
` (3 more replies)
0 siblings, 4 replies; 6+ messages in thread
From: Lee, Shawn C @ 2018-09-21 16:17 UTC (permalink / raw)
To: intel-gfx; +Cc: Jani Nikula, Lee, Rodrigo Vivi
According to patch "drm/i915/aml: Introducing Amber Lake platform"
(e364672477a1). Amber Lake uses the same gen graphics as Kaby Lake.
And it is the member of KBL ULX series.
So far, IS_KBL_ULX macro did not include AML platform. It may caused
driver load DDI translation table for KBL H/S series for AML system.
The change will lead driver to apply translation table for KBL Y for
AML device to avoid unexpected eDP/DP signal quality issue.
Cc: Jani Nikula <jani.nikula@intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: Jose Roberto de Souza <jose.souza@intel.com>
Signed-off-by: Lee, Shawn C <shawn.c.lee@intel.com>
---
drivers/gpu/drm/i915/i915_drv.h | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
index 808204a7ca7c..0388de4d64a2 100644
--- a/drivers/gpu/drm/i915/i915_drv.h
+++ b/drivers/gpu/drm/i915/i915_drv.h
@@ -2460,7 +2460,9 @@ intel_info(const struct drm_i915_private *dev_priv)
INTEL_DEVID(dev_priv) == 0x5926)
#define IS_KBL_ULX(dev_priv) (INTEL_DEVID(dev_priv) == 0x590E || \
INTEL_DEVID(dev_priv) == 0x5915 || \
- INTEL_DEVID(dev_priv) == 0x591E)
+ INTEL_DEVID(dev_priv) == 0x591E || \
+ INTEL_DEVID(dev_priv) == 0x591C || \
+ INTEL_DEVID(dev_priv) == 0x87C0)
#define IS_SKL_GT2(dev_priv) (IS_SKYLAKE(dev_priv) && \
(dev_priv)->info.gt == 2)
#define IS_SKL_GT3(dev_priv) (IS_SKYLAKE(dev_priv) && \
--
2.7.4
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 6+ messages in thread* ✗ Fi.CI.SPARSE: warning for drm/i915: Add AML id into KBL_ULX support list
2018-09-21 16:17 [PATCH] drm/i915: Add AML id into KBL_ULX support list Lee, Shawn C
@ 2018-09-21 15:51 ` Patchwork
2018-09-21 16:11 ` ✓ Fi.CI.BAT: success " Patchwork
` (2 subsequent siblings)
3 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2018-09-21 15:51 UTC (permalink / raw)
To: Lee, Shawn C; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Add AML id into KBL_ULX support list
URL : https://patchwork.freedesktop.org/series/50023/
State : warning
== Summary ==
$ dim sparse origin/drm-tip
Commit: drm/i915: Add AML id into KBL_ULX support list
-drivers/gpu/drm/i915/selftests/../i915_drv.h:3718:16: warning: expression using sizeof(void)
+drivers/gpu/drm/i915/selftests/../i915_drv.h:3720:16: warning: expression using sizeof(void)
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread* ✓ Fi.CI.BAT: success for drm/i915: Add AML id into KBL_ULX support list
2018-09-21 16:17 [PATCH] drm/i915: Add AML id into KBL_ULX support list Lee, Shawn C
2018-09-21 15:51 ` ✗ Fi.CI.SPARSE: warning for " Patchwork
@ 2018-09-21 16:11 ` Patchwork
2018-09-21 17:44 ` ✓ Fi.CI.IGT: " Patchwork
2018-09-21 17:46 ` [PATCH] " Souza, Jose
3 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2018-09-21 16:11 UTC (permalink / raw)
To: Lee, Shawn C; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Add AML id into KBL_ULX support list
URL : https://patchwork.freedesktop.org/series/50023/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4860 -> Patchwork_10253 =
== Summary - WARNING ==
Minor unknown changes coming with Patchwork_10253 need to be verified
manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_10253, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/50023/revisions/1/mbox/
== Possible new issues ==
Here are the unknown changes that may have been introduced in Patchwork_10253:
=== IGT changes ===
==== Warnings ====
igt@pm_rpm@module-reload:
fi-hsw-4770r: PASS -> SKIP
== Known issues ==
Here are the changes found in Patchwork_10253 that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@drv_module_reload@basic-reload-inject:
fi-hsw-4770r: PASS -> DMESG-WARN (fdo#107425, fdo#107924)
igt@kms_frontbuffer_tracking@basic:
fi-hsw-peppy: PASS -> DMESG-WARN (fdo#102614)
igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
fi-byt-clapper: PASS -> FAIL (fdo#107362, fdo#103191)
==== Possible fixes ====
igt@gem_exec_suspend@basic-s3:
fi-blb-e6850: INCOMPLETE (fdo#107718) -> PASS
igt@gem_mmap_gtt@basic-short:
fi-glk-dsi: INCOMPLETE (k.org#198133, fdo#103359) -> PASS
igt@kms_frontbuffer_tracking@basic:
fi-byt-clapper: FAIL (fdo#103167) -> PASS
igt@kms_psr@primary_page_flip:
fi-kbl-r: FAIL (fdo#107336) -> PASS
fdo#102614 https://bugs.freedesktop.org/show_bug.cgi?id=102614
fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
fdo#103359 https://bugs.freedesktop.org/show_bug.cgi?id=103359
fdo#107336 https://bugs.freedesktop.org/show_bug.cgi?id=107336
fdo#107362 https://bugs.freedesktop.org/show_bug.cgi?id=107362
fdo#107425 https://bugs.freedesktop.org/show_bug.cgi?id=107425
fdo#107718 https://bugs.freedesktop.org/show_bug.cgi?id=107718
fdo#107924 https://bugs.freedesktop.org/show_bug.cgi?id=107924
k.org#198133 https://bugzilla.kernel.org/show_bug.cgi?id=198133
== Participating hosts (52 -> 46) ==
Missing (6): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-snb-2600
== Build changes ==
* Linux: CI_DRM_4860 -> Patchwork_10253
CI_DRM_4860: 31c6d083d8c6fe280e3daabf22521335762759b9 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4649: 19b0c74d20d9b53d4c82be14af0909a3b6846010 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_10253: 87c4f38cfc86a4a86e693b1fe8161f8183add48d @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
87c4f38cfc86 drm/i915: Add AML id into KBL_ULX support list
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10253/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread* ✓ Fi.CI.IGT: success for drm/i915: Add AML id into KBL_ULX support list
2018-09-21 16:17 [PATCH] drm/i915: Add AML id into KBL_ULX support list Lee, Shawn C
2018-09-21 15:51 ` ✗ Fi.CI.SPARSE: warning for " Patchwork
2018-09-21 16:11 ` ✓ Fi.CI.BAT: success " Patchwork
@ 2018-09-21 17:44 ` Patchwork
2018-09-21 17:46 ` [PATCH] " Souza, Jose
3 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2018-09-21 17:44 UTC (permalink / raw)
To: Lee, Shawn C; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Add AML id into KBL_ULX support list
URL : https://patchwork.freedesktop.org/series/50023/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4860_full -> Patchwork_10253_full =
== Summary - SUCCESS ==
No regressions found.
== Known issues ==
Here are the changes found in Patchwork_10253_full that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@gem_exec_schedule@pi-ringfull-vebox:
shard-glk: NOTRUN -> FAIL (fdo#103158)
igt@kms_3d:
shard-kbl: PASS -> DMESG-WARN (fdo#103313, fdo#103558)
igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-a:
shard-glk: NOTRUN -> DMESG-WARN (fdo#107956) +1
igt@kms_color@pipe-a-legacy-gamma:
shard-kbl: PASS -> DMESG-WARN (fdo#105602, fdo#103313, fdo#103558) +4
igt@kms_cursor_legacy@cursor-vs-flip-atomic-transitions-varying-size:
shard-hsw: PASS -> FAIL (fdo#103355)
igt@kms_flip@basic-plain-flip:
shard-kbl: PASS -> DMESG-WARN (fdo#105602, fdo#103558) +1
igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes:
shard-apl: PASS -> INCOMPLETE (fdo#103927)
igt@kms_setmode@basic:
shard-apl: PASS -> FAIL (fdo#99912)
shard-glk: NOTRUN -> FAIL (fdo#99912)
igt@pm_rpm@system-suspend:
shard-kbl: PASS -> DMESG-WARN (fdo#103841)
==== Possible fixes ====
igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-b:
shard-snb: DMESG-WARN (fdo#107956) -> PASS
igt@kms_cursor_legacy@cursora-vs-flipa-toggle:
shard-glk: DMESG-WARN (fdo#105763, fdo#106538) -> PASS
igt@kms_flip@2x-flip-vs-expired-vblank-interruptible:
shard-glk: FAIL (fdo#105363) -> PASS
fdo#103158 https://bugs.freedesktop.org/show_bug.cgi?id=103158
fdo#103313 https://bugs.freedesktop.org/show_bug.cgi?id=103313
fdo#103355 https://bugs.freedesktop.org/show_bug.cgi?id=103355
fdo#103558 https://bugs.freedesktop.org/show_bug.cgi?id=103558
fdo#103841 https://bugs.freedesktop.org/show_bug.cgi?id=103841
fdo#103927 https://bugs.freedesktop.org/show_bug.cgi?id=103927
fdo#105363 https://bugs.freedesktop.org/show_bug.cgi?id=105363
fdo#105602 https://bugs.freedesktop.org/show_bug.cgi?id=105602
fdo#105763 https://bugs.freedesktop.org/show_bug.cgi?id=105763
fdo#106538 https://bugs.freedesktop.org/show_bug.cgi?id=106538
fdo#107956 https://bugs.freedesktop.org/show_bug.cgi?id=107956
fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
== Participating hosts (5 -> 5) ==
No changes in participating hosts
== Build changes ==
* Linux: CI_DRM_4860 -> Patchwork_10253
CI_DRM_4860: 31c6d083d8c6fe280e3daabf22521335762759b9 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4649: 19b0c74d20d9b53d4c82be14af0909a3b6846010 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_10253: 87c4f38cfc86a4a86e693b1fe8161f8183add48d @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10253/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] drm/i915: Add AML id into KBL_ULX support list
2018-09-21 16:17 [PATCH] drm/i915: Add AML id into KBL_ULX support list Lee, Shawn C
` (2 preceding siblings ...)
2018-09-21 17:44 ` ✓ Fi.CI.IGT: " Patchwork
@ 2018-09-21 17:46 ` Souza, Jose
2018-09-21 21:14 ` Rodrigo Vivi
3 siblings, 1 reply; 6+ messages in thread
From: Souza, Jose @ 2018-09-21 17:46 UTC (permalink / raw)
To: intel-gfx@lists.freedesktop.org, Lee, Shawn C; +Cc: Nikula, Jani, Vivi, Rodrigo
On Fri, 2018-09-21 at 09:17 -0700, Lee, Shawn C wrote:
> According to patch "drm/i915/aml: Introducing Amber Lake platform"
> (e364672477a1). Amber Lake uses the same gen graphics as Kaby Lake.
> And it is the member of KBL ULX series.
>
> So far, IS_KBL_ULX macro did not include AML platform. It may caused
> driver load DDI translation table for KBL H/S series for AML system.
> The change will lead driver to apply translation table for KBL Y for
> AML device to avoid unexpected eDP/DP signal quality issue.
>
> Cc: Jani Nikula <jani.nikula@intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Cc: Jose Roberto de Souza <jose.souza@intel.com>
> Signed-off-by: Lee, Shawn C <shawn.c.lee@intel.com>
> ---
> drivers/gpu/drm/i915/i915_drv.h | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_drv.h
> b/drivers/gpu/drm/i915/i915_drv.h
> index 808204a7ca7c..0388de4d64a2 100644
> --- a/drivers/gpu/drm/i915/i915_drv.h
> +++ b/drivers/gpu/drm/i915/i915_drv.h
> @@ -2460,7 +2460,9 @@ intel_info(const struct drm_i915_private
> *dev_priv)
> INTEL_DEVID(dev_priv) == 0x5926)
> #define IS_KBL_ULX(dev_priv) (INTEL_DEVID(dev_priv) == 0x590E || \
> INTEL_DEVID(dev_priv) == 0x5915 || \
> - INTEL_DEVID(dev_priv) == 0x591E)
> + INTEL_DEVID(dev_priv) == 0x591E || \
> + INTEL_DEVID(dev_priv) == 0x591C || \
> + INTEL_DEVID(dev_priv) == 0x87C0)
I guess we should keep the AML/WHL pattern, so could you create
IS_AML_ULX() add AML IDs and then include add IS_AML_ULX() to
IS_KBL_ULX()?
> #define IS_SKL_GT2(dev_priv) (IS_SKYLAKE(dev_priv) && \
> (dev_priv)->info.gt == 2)
> #define IS_SKL_GT3(dev_priv) (IS_SKYLAKE(dev_priv) && \
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] drm/i915: Add AML id into KBL_ULX support list
2018-09-21 17:46 ` [PATCH] " Souza, Jose
@ 2018-09-21 21:14 ` Rodrigo Vivi
0 siblings, 0 replies; 6+ messages in thread
From: Rodrigo Vivi @ 2018-09-21 21:14 UTC (permalink / raw)
To: Souza, Jose; +Cc: Nikula, Jani, intel-gfx@lists.freedesktop.org
On Fri, Sep 21, 2018 at 10:46:43AM -0700, Souza, Jose wrote:
> On Fri, 2018-09-21 at 09:17 -0700, Lee, Shawn C wrote:
> > According to patch "drm/i915/aml: Introducing Amber Lake platform"
> > (e364672477a1). Amber Lake uses the same gen graphics as Kaby Lake.
> > And it is the member of KBL ULX series.
> >
> > So far, IS_KBL_ULX macro did not include AML platform. It may caused
> > driver load DDI translation table for KBL H/S series for AML system.
> > The change will lead driver to apply translation table for KBL Y for
> > AML device to avoid unexpected eDP/DP signal quality issue.
> >
> > Cc: Jani Nikula <jani.nikula@intel.com>
> > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> > Cc: Jose Roberto de Souza <jose.souza@intel.com>
> > Signed-off-by: Lee, Shawn C <shawn.c.lee@intel.com>
> > ---
> > drivers/gpu/drm/i915/i915_drv.h | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/i915/i915_drv.h
> > b/drivers/gpu/drm/i915/i915_drv.h
> > index 808204a7ca7c..0388de4d64a2 100644
> > --- a/drivers/gpu/drm/i915/i915_drv.h
> > +++ b/drivers/gpu/drm/i915/i915_drv.h
> > @@ -2460,7 +2460,9 @@ intel_info(const struct drm_i915_private
> > *dev_priv)
> > INTEL_DEVID(dev_priv) == 0x5926)
> > #define IS_KBL_ULX(dev_priv) (INTEL_DEVID(dev_priv) == 0x590E || \
> > INTEL_DEVID(dev_priv) == 0x5915 || \
> > - INTEL_DEVID(dev_priv) == 0x591E)
> > + INTEL_DEVID(dev_priv) == 0x591E || \
> > + INTEL_DEVID(dev_priv) == 0x591C || \
> > + INTEL_DEVID(dev_priv) == 0x87C0)
>
> I guess we should keep the AML/WHL pattern, so could you create
> IS_AML_ULX() add AML IDs and then include add IS_AML_ULX() to
> IS_KBL_ULX()?
I have a mixed feeling with patterns. I like them, but BDW times
showed they get sometimes hidden hence forgotten so it is hard
to maintain.
Anyway, defining as ITS_OWN_PLATFORM_ULX and them embedded them
here or using there directly on the code NEW_ULX || KBL_ULX
is desired.
Otherwise if we define here inside KBL ULX we might thing this is
KBL. :/
>
> > #define IS_SKL_GT2(dev_priv) (IS_SKYLAKE(dev_priv) && \
> > (dev_priv)->info.gt == 2)
> > #define IS_SKL_GT3(dev_priv) (IS_SKYLAKE(dev_priv) && \
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-09-21 21:14 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-09-21 16:17 [PATCH] drm/i915: Add AML id into KBL_ULX support list Lee, Shawn C
2018-09-21 15:51 ` ✗ Fi.CI.SPARSE: warning for " Patchwork
2018-09-21 16:11 ` ✓ Fi.CI.BAT: success " Patchwork
2018-09-21 17:44 ` ✓ Fi.CI.IGT: " Patchwork
2018-09-21 17:46 ` [PATCH] " Souza, Jose
2018-09-21 21:14 ` Rodrigo Vivi
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.