* [PATCH] ASoC: cs4265: Add a MIC pre. route
@ 2018-09-23 23:08 Matt Flax
2018-09-24 8:45 ` Charles Keepax
0 siblings, 1 reply; 2+ messages in thread
From: Matt Flax @ 2018-09-23 23:08 UTC (permalink / raw)
To: alsa-devel; +Cc: brian.austin, broonie, ckeepax, paul.handrigan, Matt Flax
The cs4265 driver is missing a microphone preamp enable.
This patch enables/disables the microphone preamp when mic
selection is made using the kcontrol.
Signed-off-by: Matt Flax <flatmax@flatmax.org>
---
sound/soc/codecs/cs4265.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/sound/soc/codecs/cs4265.c b/sound/soc/codecs/cs4265.c
index 275677de..332d714a 100644
--- a/sound/soc/codecs/cs4265.c
+++ b/sound/soc/codecs/cs4265.c
@@ -230,6 +230,10 @@ static const struct snd_soc_dapm_route cs4265_audio_map[] = {
{"DAI1 Capture", NULL, "DOUT"},
{"DAI2 Capture", NULL, "DOUT"},
+ { "Pre-amp MIC", NULL, "MICL" },
+ { "Pre-amp MIC", NULL, "MICR" },
+ { "ADC Mux", "MIC", "Pre-amp MIC" },
+
/* Loopback */
{"Loopback", "Switch", "ADC"},
{"DAC", NULL, "Loopback"},
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ASoC: cs4265: Add a MIC pre. route
2018-09-23 23:08 [PATCH] ASoC: cs4265: Add a MIC pre. route Matt Flax
@ 2018-09-24 8:45 ` Charles Keepax
0 siblings, 0 replies; 2+ messages in thread
From: Charles Keepax @ 2018-09-24 8:45 UTC (permalink / raw)
To: Matt Flax; +Cc: alsa-devel, broonie, brian.austin, paul.handrigan
On Mon, Sep 24, 2018 at 09:08:35AM +1000, Matt Flax wrote:
> The cs4265 driver is missing a microphone preamp enable.
> This patch enables/disables the microphone preamp when mic
> selection is made using the kcontrol.
>
> Signed-off-by: Matt Flax <flatmax@flatmax.org>
> ---
> sound/soc/codecs/cs4265.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/sound/soc/codecs/cs4265.c b/sound/soc/codecs/cs4265.c
> index 275677de..332d714a 100644
> --- a/sound/soc/codecs/cs4265.c
> +++ b/sound/soc/codecs/cs4265.c
> @@ -230,6 +230,10 @@ static const struct snd_soc_dapm_route cs4265_audio_map[] = {
> {"DAI1 Capture", NULL, "DOUT"},
> {"DAI2 Capture", NULL, "DOUT"},
>
> + { "Pre-amp MIC", NULL, "MICL" },
> + { "Pre-amp MIC", NULL, "MICR" },
> + { "ADC Mux", "MIC", "Pre-amp MIC" },
> +
This looks good but I think you should also remove the existing
routes that put the mic straight into the ADC Mux.
{"ADC Mux", "MIC", "MICL"},
{"ADC Mux", "MIC", "MICR"},
Thanks,
Charles
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-09-24 8:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-09-23 23:08 [PATCH] ASoC: cs4265: Add a MIC pre. route Matt Flax
2018-09-24 8:45 ` Charles Keepax
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.