From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: stable@vger.kernel.org, "Michal Simek" <michal.simek@xilinx.com>,
"Jiri Slaby" <jslaby@suse.com>,
"Russell King" <linux@armlinux.org.uk>,
"Hauke Mehrtens" <hauke@hauke-m.de>,
bcm-kernel-feedback-list <bcm-kernel-feedback-list@broadcom.com>,
"Rafał Miłecki" <rafal@milecki.pl>
Subject: Re: [PATCH 4.14-4.17 1/2] earlycon: Initialize port->uartclk based on clock-frequency property
Date: Mon, 24 Sep 2018 12:54:52 +0200 [thread overview]
Message-ID: <20180924105452.GC16476@kroah.com> (raw)
In-Reply-To: <20180923223446.3773-1-zajec5@gmail.com>
On Mon, Sep 24, 2018 at 12:34:45AM +0200, Rafał Miłecki wrote:
> From: Michal Simek <michal.simek@xilinx.com>
>
> commit 814453adea7d081ad8917aa0f32d6a14165a3563 upstream.
>
> On DT based platforms when current-speed property is present baudrate
> is setup. Also port->uartclk is initialized to bogus BASE_BAUD * 16
> value. Drivers like uartps/ns16550 contain logic when baudrate and
> uartclk is used for baudrate calculation.
>
> The patch is reading optional clock-frequency property to replace bogus
> BASE_BAUD * 16 calculation to have proper baudrate calculation.
>
> [-stable comment: commit 31cb9a8575ca ("earlycon: initialise baud field
> of earlycon device structure") has changed 8250_early.c behavior which
> now tries to setup UART speed. Ignoring clock-frequency results in
> wrong value of calculated divisor & malformed early console output.]
Thanks for both of these, now queued up.
greg k-h
prev parent reply other threads:[~2018-09-24 16:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-23 22:34 [PATCH 4.14-4.17 1/2] earlycon: Initialize port->uartclk based on clock-frequency property Rafał Miłecki
2018-09-23 22:34 ` [PATCH 4.14-4.17 2/2] earlycon: Remove hardcoded port->uartclk initialization in of_setup_earlycon Rafał Miłecki
2018-09-24 10:54 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180924105452.GC16476@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=hauke@hauke-m.de \
--cc=jslaby@suse.com \
--cc=linux@armlinux.org.uk \
--cc=michal.simek@xilinx.com \
--cc=rafal@milecki.pl \
--cc=stable@vger.kernel.org \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.