From: Wolfram Sang <wsa@the-dreams.de>
To: linux-aspeed@lists.ozlabs.org
Subject: [PATCH v4] i2c: aspeed: fix invalid clock parameters for very large divisors
Date: Mon, 24 Sep 2018 23:51:18 +0200 [thread overview]
Message-ID: <20180924215118.GC18592@kunai> (raw)
In-Reply-To: <20180921233050.121570-1-brendanhiggins@google.com>
On Fri, Sep 21, 2018 at 04:30:50PM -0700, Brendan Higgins wrote:
> The function that computes clock parameters from divisors did not
> respect the maximum size of the bitfields that the parameters were
> written to. This fixes the bug.
>
> This bug can be reproduced with (and this fix verified with) the test
> at: https://kunit-review.googlesource.com/c/linux/+/1035/
>
> Discovered-by-KUnit: https://kunit-review.googlesource.com/c/linux/+/1035/
> Signed-off-by: Brendan Higgins <brendanhiggins@google.com>
> Reviewed-by: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
Applied to for-next, thanks!
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.ozlabs.org/pipermail/linux-aspeed/attachments/20180924/12f6a14f/attachment.sig>
WARNING: multiple messages have this Message-ID (diff)
From: Wolfram Sang <wsa@the-dreams.de>
To: Brendan Higgins <brendanhiggins@google.com>
Cc: jae.hyun.yoo@linux.intel.com, benh@kernel.crashing.org,
joel@jms.id.au, andrew@aj.id.au, linux-i2c@vger.kernel.org,
openbmc@lists.ozlabs.org, linux-aspeed@lists.ozlabs.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] i2c: aspeed: fix invalid clock parameters for very large divisors
Date: Mon, 24 Sep 2018 23:51:18 +0200 [thread overview]
Message-ID: <20180924215118.GC18592@kunai> (raw)
In-Reply-To: <20180921233050.121570-1-brendanhiggins@google.com>
[-- Attachment #1: Type: text/plain, Size: 616 bytes --]
On Fri, Sep 21, 2018 at 04:30:50PM -0700, Brendan Higgins wrote:
> The function that computes clock parameters from divisors did not
> respect the maximum size of the bitfields that the parameters were
> written to. This fixes the bug.
>
> This bug can be reproduced with (and this fix verified with) the test
> at: https://kunit-review.googlesource.com/c/linux/+/1035/
>
> Discovered-by-KUnit: https://kunit-review.googlesource.com/c/linux/+/1035/
> Signed-off-by: Brendan Higgins <brendanhiggins@google.com>
> Reviewed-by: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
Applied to for-next, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2018-09-24 21:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-21 23:30 [PATCH v4] i2c: aspeed: fix invalid clock parameters for very large divisors Brendan Higgins
2018-09-21 23:30 ` Brendan Higgins
2018-09-24 21:51 ` Wolfram Sang [this message]
2018-09-24 21:51 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180924215118.GC18592@kunai \
--to=wsa@the-dreams.de \
--cc=linux-aspeed@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.