All of lore.kernel.org
 help / color / mirror / Atom feed
From: Baoquan He <bhe@redhat.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: dan.j.williams@intel.com, brijesh.singh@amd.com,
	Lianbo Jiang <lijiang@redhat.com>,
	thomas.lendacky@amd.com, tiwai@suse.de, x86@kernel.org,
	kexec@lists.infradead.org, linux-kernel@vger.kernel.org,
	mingo@redhat.com, baiyaowei@cmss.chinamobile.com, hpa@zytor.com,
	tglx@linutronix.de, bp@suse.de, dyoung@redhat.com,
	akpm@linux-foundation.org, Vivek Goyal <vgoyal@redhat.com>
Subject: Re: [PATCH 3/3] resource: Fix find_next_iomem_res() iteration issue
Date: Tue, 25 Sep 2018 16:58:46 +0800	[thread overview]
Message-ID: <20180925085846.GY2555@MiWiFi-R3L-srv> (raw)
In-Reply-To: <153782730364.130337.17794279728329113665.stgit@bhelgaas-glaptop.roam.corp.google.com>

Hi Bjorn,

On 09/24/18 at 05:15pm, Bjorn Helgaas wrote:
> @@ -359,32 +362,31 @@ static int find_next_iomem_res(struct resource *res, unsigned long desc,
>  	read_unlock(&resource_lock);
>  	if (!p)
>  		return -1;
> +
>  	/* copy data */
> -	if (res->start < p->start)
> -		res->start = p->start;
> -	if (res->end > p->end)
> -		res->end = p->end;
> +	res->start = max(start, p->start);
> +	res->end = min(end, p->end);
>  	res->flags = p->flags;

I think this fix is good. However, is it OK to keep res->flags always,
never touch it in find_next_iomem_res()? We just iterate and update
region, its start and end. So just removing that "res->flags = p->flags;"
line might involve much less code changes.

Thanks
Baoquan

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

WARNING: multiple messages have this Message-ID (diff)
From: Baoquan He <bhe@redhat.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: Lianbo Jiang <lijiang@redhat.com>,
	Vivek Goyal <vgoyal@redhat.com>,
	linux-kernel@vger.kernel.org, kexec@lists.infradead.org,
	tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com,
	x86@kernel.org, akpm@linux-foundation.org,
	dan.j.williams@intel.com, thomas.lendacky@amd.com,
	baiyaowei@cmss.chinamobile.com, tiwai@suse.de, bp@suse.de,
	brijesh.singh@amd.com, dyoung@redhat.com
Subject: Re: [PATCH 3/3] resource: Fix find_next_iomem_res() iteration issue
Date: Tue, 25 Sep 2018 16:58:46 +0800	[thread overview]
Message-ID: <20180925085846.GY2555@MiWiFi-R3L-srv> (raw)
In-Reply-To: <153782730364.130337.17794279728329113665.stgit@bhelgaas-glaptop.roam.corp.google.com>

Hi Bjorn,

On 09/24/18 at 05:15pm, Bjorn Helgaas wrote:
> @@ -359,32 +362,31 @@ static int find_next_iomem_res(struct resource *res, unsigned long desc,
>  	read_unlock(&resource_lock);
>  	if (!p)
>  		return -1;
> +
>  	/* copy data */
> -	if (res->start < p->start)
> -		res->start = p->start;
> -	if (res->end > p->end)
> -		res->end = p->end;
> +	res->start = max(start, p->start);
> +	res->end = min(end, p->end);
>  	res->flags = p->flags;

I think this fix is good. However, is it OK to keep res->flags always,
never touch it in find_next_iomem_res()? We just iterate and update
region, its start and end. So just removing that "res->flags = p->flags;"
line might involve much less code changes.

Thanks
Baoquan

  reply	other threads:[~2018-09-25  8:59 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-21  7:32 [PATCH 0/3 v3] add reserved e820 ranges to the kdump kernel e820 table Lianbo Jiang
2018-09-21  7:32 ` Lianbo Jiang
2018-09-21  7:32 ` [PATCH 1/3 v3] resource: fix an error which walks through iomem resources Lianbo Jiang
2018-09-21  7:32   ` Lianbo Jiang
2018-09-24 17:52   ` Bjorn Helgaas
2018-09-24 17:52     ` Bjorn Helgaas
2018-09-25  7:08     ` lijiang
2018-09-25  7:08       ` lijiang
2018-09-24 22:14   ` [PATCH 0/3] find_next_iomem_res() fixes Bjorn Helgaas
2018-09-24 22:14     ` Bjorn Helgaas
2018-09-24 22:14     ` [PATCH 1/3] x86/kexec: Correct KEXEC_BACKUP_SRC_END off-by-one error Bjorn Helgaas
2018-09-24 22:14       ` Bjorn Helgaas
2018-09-24 22:14     ` [PATCH 2/3] resource: Include resource end in walk_*() interfaces Bjorn Helgaas
2018-09-24 22:14       ` Bjorn Helgaas
2018-09-24 22:15     ` [PATCH 3/3] resource: Fix find_next_iomem_res() iteration issue Bjorn Helgaas
2018-09-24 22:15       ` Bjorn Helgaas
2018-09-25  8:58       ` Baoquan He [this message]
2018-09-25  8:58         ` Baoquan He
2018-09-25 11:20         ` Baoquan He
2018-09-25 11:20           ` Baoquan He
2018-09-27  5:27       ` lijiang
2018-09-27  5:27         ` lijiang
2018-09-27 14:03         ` Bjorn Helgaas
2018-09-27 14:03           ` Bjorn Helgaas
2018-09-28  5:09           ` lijiang
2018-09-28  5:09             ` lijiang
2018-09-28 13:10           ` Borislav Petkov
2018-09-28 13:10             ` Borislav Petkov
2018-09-26  9:22     ` [PATCH 0/3] find_next_iomem_res() fixes lijiang
2018-09-26  9:22       ` lijiang
2018-09-26 13:36       ` lijiang
2018-09-26 13:36         ` lijiang
2018-09-21  7:32 ` [PATCH 2/3 v3] x86/kexec_file: add e820 entry in case e820 type string matches to io resource name Lianbo Jiang
2018-09-21  7:32   ` Lianbo Jiang
2018-09-21  7:32 ` [PATCH 3/3 v3] x86/kexec_file: add reserved e820 ranges to kdump kernel e820 table Lianbo Jiang
2018-09-21  7:32   ` Lianbo Jiang
2018-10-16  2:56 ` [PATCH 0/3 v3] add reserved e820 ranges to the " Dave Young
2018-10-16  2:56   ` Dave Young
2018-10-16  3:45   ` lijiang
2018-10-16  3:45     ` lijiang
  -- strict thread matches above, loose matches on Subject: below --
2018-09-27 14:21 [PATCH 0/3] find_next_iomem_res() fixes Bjorn Helgaas
2018-09-27 14:22 ` [PATCH 3/3] resource: Fix find_next_iomem_res() iteration issue Bjorn Helgaas
2018-09-27 14:22   ` Bjorn Helgaas
2018-09-28 16:41   ` Borislav Petkov
2018-09-28 16:41     ` Borislav Petkov
2018-10-09 17:30     ` Bjorn Helgaas
2018-10-09 17:30       ` Bjorn Helgaas
2018-10-09 17:35       ` Borislav Petkov
2018-10-09 17:35         ` Borislav Petkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180925085846.GY2555@MiWiFi-R3L-srv \
    --to=bhe@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=baiyaowei@cmss.chinamobile.com \
    --cc=bp@suse.de \
    --cc=brijesh.singh@amd.com \
    --cc=dan.j.williams@intel.com \
    --cc=dyoung@redhat.com \
    --cc=helgaas@kernel.org \
    --cc=hpa@zytor.com \
    --cc=kexec@lists.infradead.org \
    --cc=lijiang@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=thomas.lendacky@amd.com \
    --cc=tiwai@suse.de \
    --cc=vgoyal@redhat.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.