All of lore.kernel.org
 help / color / mirror / Atom feed
From: andrea.parri@amarulasolutions.com (Andrea Parri)
To: linux-riscv@lists.infradead.org
Subject: [PATCH 1/2] riscv/bitops: Remove smp_mb__{before,after}_clear_bit()
Date: Tue, 25 Sep 2018 19:49:06 +0200	[thread overview]
Message-ID: <20180925174906.GA4372@andrea> (raw)
In-Reply-To: <mhng-2c59d90d-9cf9-4462-bfb6-5c90ffa0c6d0@palmer-si-x1c4>

On Tue, Sep 25, 2018 at 10:19:24AM -0700, Palmer Dabbelt wrote:
> On Tue, 25 Sep 2018 05:12:24 PDT (-0700), andrea.parri at amarulasolutions.com wrote:
> > The barriers are unused; remove their definition.
> > 
> > Signed-off-by: Andrea Parri <andrea.parri@amarulasolutions.com>
> > Cc: Palmer Dabbelt <palmer@sifive.com>
> > Cc: Albert Ou <aou@eecs.berkeley.edu>
> > Cc: <linux-riscv@lists.infradead.org>
> > ---
> >  arch/riscv/include/asm/bitops.h | 5 -----
> >  1 file changed, 5 deletions(-)
> > 
> > diff --git a/arch/riscv/include/asm/bitops.h b/arch/riscv/include/asm/bitops.h
> > index f30daf26f08f4..01db98dfd0435 100644
> > --- a/arch/riscv/include/asm/bitops.h
> > +++ b/arch/riscv/include/asm/bitops.h
> > @@ -23,11 +23,6 @@
> >  #include <asm/barrier.h>
> >  #include <asm/bitsperlong.h>
> > 
> > -#ifndef smp_mb__before_clear_bit
> > -#define smp_mb__before_clear_bit()  smp_mb()
> > -#define smp_mb__after_clear_bit()   smp_mb()
> > -#endif /* smp_mb__before_clear_bit */
> > -
> >  #include <asm-generic/bitops/__ffs.h>
> >  #include <asm-generic/bitops/ffz.h>
> >  #include <asm-generic/bitops/fls.h>
> 
> Reviewed-by: Palmer Dabbelt <palmer@sifive.com>

Thank you.


> 
> Do you want me to take this via the RISC-V tree?  I only ended up with patch
> 1/2 in my inbox, and I probably shouldn't take both.

I expected this to go via the RISC-V tree and 2/2 via the H8/300 tree,
but really no preference from me as long as they get upstreamed. ;-)

Thanks,
  Andrea


> 
> Thanks!

WARNING: multiple messages have this Message-ID (diff)
From: Andrea Parri <andrea.parri@amarulasolutions.com>
To: Palmer Dabbelt <palmer@sifive.com>
Cc: linux-riscv@lists.infradead.org, aou@eecs.berkeley.edu,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] riscv/bitops: Remove smp_mb__{before,after}_clear_bit()
Date: Tue, 25 Sep 2018 19:49:06 +0200	[thread overview]
Message-ID: <20180925174906.GA4372@andrea> (raw)
Message-ID: <20180925174906.c0l7_toJ2_xszpY4xKZ9xOegjrSq9ksSW6E7LXALobc@z> (raw)
In-Reply-To: <mhng-2c59d90d-9cf9-4462-bfb6-5c90ffa0c6d0@palmer-si-x1c4>

On Tue, Sep 25, 2018 at 10:19:24AM -0700, Palmer Dabbelt wrote:
> On Tue, 25 Sep 2018 05:12:24 PDT (-0700), andrea.parri@amarulasolutions.com wrote:
> > The barriers are unused; remove their definition.
> > 
> > Signed-off-by: Andrea Parri <andrea.parri@amarulasolutions.com>
> > Cc: Palmer Dabbelt <palmer@sifive.com>
> > Cc: Albert Ou <aou@eecs.berkeley.edu>
> > Cc: <linux-riscv@lists.infradead.org>
> > ---
> >  arch/riscv/include/asm/bitops.h | 5 -----
> >  1 file changed, 5 deletions(-)
> > 
> > diff --git a/arch/riscv/include/asm/bitops.h b/arch/riscv/include/asm/bitops.h
> > index f30daf26f08f4..01db98dfd0435 100644
> > --- a/arch/riscv/include/asm/bitops.h
> > +++ b/arch/riscv/include/asm/bitops.h
> > @@ -23,11 +23,6 @@
> >  #include <asm/barrier.h>
> >  #include <asm/bitsperlong.h>
> > 
> > -#ifndef smp_mb__before_clear_bit
> > -#define smp_mb__before_clear_bit()  smp_mb()
> > -#define smp_mb__after_clear_bit()   smp_mb()
> > -#endif /* smp_mb__before_clear_bit */
> > -
> >  #include <asm-generic/bitops/__ffs.h>
> >  #include <asm-generic/bitops/ffz.h>
> >  #include <asm-generic/bitops/fls.h>
> 
> Reviewed-by: Palmer Dabbelt <palmer@sifive.com>

Thank you.


> 
> Do you want me to take this via the RISC-V tree?  I only ended up with patch
> 1/2 in my inbox, and I probably shouldn't take both.

I expected this to go via the RISC-V tree and 2/2 via the H8/300 tree,
but really no preference from me as long as they get upstreamed. ;-)

Thanks,
  Andrea


> 
> Thanks!

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

WARNING: multiple messages have this Message-ID (diff)
From: Andrea Parri <andrea.parri@amarulasolutions.com>
To: Palmer Dabbelt <palmer@sifive.com>
Cc: linux-kernel@vger.kernel.org, aou@eecs.berkeley.edu,
	linux-riscv@lists.infradead.org
Subject: Re: [PATCH 1/2] riscv/bitops: Remove smp_mb__{before,after}_clear_bit()
Date: Tue, 25 Sep 2018 19:49:06 +0200	[thread overview]
Message-ID: <20180925174906.GA4372@andrea> (raw)
In-Reply-To: <mhng-2c59d90d-9cf9-4462-bfb6-5c90ffa0c6d0@palmer-si-x1c4>

On Tue, Sep 25, 2018 at 10:19:24AM -0700, Palmer Dabbelt wrote:
> On Tue, 25 Sep 2018 05:12:24 PDT (-0700), andrea.parri@amarulasolutions.com wrote:
> > The barriers are unused; remove their definition.
> > 
> > Signed-off-by: Andrea Parri <andrea.parri@amarulasolutions.com>
> > Cc: Palmer Dabbelt <palmer@sifive.com>
> > Cc: Albert Ou <aou@eecs.berkeley.edu>
> > Cc: <linux-riscv@lists.infradead.org>
> > ---
> >  arch/riscv/include/asm/bitops.h | 5 -----
> >  1 file changed, 5 deletions(-)
> > 
> > diff --git a/arch/riscv/include/asm/bitops.h b/arch/riscv/include/asm/bitops.h
> > index f30daf26f08f4..01db98dfd0435 100644
> > --- a/arch/riscv/include/asm/bitops.h
> > +++ b/arch/riscv/include/asm/bitops.h
> > @@ -23,11 +23,6 @@
> >  #include <asm/barrier.h>
> >  #include <asm/bitsperlong.h>
> > 
> > -#ifndef smp_mb__before_clear_bit
> > -#define smp_mb__before_clear_bit()  smp_mb()
> > -#define smp_mb__after_clear_bit()   smp_mb()
> > -#endif /* smp_mb__before_clear_bit */
> > -
> >  #include <asm-generic/bitops/__ffs.h>
> >  #include <asm-generic/bitops/ffz.h>
> >  #include <asm-generic/bitops/fls.h>
> 
> Reviewed-by: Palmer Dabbelt <palmer@sifive.com>

Thank you.


> 
> Do you want me to take this via the RISC-V tree?  I only ended up with patch
> 1/2 in my inbox, and I probably shouldn't take both.

I expected this to go via the RISC-V tree and 2/2 via the H8/300 tree,
but really no preference from me as long as they get upstreamed. ;-)

Thanks,
  Andrea


> 
> Thanks!

  reply	other threads:[~2018-09-25 17:49 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-25 12:12 [PATCH trivial 0/2] h8300, riscv: Remove smp_mb__{before, after}_clear_bit() Andrea Parri
2018-09-25 12:12 ` [PATCH trivial 0/2] h8300, riscv: Remove smp_mb__{before,after}_clear_bit() Andrea Parri
2018-09-25 12:12 ` [PATCH trivial 0/2] h8300, riscv: Remove smp_mb__{before, after}_clear_bit() Andrea Parri
2018-09-25 12:12 ` [PATCH 1/2] riscv/bitops: Remove smp_mb__{before,after}_clear_bit() Andrea Parri
2018-09-25 12:12   ` Andrea Parri
2018-09-25 12:12   ` Andrea Parri
2018-09-25 17:19   ` [PATCH 1/2] riscv/bitops: Remove smp_mb__{before, after}_clear_bit() Palmer Dabbelt
2018-09-25 17:19     ` [PATCH 1/2] riscv/bitops: Remove smp_mb__{before,after}_clear_bit() Palmer Dabbelt
2018-09-25 17:19     ` [PATCH 1/2] riscv/bitops: Remove smp_mb__{before, after}_clear_bit() Palmer Dabbelt
2018-09-25 17:49     ` Andrea Parri [this message]
2018-09-25 17:49       ` [PATCH 1/2] riscv/bitops: Remove smp_mb__{before,after}_clear_bit() Andrea Parri
2018-09-25 17:49       ` Andrea Parri
2018-09-25 17:57       ` [PATCH 1/2] riscv/bitops: Remove smp_mb__{before, after}_clear_bit() Palmer Dabbelt
2018-09-25 17:57         ` [PATCH 1/2] riscv/bitops: Remove smp_mb__{before,after}_clear_bit() Palmer Dabbelt
2018-09-25 17:57         ` [PATCH 1/2] riscv/bitops: Remove smp_mb__{before, after}_clear_bit() Palmer Dabbelt
2018-09-25 12:12 ` [PATCH 2/2] h8300/bitops: Remove smp_mb__{before,after}_clear_bit() Andrea Parri

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180925174906.GA4372@andrea \
    --to=andrea.parri@amarulasolutions.com \
    --cc=linux-riscv@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.