From: "J. Bruce Fields" <bfields@fieldses.org>
To: YueHaibing <yuehaibing@huawei.com>
Cc: Jeff Layton <jlayton@kernel.org>,
linux-nfs@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] nfsd: remove set but not used variable 'dirp'
Date: Wed, 26 Sep 2018 00:35:35 +0000 [thread overview]
Message-ID: <20180926003535.GC9559@fieldses.org> (raw)
In-Reply-To: <1537874573-182553-1-git-send-email-yuehaibing@huawei.com>
Thanks, applying for 4.20.--b.
On Tue, Sep 25, 2018 at 11:22:53AM +0000, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> fs/nfsd/vfs.c: In function 'nfsd_create':
> fs/nfsd/vfs.c:1279:16: warning:
> variable 'dirp' set but not used [-Wunused-but-set-variable]
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> fs/nfsd/vfs.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/fs/nfsd/vfs.c b/fs/nfsd/vfs.c
> index b53e763..d74583f 100644
> --- a/fs/nfsd/vfs.c
> +++ b/fs/nfsd/vfs.c
> @@ -1276,7 +1276,6 @@ __be32 nfsd_read(struct svc_rqst *rqstp, struct svc_fh *fhp,
> int type, dev_t rdev, struct svc_fh *resfhp)
> {
> struct dentry *dentry, *dchild = NULL;
> - struct inode *dirp;
> __be32 err;
> int host_err;
>
> @@ -1288,7 +1287,6 @@ __be32 nfsd_read(struct svc_rqst *rqstp, struct svc_fh *fhp,
> return err;
>
> dentry = fhp->fh_dentry;
> - dirp = d_inode(dentry);
>
> host_err = fh_want_write(fhp);
> if (host_err)
WARNING: multiple messages have this Message-ID (diff)
From: "J. Bruce Fields" <bfields@fieldses.org>
To: YueHaibing <yuehaibing@huawei.com>
Cc: Jeff Layton <jlayton@kernel.org>,
linux-nfs@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] nfsd: remove set but not used variable 'dirp'
Date: Tue, 25 Sep 2018 20:35:35 -0400 [thread overview]
Message-ID: <20180926003535.GC9559@fieldses.org> (raw)
In-Reply-To: <1537874573-182553-1-git-send-email-yuehaibing@huawei.com>
Thanks, applying for 4.20.--b.
On Tue, Sep 25, 2018 at 11:22:53AM +0000, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> fs/nfsd/vfs.c: In function 'nfsd_create':
> fs/nfsd/vfs.c:1279:16: warning:
> variable 'dirp' set but not used [-Wunused-but-set-variable]
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> fs/nfsd/vfs.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/fs/nfsd/vfs.c b/fs/nfsd/vfs.c
> index b53e763..d74583f 100644
> --- a/fs/nfsd/vfs.c
> +++ b/fs/nfsd/vfs.c
> @@ -1276,7 +1276,6 @@ __be32 nfsd_read(struct svc_rqst *rqstp, struct svc_fh *fhp,
> int type, dev_t rdev, struct svc_fh *resfhp)
> {
> struct dentry *dentry, *dchild = NULL;
> - struct inode *dirp;
> __be32 err;
> int host_err;
>
> @@ -1288,7 +1287,6 @@ __be32 nfsd_read(struct svc_rqst *rqstp, struct svc_fh *fhp,
> return err;
>
> dentry = fhp->fh_dentry;
> - dirp = d_inode(dentry);
>
> host_err = fh_want_write(fhp);
> if (host_err)
next prev parent reply other threads:[~2018-09-26 0:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-25 11:22 [PATCH -next] nfsd: remove set but not used variable 'dirp' YueHaibing
2018-09-25 11:22 ` YueHaibing
2018-09-26 0:35 ` J. Bruce Fields [this message]
2018-09-26 0:35 ` J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180926003535.GC9559@fieldses.org \
--to=bfields@fieldses.org \
--cc=jlayton@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.