From: Ido Schimmel <idosch@idosch.org>
To: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
Cc: netdev@vger.kernel.org, roopa@cumulusnetworks.com,
bridge@lists.linux-foundation.org, davem@davemloft.net
Subject: Re: [Bridge] [PATCH net-next 9/9] net: bridge: pack net_bridge better
Date: Wed, 26 Sep 2018 16:30:14 +0300 [thread overview]
Message-ID: <20180926133014.GA31563@splinter> (raw)
In-Reply-To: <20180926121802.27851-10-nikolay@cumulusnetworks.com>
On Wed, Sep 26, 2018 at 03:18:02PM +0300, Nikolay Aleksandrov wrote:
> Further reduce the size of net_bridge with 8 bytes and reduce the number of
> holes in it:
> Before: holes: 5, sum holes: 15
> After: holes: 2, sum holes: 3
>
> Also as a bonus we get offload_fwd_mark in the first cache line and remove
> the need to pull the last cache line of net_bridge just for that member in
> fast path (should_deliver -> nbp_switchdev_allowed_egress).
But nbp_switchdev_allowed_egress() compares with 'offload_fwd_mark' from
'net_bridge_port', not 'net_bridge'...
WARNING: multiple messages have this Message-ID (diff)
From: Ido Schimmel <idosch@idosch.org>
To: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
Cc: netdev@vger.kernel.org, roopa@cumulusnetworks.com,
davem@davemloft.net, stephen@networkplumber.org,
bridge@lists.linux-foundation.org
Subject: Re: [PATCH net-next 9/9] net: bridge: pack net_bridge better
Date: Wed, 26 Sep 2018 16:30:14 +0300 [thread overview]
Message-ID: <20180926133014.GA31563@splinter> (raw)
In-Reply-To: <20180926121802.27851-10-nikolay@cumulusnetworks.com>
On Wed, Sep 26, 2018 at 03:18:02PM +0300, Nikolay Aleksandrov wrote:
> Further reduce the size of net_bridge with 8 bytes and reduce the number of
> holes in it:
> Before: holes: 5, sum holes: 15
> After: holes: 2, sum holes: 3
>
> Also as a bonus we get offload_fwd_mark in the first cache line and remove
> the need to pull the last cache line of net_bridge just for that member in
> fast path (should_deliver -> nbp_switchdev_allowed_egress).
But nbp_switchdev_allowed_egress() compares with 'offload_fwd_mark' from
'net_bridge_port', not 'net_bridge'...
next prev parent reply other threads:[~2018-09-26 13:30 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-26 12:17 [Bridge] [PATCH net-next 0/9] net: bridge: convert bool options to bits Nikolay Aleksandrov
2018-09-26 12:17 ` Nikolay Aleksandrov
2018-09-26 12:17 ` [Bridge] [PATCH net-next 1/9] net: bridge: make struct opening bracket consistent Nikolay Aleksandrov
2018-09-26 12:17 ` Nikolay Aleksandrov
2018-09-26 12:17 ` [Bridge] [PATCH net-next 2/9] net: bridge: add bitfield for options and convert vlan opts Nikolay Aleksandrov
2018-09-26 12:17 ` Nikolay Aleksandrov
2018-09-26 14:48 ` [Bridge] " Andrew Lunn
2018-09-26 14:48 ` Andrew Lunn
2018-09-26 14:55 ` [Bridge] " Nikolay Aleksandrov
2018-09-26 14:55 ` Nikolay Aleksandrov
2018-09-26 15:01 ` [Bridge] " Andrew Lunn
2018-09-26 15:01 ` Andrew Lunn
2018-09-26 12:17 ` [Bridge] [PATCH net-next 3/9] net: bridge: convert nf call options to bits Nikolay Aleksandrov
2018-09-26 12:17 ` Nikolay Aleksandrov
2018-09-26 12:17 ` [Bridge] [PATCH net-next 4/9] net: bridge: convert group_addr_set option to a bit Nikolay Aleksandrov
2018-09-26 12:17 ` Nikolay Aleksandrov
2018-09-26 12:17 ` [Bridge] [PATCH net-next 5/9] net: bridge: convert and rename mcast disabled Nikolay Aleksandrov
2018-09-26 12:17 ` Nikolay Aleksandrov
2018-09-26 12:17 ` [Bridge] [PATCH net-next 6/9] net: bridge: convert mcast options to bits Nikolay Aleksandrov
2018-09-26 12:17 ` Nikolay Aleksandrov
2018-09-26 12:18 ` [Bridge] [PATCH net-next 7/9] net: bridge: convert neigh_suppress_enabled option to a bit Nikolay Aleksandrov
2018-09-26 12:18 ` Nikolay Aleksandrov
2018-09-26 12:18 ` [Bridge] [PATCH net-next 8/9] net: bridge: convert mtu_set_by_user " Nikolay Aleksandrov
2018-09-26 12:18 ` Nikolay Aleksandrov
2018-09-26 12:18 ` [Bridge] [PATCH net-next 9/9] net: bridge: pack net_bridge better Nikolay Aleksandrov
2018-09-26 12:18 ` Nikolay Aleksandrov
2018-09-26 13:30 ` Ido Schimmel [this message]
2018-09-26 13:30 ` Ido Schimmel
2018-09-26 13:35 ` [Bridge] " Nikolay Aleksandrov
2018-09-26 13:35 ` Nikolay Aleksandrov
2018-09-26 12:52 ` [Bridge] [PATCH net-next 0/9] net: bridge: convert bool options to bits Stephen Hemminger
2018-09-26 12:52 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180926133014.GA31563@splinter \
--to=idosch@idosch.org \
--cc=bridge@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=nikolay@cumulusnetworks.com \
--cc=roopa@cumulusnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.