From: Steven Rostedt <rostedt@goodmis.org>
To: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Shuah Khan <shuahkh@osg.samsung.com>,
linux-kselftest <linux-kselftest@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-api <linux-api@vger.kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
Boqun Feng <boqun.feng@gmail.com>,
Andy Lutomirski <luto@amacapital.net>,
Dave Watson <davejwatson@fb.com>, Paul Turner <pjt@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
Russell King <linux@arm.linux.org.uk>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
Andi Kleen <andi@firstfloor.org>, Chris Lameter <cl@linux.com>,
Ben Maurer <bmaurer@fb.com>,
Josh Triplett <josh@joshtriplett.org>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH] rseq/selftests: fix parametrized test with -fpie
Date: Thu, 27 Sep 2018 09:22:35 -0400 [thread overview]
Message-ID: <20180927092235.77282e35@vmware.local.home> (raw)
In-Reply-To: <1367962117.10271.1537897176578.JavaMail.zimbra@efficios.com>
On Tue, 25 Sep 2018 13:39:36 -0400 (EDT)
Mathieu Desnoyers <mathieu.desnoyers@efficios.com> wrote:
> ----- On Sep 18, 2018, at 9:53 AM, Mathieu Desnoyers mathieu.desnoyers@efficios.com wrote:
>
> > On x86-64, the parametrized selftest code for rseq crashes with a
> > segmentation fault when compiled with -fpie. This happens when the
> > param_test binary is loaded at an address beyond 32-bit on x86-64.
> >
> > The issue is caused by use of a 32-bit register to hold the address
> > of the loop counter variable.
> >
> > Fix this by using a 64-bit register to calculate the address of the
> > loop counter variables as an offset from rip.
>
> Should this fix go through tip or the selftests tree ?
>
I usually have changes like this pulled through Shuah's tree with an
ack from the maintainer of the code that it tests.
-- Steve
WARNING: multiple messages have this Message-ID (diff)
From: rostedt at goodmis.org (Steven Rostedt)
Subject: [PATCH] rseq/selftests: fix parametrized test with -fpie
Date: Thu, 27 Sep 2018 09:22:35 -0400 [thread overview]
Message-ID: <20180927092235.77282e35@vmware.local.home> (raw)
In-Reply-To: <1367962117.10271.1537897176578.JavaMail.zimbra@efficios.com>
On Tue, 25 Sep 2018 13:39:36 -0400 (EDT)
Mathieu Desnoyers <mathieu.desnoyers at efficios.com> wrote:
> ----- On Sep 18, 2018, at 9:53 AM, Mathieu Desnoyers mathieu.desnoyers at efficios.com wrote:
>
> > On x86-64, the parametrized selftest code for rseq crashes with a
> > segmentation fault when compiled with -fpie. This happens when the
> > param_test binary is loaded at an address beyond 32-bit on x86-64.
> >
> > The issue is caused by use of a 32-bit register to hold the address
> > of the loop counter variable.
> >
> > Fix this by using a 64-bit register to calculate the address of the
> > loop counter variables as an offset from rip.
>
> Should this fix go through tip or the selftests tree ?
>
I usually have changes like this pulled through Shuah's tree with an
ack from the maintainer of the code that it tests.
-- Steve
WARNING: multiple messages have this Message-ID (diff)
From: rostedt@goodmis.org (Steven Rostedt)
Subject: [PATCH] rseq/selftests: fix parametrized test with -fpie
Date: Thu, 27 Sep 2018 09:22:35 -0400 [thread overview]
Message-ID: <20180927092235.77282e35@vmware.local.home> (raw)
Message-ID: <20180927132235.-j6ZFLZ_aSbsmHT5zJ9feRFcG1-hbUg8iS3J3j_E4uE@z> (raw)
In-Reply-To: <1367962117.10271.1537897176578.JavaMail.zimbra@efficios.com>
On Tue, 25 Sep 2018 13:39:36 -0400 (EDT)
Mathieu Desnoyers <mathieu.desnoyers@efficios.com> wrote:
> ----- On Sep 18, 2018,@9:53 AM, Mathieu Desnoyers mathieu.desnoyers@efficios.com wrote:
>
> > On x86-64, the parametrized selftest code for rseq crashes with a
> > segmentation fault when compiled with -fpie. This happens when the
> > param_test binary is loaded at an address beyond 32-bit on x86-64.
> >
> > The issue is caused by use of a 32-bit register to hold the address
> > of the loop counter variable.
> >
> > Fix this by using a 64-bit register to calculate the address of the
> > loop counter variables as an offset from rip.
>
> Should this fix go through tip or the selftests tree ?
>
I usually have changes like this pulled through Shuah's tree with an
ack from the maintainer of the code that it tests.
-- Steve
WARNING: multiple messages have this Message-ID (diff)
From: Steven Rostedt <rostedt@goodmis.org>
To: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Shuah Khan <shuahkh@osg.samsung.com>,
linux-kselftest <linux-kselftest@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-api <linux-api@vger.kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
Boqun Feng <boqun.feng@gmail.com>,
Andy Lutomirski <luto@amacapital.net>,
Dave Watson <davejwatson@fb.com>, Paul Turner <pjt@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
Russell King <linux@arm.linux.org.uk>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
Andi Kleen <andi@firstfloor.org>, Chris Lameter <cl@linux.com>,
Ben Maurer <bmaurer@fb.com>,
Josh Triplett <josh@joshtriplett.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
Michael Kerrisk <mtk.manpages@gmail.com>,
Joel Fernandes <joelaf@google.com>,
stable <stable@vger.kernel.org>
Subject: Re: [PATCH] rseq/selftests: fix parametrized test with -fpie
Date: Thu, 27 Sep 2018 09:22:35 -0400 [thread overview]
Message-ID: <20180927092235.77282e35@vmware.local.home> (raw)
In-Reply-To: <1367962117.10271.1537897176578.JavaMail.zimbra@efficios.com>
On Tue, 25 Sep 2018 13:39:36 -0400 (EDT)
Mathieu Desnoyers <mathieu.desnoyers@efficios.com> wrote:
> ----- On Sep 18, 2018, at 9:53 AM, Mathieu Desnoyers mathieu.desnoyers@efficios.com wrote:
>
> > On x86-64, the parametrized selftest code for rseq crashes with a
> > segmentation fault when compiled with -fpie. This happens when the
> > param_test binary is loaded at an address beyond 32-bit on x86-64.
> >
> > The issue is caused by use of a 32-bit register to hold the address
> > of the loop counter variable.
> >
> > Fix this by using a 64-bit register to calculate the address of the
> > loop counter variables as an offset from rip.
>
> Should this fix go through tip or the selftests tree ?
>
I usually have changes like this pulled through Shuah's tree with an
ack from the maintainer of the code that it tests.
-- Steve
next prev parent reply other threads:[~2018-09-27 13:22 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-18 13:53 [PATCH] rseq/selftests: fix parametrized test with -fpie Mathieu Desnoyers
2018-09-18 13:53 ` Mathieu Desnoyers
2018-09-18 13:53 ` Mathieu Desnoyers
2018-09-18 13:53 ` mathieu.desnoyers
2018-09-25 17:39 ` Mathieu Desnoyers
2018-09-25 17:39 ` Mathieu Desnoyers
2018-09-25 17:39 ` Mathieu Desnoyers
2018-09-25 17:39 ` mathieu.desnoyers
2018-09-27 13:22 ` Steven Rostedt [this message]
2018-09-27 13:22 ` Steven Rostedt
2018-09-27 13:22 ` Steven Rostedt
2018-09-27 13:22 ` rostedt
2018-09-27 13:58 ` Shuah Khan
2018-09-27 13:58 ` Shuah Khan
2018-09-27 13:58 ` Shuah Khan
2018-09-27 13:58 ` shuah.kh
2018-09-27 18:02 ` Mathieu Desnoyers
2018-09-27 18:02 ` Mathieu Desnoyers
2018-09-27 18:02 ` Mathieu Desnoyers
2018-09-27 18:02 ` mathieu.desnoyers
2018-09-27 18:10 ` Shuah Khan
2018-09-27 18:10 ` Shuah Khan
2018-09-27 18:10 ` Shuah Khan
2018-09-27 18:10 ` shuah.kh
2018-09-27 18:26 ` Shuah Khan
2018-09-27 18:26 ` Shuah Khan
2018-09-27 18:26 ` Shuah Khan
2018-09-27 18:26 ` shuah
2018-09-27 18:18 ` Paul E. McKenney
2018-09-27 18:18 ` Paul E. McKenney
2018-09-27 18:18 ` Paul E. McKenney
2018-09-27 18:18 ` paulmck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180927092235.77282e35@vmware.local.home \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=bmaurer@fb.com \
--cc=boqun.feng@gmail.com \
--cc=cl@linux.com \
--cc=davejwatson@fb.com \
--cc=hpa@zytor.com \
--cc=josh@joshtriplett.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=luto@amacapital.net \
--cc=mathieu.desnoyers@efficios.com \
--cc=mingo@redhat.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=pjt@google.com \
--cc=shuahkh@osg.samsung.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.