From: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
To: Robin Murphy <robin.murphy-5wv7dgnIgG8@public.gmane.org>
Cc: Benjamin Herrenschmidt
<benh-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
Greg Kroah-Hartman
<gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>,
linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
Subject: Re: [PATCH 4/5] dma-direct: implement complete bus_dma_mask handling
Date: Thu, 27 Sep 2018 18:27:37 +0200 [thread overview]
Message-ID: <20180927162737.GA11974@lst.de> (raw)
In-Reply-To: <967e98b1-99ab-8f95-4c89-6156ce489b93-5wv7dgnIgG8@public.gmane.org>
On Thu, Sep 27, 2018 at 05:14:56PM +0100, Robin Murphy wrote:
>> This just seemed more readable to me than min_not_zero, but if others
>> prefer min_not_zero I can switch.
>
> Nah, just checking whether there were any intentionally different
> assumptions compared to the couple of other places in the patch where
> min_not_zero() *is* used. If it's purely a style thing then no worries
> (personally I'd have written it yet another way anyway).
I'm curious: how would you have written it?
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Robin Murphy <robin.murphy@arm.com>
Cc: Christoph Hellwig <hch@lst.de>,
iommu@lists.linux-foundation.org,
Marek Szyprowski <m.szyprowski@samsung.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 4/5] dma-direct: implement complete bus_dma_mask handling
Date: Thu, 27 Sep 2018 18:27:37 +0200 [thread overview]
Message-ID: <20180927162737.GA11974@lst.de> (raw)
In-Reply-To: <967e98b1-99ab-8f95-4c89-6156ce489b93@arm.com>
On Thu, Sep 27, 2018 at 05:14:56PM +0100, Robin Murphy wrote:
>> This just seemed more readable to me than min_not_zero, but if others
>> prefer min_not_zero I can switch.
>
> Nah, just checking whether there were any intentionally different
> assumptions compared to the couple of other places in the patch where
> min_not_zero() *is* used. If it's purely a style thing then no worries
> (personally I'd have written it yet another way anyway).
I'm curious: how would you have written it?
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Robin Murphy <robin.murphy@arm.com>
Cc: linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linuxppc-dev@lists.ozlabs.org, Christoph Hellwig <hch@lst.de>,
Marek Szyprowski <m.szyprowski@samsung.com>
Subject: Re: [PATCH 4/5] dma-direct: implement complete bus_dma_mask handling
Date: Thu, 27 Sep 2018 18:27:37 +0200 [thread overview]
Message-ID: <20180927162737.GA11974@lst.de> (raw)
Message-ID: <20180927162737.CgFIEXzdFs-yH0hzGdqiLiil84JcEDGiyFxqgMFCT_U@z> (raw)
In-Reply-To: <967e98b1-99ab-8f95-4c89-6156ce489b93@arm.com>
On Thu, Sep 27, 2018 at 05:14:56PM +0100, Robin Murphy wrote:
>> This just seemed more readable to me than min_not_zero, but if others
>> prefer min_not_zero I can switch.
>
> Nah, just checking whether there were any intentionally different
> assumptions compared to the couple of other places in the patch where
> min_not_zero() *is* used. If it's purely a style thing then no worries
> (personally I'd have written it yet another way anyway).
I'm curious: how would you have written it?
next prev parent reply other threads:[~2018-09-27 16:27 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-20 18:52 dma mask related fixups (including full bus_dma_mask support) Christoph Hellwig
2018-09-20 18:52 ` [PATCH 1/5] dma-mapping: make the get_required_mask method available unconditionally Christoph Hellwig
[not found] ` <20180920185247.20037-2-hch-jcswGhMUV9g@public.gmane.org>
2018-09-27 1:28 ` Benjamin Herrenschmidt
2018-09-27 1:28 ` Benjamin Herrenschmidt
2018-09-20 18:52 ` [PATCH 2/5] dma-direct: add an explicit dma_direct_get_required_mask Christoph Hellwig
[not found] ` <20180920185247.20037-3-hch-jcswGhMUV9g@public.gmane.org>
2018-09-27 1:31 ` Benjamin Herrenschmidt
2018-09-27 1:31 ` Benjamin Herrenschmidt
2018-09-27 14:12 ` Robin Murphy
2018-09-27 15:28 ` Christoph Hellwig
[not found] ` <20180927152818.GC10566-jcswGhMUV9g@public.gmane.org>
2018-09-27 15:35 ` Robin Murphy
2018-09-27 15:35 ` Robin Murphy
2018-09-20 18:52 ` [PATCH 3/5] dma-direct: refine dma_direct_alloc zone selection Christoph Hellwig
[not found] ` <20180920185247.20037-4-hch-jcswGhMUV9g@public.gmane.org>
2018-09-27 1:45 ` Benjamin Herrenschmidt
2018-09-27 1:45 ` Benjamin Herrenschmidt
[not found] ` <1811156d5a1df1166c7ab7522525619b951f047d.camel-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org>
2018-09-27 13:49 ` Christoph Hellwig
2018-09-27 13:49 ` Christoph Hellwig
[not found] ` <20180927134922.GA8281-jcswGhMUV9g@public.gmane.org>
2018-09-28 0:06 ` Benjamin Herrenschmidt
2018-09-28 0:06 ` Benjamin Herrenschmidt
2018-09-28 0:06 ` Benjamin Herrenschmidt
2018-09-28 15:46 ` Christoph Hellwig
2018-09-28 15:46 ` Christoph Hellwig
2018-09-27 14:30 ` Robin Murphy
2018-09-27 15:30 ` Christoph Hellwig
[not found] ` <20180927153028.GD10566-jcswGhMUV9g@public.gmane.org>
2018-09-27 15:38 ` Robin Murphy
2018-09-27 15:38 ` Robin Murphy
[not found] ` <2b98d7b2-bf74-ccc9-881a-a91e2c9949c3-5wv7dgnIgG8@public.gmane.org>
2018-09-27 15:41 ` Christoph Hellwig
2018-09-27 15:41 ` Christoph Hellwig
2018-09-20 18:52 ` [PATCH 4/5] dma-direct: implement complete bus_dma_mask handling Christoph Hellwig
[not found] ` <20180920185247.20037-5-hch-jcswGhMUV9g@public.gmane.org>
2018-09-27 14:58 ` Robin Murphy
2018-09-27 14:58 ` Robin Murphy
2018-09-27 15:32 ` Christoph Hellwig
2018-09-27 16:14 ` Robin Murphy
2018-09-27 16:14 ` Robin Murphy
[not found] ` <967e98b1-99ab-8f95-4c89-6156ce489b93-5wv7dgnIgG8@public.gmane.org>
2018-09-27 16:27 ` Christoph Hellwig [this message]
2018-09-27 16:27 ` Christoph Hellwig
2018-09-27 16:27 ` Christoph Hellwig
[not found] ` <20180927162737.GA11974-jcswGhMUV9g@public.gmane.org>
2018-09-27 16:41 ` Robin Murphy
2018-09-27 16:41 ` Robin Murphy
2018-09-27 16:41 ` Robin Murphy
2018-09-20 18:52 ` [PATCH 5/5] dma-direct: always allow dma mask <= physiscal memory size Christoph Hellwig
[not found] ` <20180920185247.20037-6-hch-jcswGhMUV9g@public.gmane.org>
2018-09-27 1:50 ` Benjamin Herrenschmidt
2018-09-27 1:50 ` Benjamin Herrenschmidt
2018-09-27 13:49 ` Christoph Hellwig
2018-09-27 15:07 ` Robin Murphy
-- strict thread matches above, loose matches on Subject: below --
2018-09-27 22:35 dma mask related fixups (including full bus_dma_mask support) v2 Christoph Hellwig
[not found] ` <20180927223539.28449-1-hch-jcswGhMUV9g@public.gmane.org>
2018-09-27 22:35 ` [PATCH 4/5] dma-direct: implement complete bus_dma_mask handling Christoph Hellwig
2018-09-27 22:35 ` Christoph Hellwig
2018-09-27 22:35 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180927162737.GA11974@lst.de \
--to=hch-jcswghmuv9g@public.gmane.org \
--cc=benh-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org \
--cc=gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org \
--cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
--cc=robin.murphy-5wv7dgnIgG8@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.