* [linux main PATCH] crypto: qat - make qat_asym_algs.o depend on asn1 headers
@ 2018-09-27 22:42 Chris Packham
2018-09-28 4:45 ` Greg KH
0 siblings, 1 reply; 4+ messages in thread
From: Chris Packham @ 2018-09-27 22:42 UTC (permalink / raw)
To: Luuk Paulussen; +Cc: Jan Stancek, stable, Herbert Xu
From: Jan Stancek <jstancek@redhat.com>
Parallel build can sporadically fail because asn1 headers may
not be built yet by the time qat_asym_algs.o is compiled:
drivers/crypto/qat/qat_common/qat_asym_algs.c:55:32: fatal error: qat_rsapubkey-asn1.h: No such file or directory
#include "qat_rsapubkey-asn1.h"
Cc: stable@vger.kernel.org
Signed-off-by: Jan Stancek <jstancek@redhat.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
[upstream commit 81dc0365cfa7bc7c08a0e44d9ee04964df782e19]
Reviewed-by: Scott Parlane <scott.parlane@alliedtelesis.co.nz>
Reviewed-by: Luuk Paulussen <luuk.paulussen@alliedtelesis.co.nz>
Change-Id: Ie811cd1fbb497c84ca86d18ae8362973c600d9a1
---
drivers/crypto/qat/qat_common/Makefile | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/crypto/qat/qat_common/Makefile b/drivers/crypto/qat/qat_common/Makefile
index 9e9e196c6d51..45b5adaafa6f 100644
--- a/drivers/crypto/qat/qat_common/Makefile
+++ b/drivers/crypto/qat/qat_common/Makefile
@@ -2,6 +2,7 @@ $(obj)/qat_rsapubkey-asn1.o: $(obj)/qat_rsapubkey-asn1.c \
$(obj)/qat_rsapubkey-asn1.h
$(obj)/qat_rsaprivkey-asn1.o: $(obj)/qat_rsaprivkey-asn1.c \
$(obj)/qat_rsaprivkey-asn1.h
+$(obj)/qat_asym_algs.o: $(obj)/qat_rsapubkey-asn1.h $(obj)/qat_rsaprivkey-asn1.h
clean-files += qat_rsapubkey-asn1.c qat_rsapubkey-asn1.h
clean-files += qat_rsaprivkey-asn1.c qat_rsapvivkey-asn1.h
--
2.19.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [linux main PATCH] crypto: qat - make qat_asym_algs.o depend on asn1 headers
2018-09-27 22:42 [linux main PATCH] crypto: qat - make qat_asym_algs.o depend on asn1 headers Chris Packham
@ 2018-09-28 4:45 ` Greg KH
2018-09-28 4:51 ` Chris Packham
0 siblings, 1 reply; 4+ messages in thread
From: Greg KH @ 2018-09-28 4:45 UTC (permalink / raw)
To: Chris Packham; +Cc: Luuk Paulussen, Jan Stancek, stable, Herbert Xu
On Fri, Sep 28, 2018 at 10:42:44AM +1200, Chris Packham wrote:
> From: Jan Stancek <jstancek@redhat.com>
>
> Parallel build can sporadically fail because asn1 headers may
> not be built yet by the time qat_asym_algs.o is compiled:
> drivers/crypto/qat/qat_common/qat_asym_algs.c:55:32: fatal error: qat_rsapubkey-asn1.h: No such file or directory
> #include "qat_rsapubkey-asn1.h"
>
> Cc: stable@vger.kernel.org
> Signed-off-by: Jan Stancek <jstancek@redhat.com>
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
>
> [upstream commit 81dc0365cfa7bc7c08a0e44d9ee04964df782e19]
> Reviewed-by: Scott Parlane <scott.parlane@alliedtelesis.co.nz>
> Reviewed-by: Luuk Paulussen <luuk.paulussen@alliedtelesis.co.nz>
>
> Change-Id: Ie811cd1fbb497c84ca86d18ae8362973c600d9a1
Why is this change-id line here? What am I supposed to do with this
patch overall? What stable tree do you want it in? It's already
backported to really old kernels today, shouldn't you just be using them
already?
confused,
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [linux main PATCH] crypto: qat - make qat_asym_algs.o depend on asn1 headers
2018-09-28 4:45 ` Greg KH
@ 2018-09-28 4:51 ` Chris Packham
2018-09-28 4:56 ` Greg KH
0 siblings, 1 reply; 4+ messages in thread
From: Chris Packham @ 2018-09-28 4:51 UTC (permalink / raw)
To: Greg KH; +Cc: Luuk Paulussen, Jan Stancek, stable@vger.kernel.org, Herbert Xu
Hi Greg,
On 28/09/18 16:46, Greg KH wrote:
> On Fri, Sep 28, 2018 at 10:42:44AM +1200, Chris Packham wrote:
>> From: Jan Stancek <jstancek@redhat.com>
>>
>> Parallel build can sporadically fail because asn1 headers may
>> not be built yet by the time qat_asym_algs.o is compiled:
>> drivers/crypto/qat/qat_common/qat_asym_algs.c:55:32: fatal error: qat_rsapubkey-asn1.h: No such file or directory
>> #include "qat_rsapubkey-asn1.h"
>>
>> Cc: stable@vger.kernel.org
>> Signed-off-by: Jan Stancek <jstancek@redhat.com>
>> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
>>
>> [upstream commit 81dc0365cfa7bc7c08a0e44d9ee04964df782e19]
>> Reviewed-by: Scott Parlane <scott.parlane@alliedtelesis.co.nz>
>> Reviewed-by: Luuk Paulussen <luuk.paulussen@alliedtelesis.co.nz>
>>
>> Change-Id: Ie811cd1fbb497c84ca86d18ae8362973c600d9a1
>
> Why is this change-id line here? What am I supposed to do with this
> patch overall? What stable tree do you want it in? It's already
> backported to really old kernels today, shouldn't you just be using them
> already?
Sorry for the noise. I fat-fingered the git send-email invocation for
applying this to an internal kernel fork.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [linux main PATCH] crypto: qat - make qat_asym_algs.o depend on asn1 headers
2018-09-28 4:51 ` Chris Packham
@ 2018-09-28 4:56 ` Greg KH
0 siblings, 0 replies; 4+ messages in thread
From: Greg KH @ 2018-09-28 4:56 UTC (permalink / raw)
To: Chris Packham
Cc: Luuk Paulussen, Jan Stancek, stable@vger.kernel.org, Herbert Xu
On Fri, Sep 28, 2018 at 04:51:43AM +0000, Chris Packham wrote:
> Hi Greg,
>
> On 28/09/18 16:46, Greg KH wrote:
> > On Fri, Sep 28, 2018 at 10:42:44AM +1200, Chris Packham wrote:
> >> From: Jan Stancek <jstancek@redhat.com>
> >>
> >> Parallel build can sporadically fail because asn1 headers may
> >> not be built yet by the time qat_asym_algs.o is compiled:
> >> drivers/crypto/qat/qat_common/qat_asym_algs.c:55:32: fatal error: qat_rsapubkey-asn1.h: No such file or directory
> >> #include "qat_rsapubkey-asn1.h"
> >>
> >> Cc: stable@vger.kernel.org
> >> Signed-off-by: Jan Stancek <jstancek@redhat.com>
> >> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
> >>
> >> [upstream commit 81dc0365cfa7bc7c08a0e44d9ee04964df782e19]
> >> Reviewed-by: Scott Parlane <scott.parlane@alliedtelesis.co.nz>
> >> Reviewed-by: Luuk Paulussen <luuk.paulussen@alliedtelesis.co.nz>
> >>
> >> Change-Id: Ie811cd1fbb497c84ca86d18ae8362973c600d9a1
> >
> > Why is this change-id line here? What am I supposed to do with this
> > patch overall? What stable tree do you want it in? It's already
> > backported to really old kernels today, shouldn't you just be using them
> > already?
>
> Sorry for the noise. I fat-fingered the git send-email invocation for
> applying this to an internal kernel fork.
Your internal kernel fork should be based on a newer kernel version. If
you have to backport this old patch, you have much worse problems than
this :)
good luck!
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-09-28 11:18 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-09-27 22:42 [linux main PATCH] crypto: qat - make qat_asym_algs.o depend on asn1 headers Chris Packham
2018-09-28 4:45 ` Greg KH
2018-09-28 4:51 ` Chris Packham
2018-09-28 4:56 ` Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.