All of lore.kernel.org
 help / color / mirror / Atom feed
From: shawnguo@kernel.org (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64: dts: add LX2160AQDS board support
Date: Fri, 28 Sep 2018 17:00:32 +0800	[thread overview]
Message-ID: <20180928090030.GI26692@dragon> (raw)
In-Reply-To: <20180921141720.19159-1-pankaj.bansal@nxp.com>

On Fri, Sep 21, 2018 at 07:47:20PM +0530, Pankaj Bansal wrote:
> The LX2160A QorIQ Development System (QDS) is a test, evaluation, and
> development platform, supporting QorIQ LX2160A processor.
> 
> Signed-off-by: Sriram Dash <sriram.dash@nxp.com>
> Signed-off-by: Pankaj Bansal <pankaj.bansal@nxp.com>
> ---
> 
> Notes:
>     This patch is dependent on [1] and [2]
>      [1] https://lore.kernel.org/patchwork/patch/985935/
>      [2] https://lore.kernel.org/patchwork/patch/985938/

I did not receive these.

> 
>  arch/arm64/boot/dts/freescale/Makefile       |  1 +
>  .../boot/dts/freescale/fsl-lx2160a-qds.dts   | 88 ++++++++++++++++++
>  2 files changed, 89 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/freescale/Makefile
> index 445b72bd5a36..ae80fc5c45f7 100644
> --- a/arch/arm64/boot/dts/freescale/Makefile
> +++ b/arch/arm64/boot/dts/freescale/Makefile
> @@ -14,3 +14,4 @@ dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls2080a-simu.dtb
>  dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls2088a-qds.dtb
>  dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls2088a-rdb.dtb
>  dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-lx2160a-rdb.dtb
> +dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-lx2160a-qds.dtb

Please keep them in alphabetic order.

> diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a-qds.dts b/arch/arm64/boot/dts/freescale/fsl-lx2160a-qds.dts
> new file mode 100644
> index 000000000000..5cf2fe279f73
> --- /dev/null
> +++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a-qds.dts
> @@ -0,0 +1,88 @@
> +// SPDX-License-Identifier: (GPL-2.0 OR MIT)
> +//
> +// Device Tree file for LX2160AQDS
> +//
> +// Copyright 2018 NXP
> +
> +/dts-v1/;
> +
> +#include "fsl-lx2160a.dtsi"
> +
> +/ {
> +	model = "NXP Layerscape LX2160AQDS";
> +	compatible = "fsl,lx2160a-qds", "fsl,lx2160a";
> +
> +	chosen {
> +		stdout-path = "serial0:115200n8";
> +	};
> +};
> +
> +&uart0 {
> +	status = "okay";
> +};
> +
> +&uart1 {
> +	status = "okay";
> +};
> +
> +&i2c0 {

Sort these labeled nodes alphabetically, so that new additions can find
their place easier.

> +	status = "okay";

Have a newline between property list and child node.

Shawn

> +	i2c-mux at 77 {
> +		compatible = "nxp,pca9547";
> +		reg = <0x77>;
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +
> +		i2c at 2 {
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +			reg = <0x2>;
> +
> +			power-monitor at 40 {
> +				compatible = "ti,ina220";
> +				reg = <0x40>;
> +				shunt-resistor = <500>;
> +			};
> +
> +			power-monitor at 41 {
> +				compatible = "ti,ina220";
> +				reg = <0x41>;
> +				shunt-resistor = <1000>;
> +			};
> +		};
> +
> +		i2c at 3 {
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +			reg = <0x3>;
> +
> +			temperature-sensor at 4c {
> +				compatible = "nxp,sa56004";
> +				reg = <0x4c>;
> +			};
> +
> +			temperature-sensor at 4d {
> +				compatible = "nxp,sa56004";
> +				reg = <0x4d>;
> +			};
> +
> +			rtc at 51 {
> +				compatible = "nxp,pcf2129";
> +				reg = <0x51>;
> +			};
> +		};
> +	};
> +};
> +
> +&usb0 {
> +	status = "okay";
> +};
> +
> +&usb1 {
> +	status = "okay";
> +};
> +
> +&crypto {
> +	status = "okay";
> +};
> +
> -- 
> 2.17.1
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawnguo@kernel.org>
To: Pankaj Bansal <pankaj.bansal@nxp.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
	devicetree@vger.kernel.org,
	Yogesh Narayan Gaur <yogeshnarayan.gaur@nxp.com>,
	Li Yang <leoyang.li@nxp.com>, Rob Herring <robh+dt@kernel.org>,
	Vabhav Sharma <vabhav.sharma@nxp.com>,
	Sriram Dash <sriram.dash@nxp.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] arm64: dts: add LX2160AQDS board support
Date: Fri, 28 Sep 2018 17:00:32 +0800	[thread overview]
Message-ID: <20180928090030.GI26692@dragon> (raw)
In-Reply-To: <20180921141720.19159-1-pankaj.bansal@nxp.com>

On Fri, Sep 21, 2018 at 07:47:20PM +0530, Pankaj Bansal wrote:
> The LX2160A QorIQ Development System (QDS) is a test, evaluation, and
> development platform, supporting QorIQ LX2160A processor.
> 
> Signed-off-by: Sriram Dash <sriram.dash@nxp.com>
> Signed-off-by: Pankaj Bansal <pankaj.bansal@nxp.com>
> ---
> 
> Notes:
>     This patch is dependent on [1] and [2]
>      [1] https://lore.kernel.org/patchwork/patch/985935/
>      [2] https://lore.kernel.org/patchwork/patch/985938/

I did not receive these.

> 
>  arch/arm64/boot/dts/freescale/Makefile       |  1 +
>  .../boot/dts/freescale/fsl-lx2160a-qds.dts   | 88 ++++++++++++++++++
>  2 files changed, 89 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/freescale/Makefile
> index 445b72bd5a36..ae80fc5c45f7 100644
> --- a/arch/arm64/boot/dts/freescale/Makefile
> +++ b/arch/arm64/boot/dts/freescale/Makefile
> @@ -14,3 +14,4 @@ dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls2080a-simu.dtb
>  dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls2088a-qds.dtb
>  dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls2088a-rdb.dtb
>  dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-lx2160a-rdb.dtb
> +dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-lx2160a-qds.dtb

Please keep them in alphabetic order.

> diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a-qds.dts b/arch/arm64/boot/dts/freescale/fsl-lx2160a-qds.dts
> new file mode 100644
> index 000000000000..5cf2fe279f73
> --- /dev/null
> +++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a-qds.dts
> @@ -0,0 +1,88 @@
> +// SPDX-License-Identifier: (GPL-2.0 OR MIT)
> +//
> +// Device Tree file for LX2160AQDS
> +//
> +// Copyright 2018 NXP
> +
> +/dts-v1/;
> +
> +#include "fsl-lx2160a.dtsi"
> +
> +/ {
> +	model = "NXP Layerscape LX2160AQDS";
> +	compatible = "fsl,lx2160a-qds", "fsl,lx2160a";
> +
> +	chosen {
> +		stdout-path = "serial0:115200n8";
> +	};
> +};
> +
> +&uart0 {
> +	status = "okay";
> +};
> +
> +&uart1 {
> +	status = "okay";
> +};
> +
> +&i2c0 {

Sort these labeled nodes alphabetically, so that new additions can find
their place easier.

> +	status = "okay";

Have a newline between property list and child node.

Shawn

> +	i2c-mux@77 {
> +		compatible = "nxp,pca9547";
> +		reg = <0x77>;
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +
> +		i2c@2 {
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +			reg = <0x2>;
> +
> +			power-monitor@40 {
> +				compatible = "ti,ina220";
> +				reg = <0x40>;
> +				shunt-resistor = <500>;
> +			};
> +
> +			power-monitor@41 {
> +				compatible = "ti,ina220";
> +				reg = <0x41>;
> +				shunt-resistor = <1000>;
> +			};
> +		};
> +
> +		i2c@3 {
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +			reg = <0x3>;
> +
> +			temperature-sensor@4c {
> +				compatible = "nxp,sa56004";
> +				reg = <0x4c>;
> +			};
> +
> +			temperature-sensor@4d {
> +				compatible = "nxp,sa56004";
> +				reg = <0x4d>;
> +			};
> +
> +			rtc@51 {
> +				compatible = "nxp,pcf2129";
> +				reg = <0x51>;
> +			};
> +		};
> +	};
> +};
> +
> +&usb0 {
> +	status = "okay";
> +};
> +
> +&usb1 {
> +	status = "okay";
> +};
> +
> +&crypto {
> +	status = "okay";
> +};
> +
> -- 
> 2.17.1
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2018-09-28  9:00 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-21 14:17 [PATCH] arm64: dts: add LX2160AQDS board support Pankaj Bansal
2018-09-21 14:17 ` Pankaj Bansal
2018-09-28  9:00 ` Shawn Guo [this message]
2018-09-28  9:00   ` Shawn Guo
2018-09-28 19:20   ` Li Yang
2018-09-28 19:20     ` Li Yang
2018-09-29  1:54     ` Pankaj Bansal
2018-09-29  1:54       ` Pankaj Bansal
2018-10-05  8:10 ` [PATCH v2] " Pankaj Bansal
2018-10-05  8:10   ` Pankaj Bansal
2018-10-17 10:32   ` [PATCH v3] " Pankaj Bansal
2018-10-17 10:32     ` Pankaj Bansal
2018-10-19  4:16     ` Shawn Guo
2018-10-19  4:16       ` Shawn Guo
2018-10-22 20:58       ` Li Yang
2018-10-22 20:58         ` Li Yang
2018-10-31  6:27     ` Shawn Guo
2018-10-31  6:27       ` Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180928090030.GI26692@dragon \
    --to=shawnguo@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.