From: Christoph Hellwig <hch@lst.de>
To: Hannes Reinecke <hare@suse.de>
Cc: Christoph Hellwig <hch@lst.de>,
Bart van Assche <bvanassche@acm.org>,
Jens Axboe <axboe@kernel.dk>, Sagi Grimberg <sagi@grimberg.me>,
Keith Busch <keith.busch@intel.com>,
linux-block@vger.kernel.org, linux-nvme@lists.infradead.org,
Hannes Reinecke <hare@suse.com>
Subject: Re: [PATCH 2/5] nvme: register ns_id attributes as default sysfs groups
Date: Fri, 28 Sep 2018 17:17:32 +0200 [thread overview]
Message-ID: <20180928151732.GC8079@lst.de> (raw)
In-Reply-To: <20180928061723.13180-3-hare@suse.de>
On Fri, Sep 28, 2018 at 08:17:20AM +0200, Hannes Reinecke wrote:
> We should be registering the ns_id attribute as default sysfs
> attribute groups, otherwise we have a race condition between
> the uevent and the attributes appearing in sysfs.
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
WARNING: multiple messages have this Message-ID (diff)
From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH 2/5] nvme: register ns_id attributes as default sysfs groups
Date: Fri, 28 Sep 2018 17:17:32 +0200 [thread overview]
Message-ID: <20180928151732.GC8079@lst.de> (raw)
In-Reply-To: <20180928061723.13180-3-hare@suse.de>
On Fri, Sep 28, 2018@08:17:20AM +0200, Hannes Reinecke wrote:
> We should be registering the ns_id attribute as default sysfs
> attribute groups, otherwise we have a race condition between
> the uevent and the attributes appearing in sysfs.
Looks good,
Reviewed-by: Christoph Hellwig <hch at lst.de>
next prev parent reply other threads:[~2018-09-28 15:17 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-28 6:17 [PATCHv4 0/5] genhd: register default groups with device_add_disk() Hannes Reinecke
2018-09-28 6:17 ` Hannes Reinecke
2018-09-28 6:17 ` [PATCH 1/5] block: genhd: add 'groups' argument to device_add_disk Hannes Reinecke
2018-09-28 6:17 ` Hannes Reinecke
2018-09-28 6:17 ` [PATCH 2/5] nvme: register ns_id attributes as default sysfs groups Hannes Reinecke
2018-09-28 6:17 ` Hannes Reinecke
2018-09-28 14:15 ` Keith Busch
2018-09-28 14:15 ` Keith Busch
2018-09-28 15:17 ` Christoph Hellwig [this message]
2018-09-28 15:17 ` Christoph Hellwig
2018-09-28 6:17 ` [PATCH 3/5] aoe: register default groups with device_add_disk() Hannes Reinecke
2018-09-28 6:17 ` Hannes Reinecke
2018-09-28 6:17 ` [PATCH 4/5] zram: " Hannes Reinecke
2018-09-28 6:17 ` Hannes Reinecke
2018-09-28 6:17 ` [PATCH 5/5] virtio-blk: modernize sysfs attribute creation Hannes Reinecke
2018-09-28 6:17 ` Hannes Reinecke
2018-09-28 14:30 ` [PATCHv4 0/5] genhd: register default groups with device_add_disk() Jens Axboe
2018-09-28 14:30 ` Jens Axboe
-- strict thread matches above, loose matches on Subject: below --
2018-09-05 7:00 [PATCHv3 " Hannes Reinecke
2018-09-05 7:00 ` [PATCH 2/5] nvme: register ns_id attributes as default sysfs groups Hannes Reinecke
2018-09-05 7:00 ` Hannes Reinecke
2018-09-05 13:18 ` Christoph Hellwig
2018-09-05 13:18 ` Christoph Hellwig
2018-09-05 13:32 ` Hannes Reinecke
2018-09-05 13:32 ` Hannes Reinecke
2018-09-05 13:45 ` Christoph Hellwig
2018-09-05 13:45 ` Christoph Hellwig
2018-09-06 9:56 ` Hannes Reinecke
2018-09-06 9:56 ` Hannes Reinecke
2018-08-14 7:33 [PATCHv2 0/5] genhd: register default groups with device_add_disk() Hannes Reinecke
2018-08-14 7:33 ` [PATCH 2/5] nvme: register ns_id attributes as default sysfs groups Hannes Reinecke
2018-08-14 7:33 ` Hannes Reinecke
2018-08-14 9:03 ` Javier González
2018-08-14 9:03 ` Javier González
2018-08-14 9:59 ` Matias Bjørling
2018-08-14 9:59 ` Matias Bjørling
2018-08-14 15:20 ` Bart Van Assche
2018-08-14 15:20 ` Bart Van Assche
2018-08-14 15:20 ` Bart Van Assche
2018-08-14 15:39 ` Hannes Reinecke
2018-08-14 15:39 ` Hannes Reinecke
2018-08-14 15:44 ` Bart Van Assche
2018-08-14 15:44 ` Bart Van Assche
2018-08-14 15:44 ` Bart Van Assche
2018-08-17 7:00 ` hch
2018-08-17 7:00 ` hch
2018-08-17 7:53 ` Hannes Reinecke
2018-08-17 7:53 ` Hannes Reinecke
2018-08-17 20:04 ` Bart Van Assche
2018-08-17 20:04 ` Bart Van Assche
2018-08-17 20:04 ` Bart Van Assche
2018-08-17 22:47 ` Sagi Grimberg
2018-08-17 22:47 ` Sagi Grimberg
2018-08-20 6:34 ` Hannes Reinecke
2018-08-20 6:34 ` Hannes Reinecke
2018-08-14 21:53 ` kbuild test robot
2018-08-14 21:53 ` kbuild test robot
2018-08-17 6:55 ` Christoph Hellwig
2018-08-17 6:55 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180928151732.GC8079@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=hare@suse.com \
--cc=hare@suse.de \
--cc=keith.busch@intel.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.