All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Yangbo Lu <yangbo.lu@nxp.com>
Cc: linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org,
	netdev@vger.kernel.org,
	Richard Cochran <richardcochran@gmail.com>,
	"David S . Miller" <davem@davemloft.net>,
	Ioana Radulescu <ruxandra.radulescu@nxp.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [v2, 1/5] net: dpaa2: move DPAA2 PTP driver out of staging/
Date: Sat, 29 Sep 2018 21:46:16 +0200	[thread overview]
Message-ID: <20180929194616.GA11532@lunn.ch> (raw)
In-Reply-To: <20180929072645.20027-1-yangbo.lu@nxp.com>

> +++ b/drivers/net/ethernet/freescale/dpaa2/Kconfig
> @@ -0,0 +1,15 @@
> +config FSL_DPAA2_ETH
> +	tristate "Freescale DPAA2 Ethernet"
> +	depends on FSL_MC_BUS && FSL_MC_DPIO

Could you add in here COMPILE_TEST? 

> +	depends on NETDEVICES && ETHERNET

With the move out of staging, i don't think these two are required.

     Andrew

WARNING: multiple messages have this Message-ID (diff)
From: Andrew Lunn <andrew@lunn.ch>
To: Yangbo Lu <yangbo.lu@nxp.com>
Cc: devel@driverdev.osuosl.org, netdev@vger.kernel.org,
	Richard Cochran <richardcochran@gmail.com>,
	linux-kernel@vger.kernel.org,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	"David S . Miller" <davem@davemloft.net>
Subject: Re: [v2, 1/5] net: dpaa2: move DPAA2 PTP driver out of staging/
Date: Sat, 29 Sep 2018 21:46:16 +0200	[thread overview]
Message-ID: <20180929194616.GA11532@lunn.ch> (raw)
In-Reply-To: <20180929072645.20027-1-yangbo.lu@nxp.com>

> +++ b/drivers/net/ethernet/freescale/dpaa2/Kconfig
> @@ -0,0 +1,15 @@
> +config FSL_DPAA2_ETH
> +	tristate "Freescale DPAA2 Ethernet"
> +	depends on FSL_MC_BUS && FSL_MC_DPIO

Could you add in here COMPILE_TEST? 

> +	depends on NETDEVICES && ETHERNET

With the move out of staging, i don't think these two are required.

     Andrew

  parent reply	other threads:[~2018-09-29 19:46 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-29  7:26 [v2, 1/5] net: dpaa2: move DPAA2 PTP driver out of staging/ Yangbo Lu
2018-09-29  7:26 ` [v2, 2/5] MAINTAINERS: update files maintained under DPAA2 PTP/ETHERNET Yangbo Lu
2018-09-29  7:26 ` [v2, 3/5] net: dpaa2: rename rtc as ptp in dpaa2-ptp driver Yangbo Lu
2018-09-29  7:26 ` [v2, 4/5] net: dpaa2: remove unused code for dprtc Yangbo Lu
2018-09-29  7:26 ` [v2, 5/5] net: dpaa2: fix and improve dpaa2-ptp driver Yangbo Lu
2018-09-29 19:46 ` Andrew Lunn [this message]
2018-09-29 19:46   ` [v2, 1/5] net: dpaa2: move DPAA2 PTP driver out of staging/ Andrew Lunn
2018-10-08  3:11   ` Y.b. Lu
2018-10-08  3:11     ` Y.b. Lu
2018-10-08  7:50     ` Y.b. Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180929194616.GA11532@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=richardcochran@gmail.com \
    --cc=ruxandra.radulescu@nxp.com \
    --cc=yangbo.lu@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.