From: Martin Jansa <martin.jansa@gmail.com>
To: Armin Kuster <akuster808@gmail.com>
Cc: openembedded-devel@lists.openembedded.org
Subject: Re: [meta-multimedia][PATCH] mpd: fix yocto-check-layer issue with mulitmedia
Date: Sat, 29 Sep 2018 21:46:35 +0200 [thread overview]
Message-ID: <20180929194635.GC1449@jama> (raw)
In-Reply-To: <20180929193105.25864-1-akuster808@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2140 bytes --]
On Sat, Sep 29, 2018 at 12:31:05PM -0700, Armin Kuster wrote:
> ERROR: Nothing PROVIDES 'faad2' (but /home/akuster/oss/maint/meta-openembedded/meta-multimedia/recipes-multimedia/musicpd/mpd_0.20.21.bb DEPENDS on or otherwise requires it)
>
> enable aac only if LICENSE_FLAGS is commercial
>
> [v2]
> fix typo in commit message
> rebase on latest master
This belongs to cover later or under ---.
>
> Signed-off-by: Armin Kuster <akuster808@gmail.com>
> ---
> meta-multimedia/recipes-multimedia/musicpd/mpd_0.20.21.bb | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/meta-multimedia/recipes-multimedia/musicpd/mpd_0.20.21.bb b/meta-multimedia/recipes-multimedia/musicpd/mpd_0.20.21.bb
> index 9123673fb..f91ce4d62 100644
> --- a/meta-multimedia/recipes-multimedia/musicpd/mpd_0.20.21.bb
> +++ b/meta-multimedia/recipes-multimedia/musicpd/mpd_0.20.21.bb
> @@ -26,7 +26,8 @@ S = "${WORKDIR}/git"
> EXTRA_OECONF = "enable_bzip2=yes"
> EXTRA_OECONF += "${@bb.utils.contains('DISTRO_FEATURES', 'systemd', '--with-systemdsystemunitdir=${systemd_unitdir}/system/', '--without-systemdsystemunitdir', d)}"
>
> -PACKAGECONFIG ??= "aac alsa ao bzip2 daemon ffmpeg fifo flac fluidsynth iso9660 jack libsamplerate libwrap httpd mms mpg123 modplug sndfile upnp openal opus oss recorder vorbis wavpack zlib"
> +PACKAGECONFIG ??= "alsa ao bzip2 ffmpeg flac fluidsynth iso9660 jack libsamplerate mms mpg123 modplug sndfile upnp openal opus vorbis wavpack zlib"
> +PACKAGECONFIG += "${@bb.utils.contains('LICENSE_FLAGS', 'commercial', 'aac', '', d)}"
This removes much more than just aac now.
Why did you remove daemon, fifo, libwrap, httpd, oss, recorder, vorbis?
>
> PACKAGECONFIG[aac] = "--enable-aac,--disable-aac,faad2"
> PACKAGECONFIG[alsa] = "--enable-alsa,--disable-alsa,alsa-lib"
> --
> 2.17.1
>
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
--
Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 201 bytes --]
next prev parent reply other threads:[~2018-09-29 19:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-29 19:31 [meta-multimedia][PATCH] mpd: fix yocto-check-layer issue with mulitmedia Armin Kuster
2018-09-29 19:46 ` Martin Jansa [this message]
2018-09-29 20:16 ` akuster808
2018-09-30 5:54 ` Martin Jansa
2018-09-30 6:04 ` Khem Raj
2018-09-30 6:10 ` Martin Jansa
2018-09-30 14:50 ` Khem Raj
-- strict thread matches above, loose matches on Subject: below --
2018-09-29 18:10 Armin Kuster
2018-09-29 18:15 ` Martin Jansa
2018-09-29 18:46 ` Khem Raj
2018-09-29 19:28 ` akuster808
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180929194635.GC1449@jama \
--to=martin.jansa@gmail.com \
--cc=akuster808@gmail.com \
--cc=openembedded-devel@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.