[meta-multimedia][PATCH] mpd: fix yocto-check-layer issue with mulitmedia

[meta-multimedia][PATCH] mpd: fix yocto-check-layer issue with mulitmedia

[Armin Kuster]

ERROR: Nothing PROVIDES 'faad2' (but /home/akuster/oss/maint/meta-openembedded/meta-multimedia/recipes-multimedia/musicpd/mpd_0.20.21.bb DEPENDS on or otherwise requires it)

enable acc only if LICENSE_FLAGS is commercial

Signed-off-by: Armin Kuster <akuster808@gmail.com>
---
 meta-multimedia/recipes-multimedia/musicpd/mpd_0.20.21.bb | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/meta-multimedia/recipes-multimedia/musicpd/mpd_0.20.21.bb b/meta-multimedia/recipes-multimedia/musicpd/mpd_0.20.21.bb
index c0d4c8c2b..aee9e0769 100644
--- a/meta-multimedia/recipes-multimedia/musicpd/mpd_0.20.21.bb
+++ b/meta-multimedia/recipes-multimedia/musicpd/mpd_0.20.21.bb
@@ -27,7 +27,8 @@ SRC_URI[sha256sum] = "8322764dc265c20f05c8c8fdfdd578b0722e74626bef56fcd8eebfb01a
 EXTRA_OECONF = "enable_bzip2=yes"
 EXTRA_OECONF += "${@bb.utils.contains('DISTRO_FEATURES', 'systemd', '--with-systemdsystemunitdir=${systemd_unitdir}/system/', '--without-systemdsystemunitdir', d)}"
 
-PACKAGECONFIG ??= "aac alsa ao bzip2 ffmpeg flac fluidsynth iso9660 jack libsamplerate mms mpg123 modplug sndfile upnp openal opus vorbis wavpack zlib"
+PACKAGECONFIG ??= "alsa ao bzip2 ffmpeg flac fluidsynth iso9660 jack libsamplerate mms mpg123 modplug sndfile upnp openal opus vorbis wavpack zlib"
+PACKAGECONFIG += "${@bb.utils.contains('LICENSE_FLAGS', 'commercial', 'aac', '', d)}"
 
 PACKAGECONFIG[aac] = "--enable-aac,--disable-aac,faad2"
 PACKAGECONFIG[alsa] = "--enable-alsa,--disable-alsa,alsa-lib"
-- 
2.17.1

Re: [meta-multimedia][PATCH] mpd: fix yocto-check-layer issue with mulitmedia

[Martin Jansa]

[-- Attachment #1: Type: text/plain, Size: 1928 bytes --]

On Sat, Sep 29, 2018 at 11:10:29AM -0700, Armin Kuster wrote:
> ERROR: Nothing PROVIDES 'faad2' (but /home/akuster/oss/maint/meta-openembedded/meta-multimedia/recipes-multimedia/musicpd/mpd_0.20.21.bb DEPENDS on or otherwise requires it)
> 
> enable acc only if LICENSE_FLAGS is commercial

aac

> Signed-off-by: Armin Kuster <akuster808@gmail.com>
> ---
>  meta-multimedia/recipes-multimedia/musicpd/mpd_0.20.21.bb | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/meta-multimedia/recipes-multimedia/musicpd/mpd_0.20.21.bb b/meta-multimedia/recipes-multimedia/musicpd/mpd_0.20.21.bb
> index c0d4c8c2b..aee9e0769 100644
> --- a/meta-multimedia/recipes-multimedia/musicpd/mpd_0.20.21.bb
> +++ b/meta-multimedia/recipes-multimedia/musicpd/mpd_0.20.21.bb
> @@ -27,7 +27,8 @@ SRC_URI[sha256sum] = "8322764dc265c20f05c8c8fdfdd578b0722e74626bef56fcd8eebfb01a
>  EXTRA_OECONF = "enable_bzip2=yes"
>  EXTRA_OECONF += "${@bb.utils.contains('DISTRO_FEATURES', 'systemd', '--with-systemdsystemunitdir=${systemd_unitdir}/system/', '--without-systemdsystemunitdir', d)}"
>  
> -PACKAGECONFIG ??= "aac alsa ao bzip2 ffmpeg flac fluidsynth iso9660 jack libsamplerate mms mpg123 modplug sndfile upnp openal opus vorbis wavpack zlib"
> +PACKAGECONFIG ??= "alsa ao bzip2 ffmpeg flac fluidsynth iso9660 jack libsamplerate mms mpg123 modplug sndfile upnp openal opus vorbis wavpack zlib"
> +PACKAGECONFIG += "${@bb.utils.contains('LICENSE_FLAGS', 'commercial', 'aac', '', d)}"
>  
>  PACKAGECONFIG[aac] = "--enable-aac,--disable-aac,faad2"
>  PACKAGECONFIG[alsa] = "--enable-alsa,--disable-alsa,alsa-lib"
> -- 
> 2.17.1
> 
> -- 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 201 bytes --]

Re: [meta-multimedia][PATCH] mpd: fix yocto-check-layer issue with mulitmedia

[Khem Raj]

v2 needs to be rebased on top of master as well.
On Sat, Sep 29, 2018 at 11:15 AM Martin Jansa <martin.jansa@gmail.com> wrote:
>
> On Sat, Sep 29, 2018 at 11:10:29AM -0700, Armin Kuster wrote:
> > ERROR: Nothing PROVIDES 'faad2' (but /home/akuster/oss/maint/meta-openembedded/meta-multimedia/recipes-multimedia/musicpd/mpd_0.20.21.bb DEPENDS on or otherwise requires it)
> >
> > enable acc only if LICENSE_FLAGS is commercial
>
> aac
>
> > Signed-off-by: Armin Kuster <akuster808@gmail.com>
> > ---
> >  meta-multimedia/recipes-multimedia/musicpd/mpd_0.20.21.bb | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/meta-multimedia/recipes-multimedia/musicpd/mpd_0.20.21.bb b/meta-multimedia/recipes-multimedia/musicpd/mpd_0.20.21.bb
> > index c0d4c8c2b..aee9e0769 100644
> > --- a/meta-multimedia/recipes-multimedia/musicpd/mpd_0.20.21.bb
> > +++ b/meta-multimedia/recipes-multimedia/musicpd/mpd_0.20.21.bb
> > @@ -27,7 +27,8 @@ SRC_URI[sha256sum] = "8322764dc265c20f05c8c8fdfdd578b0722e74626bef56fcd8eebfb01a
> >  EXTRA_OECONF = "enable_bzip2=yes"
> >  EXTRA_OECONF += "${@bb.utils.contains('DISTRO_FEATURES', 'systemd', '--with-systemdsystemunitdir=${systemd_unitdir}/system/', '--without-systemdsystemunitdir', d)}"
> >
> > -PACKAGECONFIG ??= "aac alsa ao bzip2 ffmpeg flac fluidsynth iso9660 jack libsamplerate mms mpg123 modplug sndfile upnp openal opus vorbis wavpack zlib"
> > +PACKAGECONFIG ??= "alsa ao bzip2 ffmpeg flac fluidsynth iso9660 jack libsamplerate mms mpg123 modplug sndfile upnp openal opus vorbis wavpack zlib"
> > +PACKAGECONFIG += "${@bb.utils.contains('LICENSE_FLAGS', 'commercial', 'aac', '', d)}"
> >
> >  PACKAGECONFIG[aac] = "--enable-aac,--disable-aac,faad2"
> >  PACKAGECONFIG[alsa] = "--enable-alsa,--disable-alsa,alsa-lib"
> > --
> > 2.17.1
> >
> > --
> > _______________________________________________
> > Openembedded-devel mailing list
> > Openembedded-devel@lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>
> --
> Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel

Re: [meta-multimedia][PATCH] mpd: fix yocto-check-layer issue with mulitmedia

[akuster808]

On 09/29/2018 11:46 AM, Khem Raj wrote:
> v2 needs to be rebased on top of master as well.

sure.. I did have an updated mater but on a different system so the
brain marked that task as done.

- armin
> On Sat, Sep 29, 2018 at 11:15 AM Martin Jansa <martin.jansa@gmail.com> wrote:
>> On Sat, Sep 29, 2018 at 11:10:29AM -0700, Armin Kuster wrote:
>>> ERROR: Nothing PROVIDES 'faad2' (but /home/akuster/oss/maint/meta-openembedded/meta-multimedia/recipes-multimedia/musicpd/mpd_0.20.21.bb DEPENDS on or otherwise requires it)
>>>
>>> enable acc only if LICENSE_FLAGS is commercial
>> aac
>>
>>> Signed-off-by: Armin Kuster <akuster808@gmail.com>
>>> ---
>>>  meta-multimedia/recipes-multimedia/musicpd/mpd_0.20.21.bb | 3 ++-
>>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/meta-multimedia/recipes-multimedia/musicpd/mpd_0.20.21.bb b/meta-multimedia/recipes-multimedia/musicpd/mpd_0.20.21.bb
>>> index c0d4c8c2b..aee9e0769 100644
>>> --- a/meta-multimedia/recipes-multimedia/musicpd/mpd_0.20.21.bb
>>> +++ b/meta-multimedia/recipes-multimedia/musicpd/mpd_0.20.21.bb
>>> @@ -27,7 +27,8 @@ SRC_URI[sha256sum] = "8322764dc265c20f05c8c8fdfdd578b0722e74626bef56fcd8eebfb01a
>>>  EXTRA_OECONF = "enable_bzip2=yes"
>>>  EXTRA_OECONF += "${@bb.utils.contains('DISTRO_FEATURES', 'systemd', '--with-systemdsystemunitdir=${systemd_unitdir}/system/', '--without-systemdsystemunitdir', d)}"
>>>
>>> -PACKAGECONFIG ??= "aac alsa ao bzip2 ffmpeg flac fluidsynth iso9660 jack libsamplerate mms mpg123 modplug sndfile upnp openal opus vorbis wavpack zlib"
>>> +PACKAGECONFIG ??= "alsa ao bzip2 ffmpeg flac fluidsynth iso9660 jack libsamplerate mms mpg123 modplug sndfile upnp openal opus vorbis wavpack zlib"
>>> +PACKAGECONFIG += "${@bb.utils.contains('LICENSE_FLAGS', 'commercial', 'aac', '', d)}"
>>>
>>>  PACKAGECONFIG[aac] = "--enable-aac,--disable-aac,faad2"
>>>  PACKAGECONFIG[alsa] = "--enable-alsa,--disable-alsa,alsa-lib"
>>> --
>>> 2.17.1
>>>
>>> --
>>> _______________________________________________
>>> Openembedded-devel mailing list
>>> Openembedded-devel@lists.openembedded.org
>>> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>> --
>> Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com
>> --
>> _______________________________________________
>> Openembedded-devel mailing list
>> Openembedded-devel@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-devel

[meta-multimedia][PATCH] mpd: fix yocto-check-layer issue with mulitmedia

[Armin Kuster]

ERROR: Nothing PROVIDES 'faad2' (but /home/akuster/oss/maint/meta-openembedded/meta-multimedia/recipes-multimedia/musicpd/mpd_0.20.21.bb DEPENDS on or otherwise requires it)

enable aac only if LICENSE_FLAGS is commercial

[v2]
fix typo in commit message
rebase on latest master

Signed-off-by: Armin Kuster <akuster808@gmail.com>
---
 meta-multimedia/recipes-multimedia/musicpd/mpd_0.20.21.bb | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/meta-multimedia/recipes-multimedia/musicpd/mpd_0.20.21.bb b/meta-multimedia/recipes-multimedia/musicpd/mpd_0.20.21.bb
index 9123673fb..f91ce4d62 100644
--- a/meta-multimedia/recipes-multimedia/musicpd/mpd_0.20.21.bb
+++ b/meta-multimedia/recipes-multimedia/musicpd/mpd_0.20.21.bb
@@ -26,7 +26,8 @@ S = "${WORKDIR}/git"
 EXTRA_OECONF = "enable_bzip2=yes"
 EXTRA_OECONF += "${@bb.utils.contains('DISTRO_FEATURES', 'systemd', '--with-systemdsystemunitdir=${systemd_unitdir}/system/', '--without-systemdsystemunitdir', d)}"
 
-PACKAGECONFIG ??= "aac alsa ao bzip2 daemon ffmpeg fifo flac fluidsynth iso9660 jack libsamplerate libwrap httpd mms mpg123 modplug sndfile upnp openal opus oss recorder vorbis wavpack zlib"
+PACKAGECONFIG ??= "alsa ao bzip2 ffmpeg flac fluidsynth iso9660 jack libsamplerate mms mpg123 modplug sndfile upnp openal opus vorbis wavpack zlib"
+PACKAGECONFIG += "${@bb.utils.contains('LICENSE_FLAGS', 'commercial', 'aac', '', d)}"
 
 PACKAGECONFIG[aac] = "--enable-aac,--disable-aac,faad2"
 PACKAGECONFIG[alsa] = "--enable-alsa,--disable-alsa,alsa-lib"
-- 
2.17.1

Re: [meta-multimedia][PATCH] mpd: fix yocto-check-layer issue with mulitmedia

[Martin Jansa]

[-- Attachment #1: Type: text/plain, Size: 2140 bytes --]

On Sat, Sep 29, 2018 at 12:31:05PM -0700, Armin Kuster wrote:
> ERROR: Nothing PROVIDES 'faad2' (but /home/akuster/oss/maint/meta-openembedded/meta-multimedia/recipes-multimedia/musicpd/mpd_0.20.21.bb DEPENDS on or otherwise requires it)
> 
> enable aac only if LICENSE_FLAGS is commercial
> 
> [v2]
> fix typo in commit message
> rebase on latest master

This belongs to cover later or under ---.

> 
> Signed-off-by: Armin Kuster <akuster808@gmail.com>
> ---
>  meta-multimedia/recipes-multimedia/musicpd/mpd_0.20.21.bb | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/meta-multimedia/recipes-multimedia/musicpd/mpd_0.20.21.bb b/meta-multimedia/recipes-multimedia/musicpd/mpd_0.20.21.bb
> index 9123673fb..f91ce4d62 100644
> --- a/meta-multimedia/recipes-multimedia/musicpd/mpd_0.20.21.bb
> +++ b/meta-multimedia/recipes-multimedia/musicpd/mpd_0.20.21.bb
> @@ -26,7 +26,8 @@ S = "${WORKDIR}/git"
>  EXTRA_OECONF = "enable_bzip2=yes"
>  EXTRA_OECONF += "${@bb.utils.contains('DISTRO_FEATURES', 'systemd', '--with-systemdsystemunitdir=${systemd_unitdir}/system/', '--without-systemdsystemunitdir', d)}"
>  
> -PACKAGECONFIG ??= "aac alsa ao bzip2 daemon ffmpeg fifo flac fluidsynth iso9660 jack libsamplerate libwrap httpd mms mpg123 modplug sndfile upnp openal opus oss recorder vorbis wavpack zlib"
> +PACKAGECONFIG ??= "alsa ao bzip2 ffmpeg flac fluidsynth iso9660 jack libsamplerate mms mpg123 modplug sndfile upnp openal opus vorbis wavpack zlib"
> +PACKAGECONFIG += "${@bb.utils.contains('LICENSE_FLAGS', 'commercial', 'aac', '', d)}"

This removes much more than just aac now.

Why did you remove daemon, fifo, libwrap, httpd, oss, recorder, vorbis?

>  
>  PACKAGECONFIG[aac] = "--enable-aac,--disable-aac,faad2"
>  PACKAGECONFIG[alsa] = "--enable-alsa,--disable-alsa,alsa-lib"
> -- 
> 2.17.1
> 
> -- 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 201 bytes --]

Re: [meta-multimedia][PATCH] mpd: fix yocto-check-layer issue with mulitmedia

[akuster808]

[-- Attachment #1.1.1: Type: text/plain, Size: 2896 bytes --]



On 09/29/2018 12:46 PM, Martin Jansa wrote:
> On Sat, Sep 29, 2018 at 12:31:05PM -0700, Armin Kuster wrote:
>> ERROR: Nothing PROVIDES 'faad2' (but /home/akuster/oss/maint/meta-openembedded/meta-multimedia/recipes-multimedia/musicpd/mpd_0.20.21.bb DEPENDS on or otherwise requires it)
>>
>> enable aac only if LICENSE_FLAGS is commercial
>>
>> [v2]
>> fix typo in commit message
>> rebase on latest master
> This belongs to cover later or under ---.
I failed to have a [V2] in the subject.  I guess a V3 is inorder for that.

Can you point me to the doc that says where a [v2] comments in a git
header should be. I can not find it. I seem to be reminded that when I
do revisions I am doing them wrong.

I don't see reference to this policy:
https://www.openembedded.org/wiki/Styleguide#Patches
https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines
https://www.kernel.org/doc/html/latest/process/submitting-patches.html

per kernel process:
"The |---| marker line serves the essential purpose of marking for patch
handling tools where the changelog message ends."
Are you saying I should violate that?

is there somewhere else I should be looking?

- armin

>
>> Signed-off-by: Armin Kuster <akuster808@gmail.com>
>> ---
>>  meta-multimedia/recipes-multimedia/musicpd/mpd_0.20.21.bb | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/meta-multimedia/recipes-multimedia/musicpd/mpd_0.20.21.bb b/meta-multimedia/recipes-multimedia/musicpd/mpd_0.20.21.bb
>> index 9123673fb..f91ce4d62 100644
>> --- a/meta-multimedia/recipes-multimedia/musicpd/mpd_0.20.21.bb
>> +++ b/meta-multimedia/recipes-multimedia/musicpd/mpd_0.20.21.bb
>> @@ -26,7 +26,8 @@ S = "${WORKDIR}/git"
>>  EXTRA_OECONF = "enable_bzip2=yes"
>>  EXTRA_OECONF += "${@bb.utils.contains('DISTRO_FEATURES', 'systemd', '--with-systemdsystemunitdir=${systemd_unitdir}/system/', '--without-systemdsystemunitdir', d)}"
>>
>> -PACKAGECONFIG ??= "aac alsa ao bzip2 daemon ffmpeg fifo flac fluidsynth iso9660 jack libsamplerate libwrap httpd mms mpg123 modplug sndfile upnp openal opus oss recorder vorbis wavpack zlib"
>> +PACKAGECONFIG ??= "alsa ao bzip2 ffmpeg flac fluidsynth iso9660 jack libsamplerate mms mpg123 modplug sndfile upnp openal opus vorbis wavpack zlib"
>> +PACKAGECONFIG += "${@bb.utils.contains('LICENSE_FLAGS', 'commercial', 'aac', '', d)}"
> This removes much more than just aac now.
>
> Why did you remove daemon, fifo, libwrap, httpd, oss, recorder, vorbis?
>
>>
>>  PACKAGECONFIG[aac] = "--enable-aac,--disable-aac,faad2"
>>  PACKAGECONFIG[alsa] = "--enable-alsa,--disable-alsa,alsa-lib"
>> -- 
>> 2.17.1
>>
>> -- 
>> _______________________________________________
>> Openembedded-devel mailing list
>> Openembedded-devel@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-devel


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [meta-multimedia][PATCH] mpd: fix yocto-check-layer issue with mulitmedia

[Martin Jansa]

https://www.kernel.org/doc/html/latest/process/submitting-patches.html

The --- marker line serves the essential purpose of marking for patch
handling tools where the changelog message ends.

One good use for the additional comments after the --- marker is for a
diffstat, to show what files have changed, and the number of inserted and
deleted lines per file. A diffstat is especially useful on bigger patches.
Other comments relevant only to the moment or the maintainer, not suitable
for the permanent changelog, should also go here. A good example of such
comments might be patch changelogs which describe what has changed between
the v1 and v2 version of the patch.


On Sat, Sep 29, 2018 at 10:16 PM akuster808 <akuster808@gmail.com> wrote:

>
>
> On 09/29/2018 12:46 PM, Martin Jansa wrote:
>
> On Sat, Sep 29, 2018 at 12:31:05PM -0700, Armin Kuster wrote:
>
> ERROR: Nothing PROVIDES 'faad2' (but /home/akuster/oss/maint/meta-openembedded/meta-multimedia/recipes-multimedia/musicpd/mpd_0.20.21.bb DEPENDS on or otherwise requires it)
>
> enable aac only if LICENSE_FLAGS is commercial
>
> [v2]
> fix typo in commit message
> rebase on latest master
>
>
> This belongs to cover later or under ---.
>
> I failed to have a [V2] in the subject.  I guess a V3 is inorder for that.
>
> Can you point me to the doc that says where a [v2] comments in a git
> header should be. I can not find it. I seem to be reminded that when I do
> revisions I am doing them wrong.
>
> I don't see reference to this policy:
> https://www.openembedded.org/wiki/Styleguide#Patches
> https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines
> https://www.kernel.org/doc/html/latest/process/submitting-patches.html
>
> per kernel process:
> "The --- marker line serves the essential purpose of marking for patch
> handling tools where the changelog message ends."
> Are you saying I should violate that?
>
> is there somewhere else I should be looking?
>
> - armin
>
>
>
> Signed-off-by: Armin Kuster <akuster808@gmail.com> <akuster808@gmail.com>
> ---
>  meta-multimedia/recipes-multimedia/musicpd/mpd_0.20.21.bb | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/meta-multimedia/recipes-multimedia/musicpd/mpd_0.20.21.bb b/meta-multimedia/recipes-multimedia/musicpd/mpd_0.20.21.bb
> index 9123673fb..f91ce4d62 100644
> --- a/meta-multimedia/recipes-multimedia/musicpd/mpd_0.20.21.bb
> +++ b/meta-multimedia/recipes-multimedia/musicpd/mpd_0.20.21.bb
> @@ -26,7 +26,8 @@ S = "${WORKDIR}/git"
>  EXTRA_OECONF = "enable_bzip2=yes"
>  EXTRA_OECONF += "${@bb.utils.contains('DISTRO_FEATURES', 'systemd', '--with-systemdsystemunitdir=${systemd_unitdir}/system/', '--without-systemdsystemunitdir', d)}" <$%7B@bb.utils.contains('DISTRO_FEATURES','systemd','--with-systemdsystemunitdir=$%7Bsystemd_unitdir%7D/system/','--without-systemdsystemunitdir',d)%7D>
>
> -PACKAGECONFIG ??= "aac alsa ao bzip2 daemon ffmpeg fifo flac fluidsynth iso9660 jack libsamplerate libwrap httpd mms mpg123 modplug sndfile upnp openal opus oss recorder vorbis wavpack zlib"
> +PACKAGECONFIG ??= "alsa ao bzip2 ffmpeg flac fluidsynth iso9660 jack libsamplerate mms mpg123 modplug sndfile upnp openal opus vorbis wavpack zlib"
> +PACKAGECONFIG += "${@bb.utils.contains('LICENSE_FLAGS', 'commercial', 'aac', '', d)}" <$%7B@bb.utils.contains('LICENSE_FLAGS','commercial','aac','',d)%7D>
>
>
> This removes much more than just aac now.
>
> Why did you remove daemon, fifo, libwrap, httpd, oss, recorder, vorbis?
>
>
>
>  PACKAGECONFIG[aac] = "--enable-aac,--disable-aac,faad2"
>  PACKAGECONFIG[alsa] = "--enable-alsa,--disable-alsa,alsa-lib"
> --
> 2.17.1
>
> --
> _______________________________________________
> Openembedded-devel mailing listOpenembedded-devel@lists.openembedded.orghttp://lists.openembedded.org/mailman/listinfo/openembedded-devel
>
>
>

Re: [meta-multimedia][PATCH] mpd: fix yocto-check-layer issue with mulitmedia

[Khem Raj]

On Sat, Sep 29, 2018 at 10:55 PM Martin Jansa <martin.jansa@gmail.com> wrote:
>
> https://www.kernel.org/doc/html/latest/process/submitting-patches.html
>
> The --- marker line serves the essential purpose of marking for patch
> handling tools where the changelog message ends.
>
> One good use for the additional comments after the --- marker is for a
> diffstat, to show what files have changed, and the number of inserted and
> deleted lines per file. A diffstat is especially useful on bigger patches.
> Other comments relevant only to the moment or the maintainer, not suitable
> for the permanent changelog, should also go here. A good example of such
> comments might be patch changelogs which describe what has changed between
> the v1 and v2 version of the patch.
>

yeah, i have fixed it locally no need for next rev
>
> On Sat, Sep 29, 2018 at 10:16 PM akuster808 <akuster808@gmail.com> wrote:
>
> >
> >
> > On 09/29/2018 12:46 PM, Martin Jansa wrote:
> >
> > On Sat, Sep 29, 2018 at 12:31:05PM -0700, Armin Kuster wrote:
> >
> > ERROR: Nothing PROVIDES 'faad2' (but /home/akuster/oss/maint/meta-openembedded/meta-multimedia/recipes-multimedia/musicpd/mpd_0.20.21.bb DEPENDS on or otherwise requires it)
> >
> > enable aac only if LICENSE_FLAGS is commercial
> >
> > [v2]
> > fix typo in commit message
> > rebase on latest master
> >
> >
> > This belongs to cover later or under ---.
> >
> > I failed to have a [V2] in the subject.  I guess a V3 is inorder for that.
> >
> > Can you point me to the doc that says where a [v2] comments in a git
> > header should be. I can not find it. I seem to be reminded that when I do
> > revisions I am doing them wrong.
> >
> > I don't see reference to this policy:
> > https://www.openembedded.org/wiki/Styleguide#Patches
> > https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines
> > https://www.kernel.org/doc/html/latest/process/submitting-patches.html
> >
> > per kernel process:
> > "The --- marker line serves the essential purpose of marking for patch
> > handling tools where the changelog message ends."
> > Are you saying I should violate that?
> >
> > is there somewhere else I should be looking?
> >
> > - armin
> >
> >
> >
> > Signed-off-by: Armin Kuster <akuster808@gmail.com> <akuster808@gmail.com>
> > ---
> >  meta-multimedia/recipes-multimedia/musicpd/mpd_0.20.21.bb | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/meta-multimedia/recipes-multimedia/musicpd/mpd_0.20.21.bb b/meta-multimedia/recipes-multimedia/musicpd/mpd_0.20.21.bb
> > index 9123673fb..f91ce4d62 100644
> > --- a/meta-multimedia/recipes-multimedia/musicpd/mpd_0.20.21.bb
> > +++ b/meta-multimedia/recipes-multimedia/musicpd/mpd_0.20.21.bb
> > @@ -26,7 +26,8 @@ S = "${WORKDIR}/git"
> >  EXTRA_OECONF = "enable_bzip2=yes"
> >  EXTRA_OECONF += "${@bb.utils.contains('DISTRO_FEATURES', 'systemd', '--with-systemdsystemunitdir=${systemd_unitdir}/system/', '--without-systemdsystemunitdir', d)}" <$%7B@bb.utils.contains('DISTRO_FEATURES','systemd','--with-systemdsystemunitdir=$%7Bsystemd_unitdir%7D/system/','--without-systemdsystemunitdir',d)%7D>
> >
> > -PACKAGECONFIG ??= "aac alsa ao bzip2 daemon ffmpeg fifo flac fluidsynth iso9660 jack libsamplerate libwrap httpd mms mpg123 modplug sndfile upnp openal opus oss recorder vorbis wavpack zlib"
> > +PACKAGECONFIG ??= "alsa ao bzip2 ffmpeg flac fluidsynth iso9660 jack libsamplerate mms mpg123 modplug sndfile upnp openal opus vorbis wavpack zlib"
> > +PACKAGECONFIG += "${@bb.utils.contains('LICENSE_FLAGS', 'commercial', 'aac', '', d)}" <$%7B@bb.utils.contains('LICENSE_FLAGS','commercial','aac','',d)%7D>
> >
> >
> > This removes much more than just aac now.
> >
> > Why did you remove daemon, fifo, libwrap, httpd, oss, recorder, vorbis?
> >
> >
> >
> >  PACKAGECONFIG[aac] = "--enable-aac,--disable-aac,faad2"
> >  PACKAGECONFIG[alsa] = "--enable-alsa,--disable-alsa,alsa-lib"
> > --
> > 2.17.1
> >
> > --
> > _______________________________________________
> > Openembedded-devel mailing listOpenembedded-devel@lists.openembedded.orghttp://lists.openembedded.org/mailman/listinfo/openembedded-devel
> >
> >
> >
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel

Re: [meta-multimedia][PATCH] mpd: fix yocto-check-layer issue with mulitmedia

[Martin Jansa]

[-- Attachment #1: Type: text/plain, Size: 5173 bytes --]

On Sat, Sep 29, 2018 at 11:04:11PM -0700, Khem Raj wrote:
> On Sat, Sep 29, 2018 at 10:55 PM Martin Jansa <martin.jansa@gmail.com> wrote:
> >
> > https://www.kernel.org/doc/html/latest/process/submitting-patches.html
> >
> > The --- marker line serves the essential purpose of marking for patch
> > handling tools where the changelog message ends.
> >
> > One good use for the additional comments after the --- marker is for a
> > diffstat, to show what files have changed, and the number of inserted and
> > deleted lines per file. A diffstat is especially useful on bigger patches.
> > Other comments relevant only to the moment or the maintainer, not suitable
> > for the permanent changelog, should also go here. A good example of such
> > comments might be patch changelogs which describe what has changed between
> > the v1 and v2 version of the patch.
> >
> 
> yeah, i have fixed it locally no need for next rev

Only the commit message, right?

Because the PACKAGECONFIG is still incorrect in:
http://cgit.openembedded.org/meta-openembedded-contrib/commit/?h=yoe/mut&id=14a9f80296aa0141ea9a065439970f8fc1e0c36b

There is also typo in the subject and
"mpd: enable aac PACKAGECONFIG only with commercial LICENSE_FLAGS

* fix yocto-check-layer issue with multimedia"

would be better commit message IMHO.

> >
> > On Sat, Sep 29, 2018 at 10:16 PM akuster808 <akuster808@gmail.com> wrote:
> >
> > >
> > >
> > > On 09/29/2018 12:46 PM, Martin Jansa wrote:
> > >
> > > On Sat, Sep 29, 2018 at 12:31:05PM -0700, Armin Kuster wrote:
> > >
> > > ERROR: Nothing PROVIDES 'faad2' (but /home/akuster/oss/maint/meta-openembedded/meta-multimedia/recipes-multimedia/musicpd/mpd_0.20.21.bb DEPENDS on or otherwise requires it)
> > >
> > > enable aac only if LICENSE_FLAGS is commercial
> > >
> > > [v2]
> > > fix typo in commit message
> > > rebase on latest master
> > >
> > >
> > > This belongs to cover later or under ---.
> > >
> > > I failed to have a [V2] in the subject.  I guess a V3 is inorder for that.
> > >
> > > Can you point me to the doc that says where a [v2] comments in a git
> > > header should be. I can not find it. I seem to be reminded that when I do
> > > revisions I am doing them wrong.
> > >
> > > I don't see reference to this policy:
> > > https://www.openembedded.org/wiki/Styleguide#Patches
> > > https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines
> > > https://www.kernel.org/doc/html/latest/process/submitting-patches.html
> > >
> > > per kernel process:
> > > "The --- marker line serves the essential purpose of marking for patch
> > > handling tools where the changelog message ends."
> > > Are you saying I should violate that?
> > >
> > > is there somewhere else I should be looking?
> > >
> > > - armin
> > >
> > >
> > >
> > > Signed-off-by: Armin Kuster <akuster808@gmail.com> <akuster808@gmail.com>
> > > ---
> > >  meta-multimedia/recipes-multimedia/musicpd/mpd_0.20.21.bb | 3 ++-
> > >  1 file changed, 2 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/meta-multimedia/recipes-multimedia/musicpd/mpd_0.20.21.bb b/meta-multimedia/recipes-multimedia/musicpd/mpd_0.20.21.bb
> > > index 9123673fb..f91ce4d62 100644
> > > --- a/meta-multimedia/recipes-multimedia/musicpd/mpd_0.20.21.bb
> > > +++ b/meta-multimedia/recipes-multimedia/musicpd/mpd_0.20.21.bb
> > > @@ -26,7 +26,8 @@ S = "${WORKDIR}/git"
> > >  EXTRA_OECONF = "enable_bzip2=yes"
> > >  EXTRA_OECONF += "${@bb.utils.contains('DISTRO_FEATURES', 'systemd', '--with-systemdsystemunitdir=${systemd_unitdir}/system/', '--without-systemdsystemunitdir', d)}" <$%7B@bb.utils.contains('DISTRO_FEATURES','systemd','--with-systemdsystemunitdir=$%7Bsystemd_unitdir%7D/system/','--without-systemdsystemunitdir',d)%7D>
> > >
> > > -PACKAGECONFIG ??= "aac alsa ao bzip2 daemon ffmpeg fifo flac fluidsynth iso9660 jack libsamplerate libwrap httpd mms mpg123 modplug sndfile upnp openal opus oss recorder vorbis wavpack zlib"
> > > +PACKAGECONFIG ??= "alsa ao bzip2 ffmpeg flac fluidsynth iso9660 jack libsamplerate mms mpg123 modplug sndfile upnp openal opus vorbis wavpack zlib"
> > > +PACKAGECONFIG += "${@bb.utils.contains('LICENSE_FLAGS', 'commercial', 'aac', '', d)}" <$%7B@bb.utils.contains('LICENSE_FLAGS','commercial','aac','',d)%7D>
> > >
> > >
> > > This removes much more than just aac now.
> > >
> > > Why did you remove daemon, fifo, libwrap, httpd, oss, recorder, vorbis?
> > >
> > >
> > >
> > >  PACKAGECONFIG[aac] = "--enable-aac,--disable-aac,faad2"
> > >  PACKAGECONFIG[alsa] = "--enable-alsa,--disable-alsa,alsa-lib"
> > > --
> > > 2.17.1
> > >
> > > --
> > > _______________________________________________
> > > Openembedded-devel mailing listOpenembedded-devel@lists.openembedded.orghttp://lists.openembedded.org/mailman/listinfo/openembedded-devel
> > >
> > >
> > >
> > --
> > _______________________________________________
> > Openembedded-devel mailing list
> > Openembedded-devel@lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-devel

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 201 bytes --]

Re: [meta-multimedia][PATCH] mpd: fix yocto-check-layer issue with mulitmedia

[Khem Raj]

Correct. Armin I think a v3 is better.
On Sat, Sep 29, 2018 at 11:10 PM Martin Jansa <martin.jansa@gmail.com> wrote:
>
> On Sat, Sep 29, 2018 at 11:04:11PM -0700, Khem Raj wrote:
> > On Sat, Sep 29, 2018 at 10:55 PM Martin Jansa <martin.jansa@gmail.com> wrote:
> > >
> > > https://www.kernel.org/doc/html/latest/process/submitting-patches.html
> > >
> > > The --- marker line serves the essential purpose of marking for patch
> > > handling tools where the changelog message ends.
> > >
> > > One good use for the additional comments after the --- marker is for a
> > > diffstat, to show what files have changed, and the number of inserted and
> > > deleted lines per file. A diffstat is especially useful on bigger patches.
> > > Other comments relevant only to the moment or the maintainer, not suitable
> > > for the permanent changelog, should also go here. A good example of such
> > > comments might be patch changelogs which describe what has changed between
> > > the v1 and v2 version of the patch.
> > >
> >
> > yeah, i have fixed it locally no need for next rev
>
> Only the commit message, right?
>
> Because the PACKAGECONFIG is still incorrect in:
> http://cgit.openembedded.org/meta-openembedded-contrib/commit/?h=yoe/mut&id=14a9f80296aa0141ea9a065439970f8fc1e0c36b
>
> There is also typo in the subject and
> "mpd: enable aac PACKAGECONFIG only with commercial LICENSE_FLAGS
>
> * fix yocto-check-layer issue with multimedia"
>
> would be better commit message IMHO.
>
> > >
> > > On Sat, Sep 29, 2018 at 10:16 PM akuster808 <akuster808@gmail.com> wrote:
> > >
> > > >
> > > >
> > > > On 09/29/2018 12:46 PM, Martin Jansa wrote:
> > > >
> > > > On Sat, Sep 29, 2018 at 12:31:05PM -0700, Armin Kuster wrote:
> > > >
> > > > ERROR: Nothing PROVIDES 'faad2' (but /home/akuster/oss/maint/meta-openembedded/meta-multimedia/recipes-multimedia/musicpd/mpd_0.20.21.bb DEPENDS on or otherwise requires it)
> > > >
> > > > enable aac only if LICENSE_FLAGS is commercial
> > > >
> > > > [v2]
> > > > fix typo in commit message
> > > > rebase on latest master
> > > >
> > > >
> > > > This belongs to cover later or under ---.
> > > >
> > > > I failed to have a [V2] in the subject.  I guess a V3 is inorder for that.
> > > >
> > > > Can you point me to the doc that says where a [v2] comments in a git
> > > > header should be. I can not find it. I seem to be reminded that when I do
> > > > revisions I am doing them wrong.
> > > >
> > > > I don't see reference to this policy:
> > > > https://www.openembedded.org/wiki/Styleguide#Patches
> > > > https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines
> > > > https://www.kernel.org/doc/html/latest/process/submitting-patches.html
> > > >
> > > > per kernel process:
> > > > "The --- marker line serves the essential purpose of marking for patch
> > > > handling tools where the changelog message ends."
> > > > Are you saying I should violate that?
> > > >
> > > > is there somewhere else I should be looking?
> > > >
> > > > - armin
> > > >
> > > >
> > > >
> > > > Signed-off-by: Armin Kuster <akuster808@gmail.com> <akuster808@gmail.com>
> > > > ---
> > > >  meta-multimedia/recipes-multimedia/musicpd/mpd_0.20.21.bb | 3 ++-
> > > >  1 file changed, 2 insertions(+), 1 deletion(-)
> > > >
> > > > diff --git a/meta-multimedia/recipes-multimedia/musicpd/mpd_0.20.21.bb b/meta-multimedia/recipes-multimedia/musicpd/mpd_0.20.21.bb
> > > > index 9123673fb..f91ce4d62 100644
> > > > --- a/meta-multimedia/recipes-multimedia/musicpd/mpd_0.20.21.bb
> > > > +++ b/meta-multimedia/recipes-multimedia/musicpd/mpd_0.20.21.bb
> > > > @@ -26,7 +26,8 @@ S = "${WORKDIR}/git"
> > > >  EXTRA_OECONF = "enable_bzip2=yes"
> > > >  EXTRA_OECONF += "${@bb.utils.contains('DISTRO_FEATURES', 'systemd', '--with-systemdsystemunitdir=${systemd_unitdir}/system/', '--without-systemdsystemunitdir', d)}" <$%7B@bb.utils.contains('DISTRO_FEATURES','systemd','--with-systemdsystemunitdir=$%7Bsystemd_unitdir%7D/system/','--without-systemdsystemunitdir',d)%7D>
> > > >
> > > > -PACKAGECONFIG ??= "aac alsa ao bzip2 daemon ffmpeg fifo flac fluidsynth iso9660 jack libsamplerate libwrap httpd mms mpg123 modplug sndfile upnp openal opus oss recorder vorbis wavpack zlib"
> > > > +PACKAGECONFIG ??= "alsa ao bzip2 ffmpeg flac fluidsynth iso9660 jack libsamplerate mms mpg123 modplug sndfile upnp openal opus vorbis wavpack zlib"
> > > > +PACKAGECONFIG += "${@bb.utils.contains('LICENSE_FLAGS', 'commercial', 'aac', '', d)}" <$%7B@bb.utils.contains('LICENSE_FLAGS','commercial','aac','',d)%7D>
> > > >
> > > >
> > > > This removes much more than just aac now.
> > > >
> > > > Why did you remove daemon, fifo, libwrap, httpd, oss, recorder, vorbis?
> > > >
> > > >
> > > >
> > > >  PACKAGECONFIG[aac] = "--enable-aac,--disable-aac,faad2"
> > > >  PACKAGECONFIG[alsa] = "--enable-alsa,--disable-alsa,alsa-lib"
> > > > --
> > > > 2.17.1
> > > >
> > > > --
> > > > _______________________________________________
> > > > Openembedded-devel mailing listOpenembedded-devel@lists.openembedded.orghttp://lists.openembedded.org/mailman/listinfo/openembedded-devel
> > > >
> > > >
> > > >
> > > --
> > > _______________________________________________
> > > Openembedded-devel mailing list
> > > Openembedded-devel@lists.openembedded.org
> > > http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>
> --
> Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com