* [PATCH] ARM: SAMSUNG: limit SAMSUNG_PM_DEBUG config option to non-Exynos platforms [not found] <CGME20180928133713eucas1p16a15a68b61de9aa3310737f7fd77d20d@eucas1p1.samsung.com> @ 2018-09-28 13:37 ` Bartlomiej Zolnierkiewicz 0 siblings, 0 replies; 8+ messages in thread From: Bartlomiej Zolnierkiewicz @ 2018-09-28 13:37 UTC (permalink / raw) To: Krzysztof Kozlowski Cc: Kukjin Kim, Russell King, Bartlomiej Zolnierkiewicz, linux-arm-kernel, linux-samsung-soc, linux-kernel "Samsung PM Suspend debug" feature (controlled by SAMSUNG_PM_DEBUG config option) is not working properly (debug messages are not displayed after resume) on Exynos platforms because GPIOs restore code is not implemented. Add PLAT_S3C24XX, ARCH_S3C64XX and ARCH_S5PV210 dependencies to SAMSUNG_PM_DEBUG config option to hide it on Exynos platforms. Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> --- arch/arm/plat-samsung/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) Index: b/arch/arm/plat-samsung/Kconfig =================================================================== --- a/arch/arm/plat-samsung/Kconfig 2018-09-28 15:20:06.041911426 +0200 +++ b/arch/arm/plat-samsung/Kconfig 2018-09-28 15:20:06.037911426 +0200 @@ -238,7 +238,8 @@ comment "Power management" config SAMSUNG_PM_DEBUG bool "Samsung PM Suspend debug" - depends on PM && DEBUG_KERNEL + depends on DEBUG_KERNEL + depends on PM && (PLAT_S3C24XX || ARCH_S3C64XX || ARCH_S5PV210) depends on DEBUG_EXYNOS_UART || DEBUG_S3C24XX_UART || DEBUG_S3C2410_UART help Say Y here if you want verbose debugging from the PM Suspend and ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] ARM: SAMSUNG: limit SAMSUNG_PM_DEBUG config option to non-Exynos platforms @ 2018-09-28 13:37 ` Bartlomiej Zolnierkiewicz 0 siblings, 0 replies; 8+ messages in thread From: Bartlomiej Zolnierkiewicz @ 2018-09-28 13:37 UTC (permalink / raw) To: linux-arm-kernel "Samsung PM Suspend debug" feature (controlled by SAMSUNG_PM_DEBUG config option) is not working properly (debug messages are not displayed after resume) on Exynos platforms because GPIOs restore code is not implemented. Add PLAT_S3C24XX, ARCH_S3C64XX and ARCH_S5PV210 dependencies to SAMSUNG_PM_DEBUG config option to hide it on Exynos platforms. Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> --- arch/arm/plat-samsung/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) Index: b/arch/arm/plat-samsung/Kconfig =================================================================== --- a/arch/arm/plat-samsung/Kconfig 2018-09-28 15:20:06.041911426 +0200 +++ b/arch/arm/plat-samsung/Kconfig 2018-09-28 15:20:06.037911426 +0200 @@ -238,7 +238,8 @@ comment "Power management" config SAMSUNG_PM_DEBUG bool "Samsung PM Suspend debug" - depends on PM && DEBUG_KERNEL + depends on DEBUG_KERNEL + depends on PM && (PLAT_S3C24XX || ARCH_S3C64XX || ARCH_S5PV210) depends on DEBUG_EXYNOS_UART || DEBUG_S3C24XX_UART || DEBUG_S3C2410_UART help Say Y here if you want verbose debugging from the PM Suspend and ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] ARM: SAMSUNG: limit SAMSUNG_PM_DEBUG config option to non-Exynos platforms 2018-09-28 13:37 ` Bartlomiej Zolnierkiewicz @ 2018-09-28 13:54 ` Krzysztof Kozlowski -1 siblings, 0 replies; 8+ messages in thread From: Krzysztof Kozlowski @ 2018-09-28 13:54 UTC (permalink / raw) To: Bartłomiej Żołnierkiewicz Cc: kgene, linux, linux-arm-kernel, linux-samsung-soc@vger.kernel.org, linux-kernel On Fri, 28 Sep 2018 at 15:37, Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> wrote: > > "Samsung PM Suspend debug" feature (controlled by SAMSUNG_PM_DEBUG > config option) is not working properly (debug messages are not > displayed after resume) on Exynos platforms because GPIOs restore > code is not implemented. AFAIR, it worked properly for the suspend part showing more logs. Unless it changed, the feature looks still useful. Best regards, Krzysztof > > Add PLAT_S3C24XX, ARCH_S3C64XX and ARCH_S5PV210 dependencies to > SAMSUNG_PM_DEBUG config option to hide it on Exynos platforms. > > Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> > --- > arch/arm/plat-samsung/Kconfig | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > Index: b/arch/arm/plat-samsung/Kconfig > =================================================================== > --- a/arch/arm/plat-samsung/Kconfig 2018-09-28 15:20:06.041911426 +0200 > +++ b/arch/arm/plat-samsung/Kconfig 2018-09-28 15:20:06.037911426 +0200 > @@ -238,7 +238,8 @@ comment "Power management" > > config SAMSUNG_PM_DEBUG > bool "Samsung PM Suspend debug" > - depends on PM && DEBUG_KERNEL > + depends on DEBUG_KERNEL > + depends on PM && (PLAT_S3C24XX || ARCH_S3C64XX || ARCH_S5PV210) > depends on DEBUG_EXYNOS_UART || DEBUG_S3C24XX_UART || DEBUG_S3C2410_UART > help > Say Y here if you want verbose debugging from the PM Suspend and > ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] ARM: SAMSUNG: limit SAMSUNG_PM_DEBUG config option to non-Exynos platforms @ 2018-09-28 13:54 ` Krzysztof Kozlowski 0 siblings, 0 replies; 8+ messages in thread From: Krzysztof Kozlowski @ 2018-09-28 13:54 UTC (permalink / raw) To: linux-arm-kernel On Fri, 28 Sep 2018 at 15:37, Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> wrote: > > "Samsung PM Suspend debug" feature (controlled by SAMSUNG_PM_DEBUG > config option) is not working properly (debug messages are not > displayed after resume) on Exynos platforms because GPIOs restore > code is not implemented. AFAIR, it worked properly for the suspend part showing more logs. Unless it changed, the feature looks still useful. Best regards, Krzysztof > > Add PLAT_S3C24XX, ARCH_S3C64XX and ARCH_S5PV210 dependencies to > SAMSUNG_PM_DEBUG config option to hide it on Exynos platforms. > > Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> > --- > arch/arm/plat-samsung/Kconfig | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > Index: b/arch/arm/plat-samsung/Kconfig > =================================================================== > --- a/arch/arm/plat-samsung/Kconfig 2018-09-28 15:20:06.041911426 +0200 > +++ b/arch/arm/plat-samsung/Kconfig 2018-09-28 15:20:06.037911426 +0200 > @@ -238,7 +238,8 @@ comment "Power management" > > config SAMSUNG_PM_DEBUG > bool "Samsung PM Suspend debug" > - depends on PM && DEBUG_KERNEL > + depends on DEBUG_KERNEL > + depends on PM && (PLAT_S3C24XX || ARCH_S3C64XX || ARCH_S5PV210) > depends on DEBUG_EXYNOS_UART || DEBUG_S3C24XX_UART || DEBUG_S3C2410_UART > help > Say Y here if you want verbose debugging from the PM Suspend and > ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] ARM: SAMSUNG: limit SAMSUNG_PM_DEBUG config option to non-Exynos platforms 2018-09-28 13:54 ` Krzysztof Kozlowski @ 2018-09-28 16:34 ` Bartlomiej Zolnierkiewicz -1 siblings, 0 replies; 8+ messages in thread From: Bartlomiej Zolnierkiewicz @ 2018-09-28 16:34 UTC (permalink / raw) To: Krzysztof Kozlowski Cc: kgene, linux, linux-arm-kernel, linux-samsung-soc@vger.kernel.org, linux-kernel On 09/28/2018 03:54 PM, Krzysztof Kozlowski wrote: > On Fri, 28 Sep 2018 at 15:37, Bartlomiej Zolnierkiewicz > <b.zolnierkie@samsung.com> wrote: >> >> "Samsung PM Suspend debug" feature (controlled by SAMSUNG_PM_DEBUG >> config option) is not working properly (debug messages are not >> displayed after resume) on Exynos platforms because GPIOs restore >> code is not implemented. > > AFAIR, it worked properly for the suspend part showing more logs. > Unless it changed, the feature looks still useful. Yes, it shows few additional messages from mach/plat specific suspend code but it breaks the assumption that features (even debug ones) work correctly and make you invest time in debugging known broken code. In case it is needed/useful (which should be rather rare situation) one can always easily revert the commit locally. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] ARM: SAMSUNG: limit SAMSUNG_PM_DEBUG config option to non-Exynos platforms @ 2018-09-28 16:34 ` Bartlomiej Zolnierkiewicz 0 siblings, 0 replies; 8+ messages in thread From: Bartlomiej Zolnierkiewicz @ 2018-09-28 16:34 UTC (permalink / raw) To: linux-arm-kernel On 09/28/2018 03:54 PM, Krzysztof Kozlowski wrote: > On Fri, 28 Sep 2018 at 15:37, Bartlomiej Zolnierkiewicz > <b.zolnierkie@samsung.com> wrote: >> >> "Samsung PM Suspend debug" feature (controlled by SAMSUNG_PM_DEBUG >> config option) is not working properly (debug messages are not >> displayed after resume) on Exynos platforms because GPIOs restore >> code is not implemented. > > AFAIR, it worked properly for the suspend part showing more logs. > Unless it changed, the feature looks still useful. Yes, it shows few additional messages from mach/plat specific suspend code but it breaks the assumption that features (even debug ones) work correctly and make you invest time in debugging known broken code. In case it is needed/useful (which should be rather rare situation) one can always easily revert the commit locally. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] ARM: SAMSUNG: limit SAMSUNG_PM_DEBUG config option to non-Exynos platforms 2018-09-28 16:34 ` Bartlomiej Zolnierkiewicz @ 2018-09-30 12:38 ` Krzysztof Kozlowski -1 siblings, 0 replies; 8+ messages in thread From: Krzysztof Kozlowski @ 2018-09-30 12:38 UTC (permalink / raw) To: Bartlomiej Zolnierkiewicz Cc: kgene, linux, linux-arm-kernel, linux-samsung-soc@vger.kernel.org, linux-kernel On Fri, Sep 28, 2018 at 06:34:55PM +0200, Bartlomiej Zolnierkiewicz wrote: > > > On 09/28/2018 03:54 PM, Krzysztof Kozlowski wrote: > > On Fri, 28 Sep 2018 at 15:37, Bartlomiej Zolnierkiewicz > > <b.zolnierkie@samsung.com> wrote: > >> > >> "Samsung PM Suspend debug" feature (controlled by SAMSUNG_PM_DEBUG > >> config option) is not working properly (debug messages are not > >> displayed after resume) on Exynos platforms because GPIOs restore > >> code is not implemented. > > > > AFAIR, it worked properly for the suspend part showing more logs. > > Unless it changed, the feature looks still useful. > > Yes, it shows few additional messages from mach/plat specific suspend > code but it breaks the assumption that features (even debug ones) > work correctly and make you invest time in debugging known broken > code. OK, let's remove it. However in such case this change leaves useless S3C_PMDBG and other s3c_pm_* in Exynos code. They should go away along with SAMSUNG_PM_DEBUG. Best regards, Krzysztof > > In case it is needed/useful (which should be rather rare situation) > one can always easily revert the commit locally. > > Best regards, > -- > Bartlomiej Zolnierkiewicz > Samsung R&D Institute Poland > Samsung Electronics ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] ARM: SAMSUNG: limit SAMSUNG_PM_DEBUG config option to non-Exynos platforms @ 2018-09-30 12:38 ` Krzysztof Kozlowski 0 siblings, 0 replies; 8+ messages in thread From: Krzysztof Kozlowski @ 2018-09-30 12:38 UTC (permalink / raw) To: linux-arm-kernel On Fri, Sep 28, 2018 at 06:34:55PM +0200, Bartlomiej Zolnierkiewicz wrote: > > > On 09/28/2018 03:54 PM, Krzysztof Kozlowski wrote: > > On Fri, 28 Sep 2018 at 15:37, Bartlomiej Zolnierkiewicz > > <b.zolnierkie@samsung.com> wrote: > >> > >> "Samsung PM Suspend debug" feature (controlled by SAMSUNG_PM_DEBUG > >> config option) is not working properly (debug messages are not > >> displayed after resume) on Exynos platforms because GPIOs restore > >> code is not implemented. > > > > AFAIR, it worked properly for the suspend part showing more logs. > > Unless it changed, the feature looks still useful. > > Yes, it shows few additional messages from mach/plat specific suspend > code but it breaks the assumption that features (even debug ones) > work correctly and make you invest time in debugging known broken > code. OK, let's remove it. However in such case this change leaves useless S3C_PMDBG and other s3c_pm_* in Exynos code. They should go away along with SAMSUNG_PM_DEBUG. Best regards, Krzysztof > > In case it is needed/useful (which should be rather rare situation) > one can always easily revert the commit locally. > > Best regards, > -- > Bartlomiej Zolnierkiewicz > Samsung R&D Institute Poland > Samsung Electronics ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2018-09-30 12:38 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CGME20180928133713eucas1p16a15a68b61de9aa3310737f7fd77d20d@eucas1p1.samsung.com>
2018-09-28 13:37 ` [PATCH] ARM: SAMSUNG: limit SAMSUNG_PM_DEBUG config option to non-Exynos platforms Bartlomiej Zolnierkiewicz
2018-09-28 13:37 ` Bartlomiej Zolnierkiewicz
2018-09-28 13:54 ` Krzysztof Kozlowski
2018-09-28 13:54 ` Krzysztof Kozlowski
2018-09-28 16:34 ` Bartlomiej Zolnierkiewicz
2018-09-28 16:34 ` Bartlomiej Zolnierkiewicz
2018-09-30 12:38 ` Krzysztof Kozlowski
2018-09-30 12:38 ` Krzysztof Kozlowski
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.