All of lore.kernel.org
 help / color / mirror / Atom feed
From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: Mathias Nyman <mathias.nyman@linux.intel.com>
Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
	stable@vger.kernel.org
Subject: [v2,RESEND,3/3] usb: typec: pci: Enable Intel USB role mux on Apollo Lake platforms
Date: Mon, 1 Oct 2018 18:44:51 +0300	[thread overview]
Message-ID: <20181001154451.GD15780@kuha.fi.intel.com> (raw)

Hi,

Not a biggie, but why was the topic for this patch changed?

I'm not sure Apollo lakes even have Type-C connectors. The mux is
needed with the uAB connectors.

On Mon, Oct 01, 2018 at 06:36:09PM +0300, Mathias Nyman wrote:
> From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> 
> Intel Apollo Lake has the same internal USB role mux as
> Intel Cherry Trail.
> 
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> Signed-off-by: Mathias Nyman <mathias.nyman@linux.intel.com>
> ---
>  drivers/usb/host/xhci-pci.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/usb/host/xhci-pci.c b/drivers/usb/host/xhci-pci.c
> index 722860e..51dd8e0 100644
> --- a/drivers/usb/host/xhci-pci.c
> +++ b/drivers/usb/host/xhci-pci.c
> @@ -179,10 +179,12 @@ static void xhci_pci_quirks(struct device *dev, struct xhci_hcd *xhci)
>  		xhci->quirks |= XHCI_PME_STUCK_QUIRK;
>  	}
>  	if (pdev->vendor == PCI_VENDOR_ID_INTEL &&
> -		 pdev->device == PCI_DEVICE_ID_INTEL_CHERRYVIEW_XHCI) {
> +	    pdev->device == PCI_DEVICE_ID_INTEL_CHERRYVIEW_XHCI)
>  		xhci->quirks |= XHCI_SSIC_PORT_UNUSED;
> +	if (pdev->vendor == PCI_VENDOR_ID_INTEL &&
> +	    (pdev->device == PCI_DEVICE_ID_INTEL_CHERRYVIEW_XHCI ||
> +	     pdev->device == PCI_DEVICE_ID_INTEL_APL_XHCI))
>  		xhci->quirks |= XHCI_INTEL_USB_ROLE_SW;
> -	}
>  	if (pdev->vendor == PCI_VENDOR_ID_INTEL &&
>  	    (pdev->device == PCI_DEVICE_ID_INTEL_CHERRYVIEW_XHCI ||
>  	     pdev->device == PCI_DEVICE_ID_INTEL_SUNRISEPOINT_LP_XHCI ||
> -- 
> 2.7.4

WARNING: multiple messages have this Message-ID (diff)
From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: Mathias Nyman <mathias.nyman@linux.intel.com>
Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
	stable@vger.kernel.org
Subject: Re: [PATCH v2 RESEND 3/3] usb: typec: pci: Enable Intel USB role mux on Apollo Lake platforms
Date: Mon, 1 Oct 2018 18:44:51 +0300	[thread overview]
Message-ID: <20181001154451.GD15780@kuha.fi.intel.com> (raw)
In-Reply-To: <1538408169-26903-4-git-send-email-mathias.nyman@linux.intel.com>

Hi,

Not a biggie, but why was the topic for this patch changed?

I'm not sure Apollo lakes even have Type-C connectors. The mux is
needed with the uAB connectors.

On Mon, Oct 01, 2018 at 06:36:09PM +0300, Mathias Nyman wrote:
> From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> 
> Intel Apollo Lake has the same internal USB role mux as
> Intel Cherry Trail.
> 
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> Signed-off-by: Mathias Nyman <mathias.nyman@linux.intel.com>
> ---
>  drivers/usb/host/xhci-pci.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/usb/host/xhci-pci.c b/drivers/usb/host/xhci-pci.c
> index 722860e..51dd8e0 100644
> --- a/drivers/usb/host/xhci-pci.c
> +++ b/drivers/usb/host/xhci-pci.c
> @@ -179,10 +179,12 @@ static void xhci_pci_quirks(struct device *dev, struct xhci_hcd *xhci)
>  		xhci->quirks |= XHCI_PME_STUCK_QUIRK;
>  	}
>  	if (pdev->vendor == PCI_VENDOR_ID_INTEL &&
> -		 pdev->device == PCI_DEVICE_ID_INTEL_CHERRYVIEW_XHCI) {
> +	    pdev->device == PCI_DEVICE_ID_INTEL_CHERRYVIEW_XHCI)
>  		xhci->quirks |= XHCI_SSIC_PORT_UNUSED;
> +	if (pdev->vendor == PCI_VENDOR_ID_INTEL &&
> +	    (pdev->device == PCI_DEVICE_ID_INTEL_CHERRYVIEW_XHCI ||
> +	     pdev->device == PCI_DEVICE_ID_INTEL_APL_XHCI))
>  		xhci->quirks |= XHCI_INTEL_USB_ROLE_SW;
> -	}
>  	if (pdev->vendor == PCI_VENDOR_ID_INTEL &&
>  	    (pdev->device == PCI_DEVICE_ID_INTEL_CHERRYVIEW_XHCI ||
>  	     pdev->device == PCI_DEVICE_ID_INTEL_SUNRISEPOINT_LP_XHCI ||
> -- 
> 2.7.4

-- 
heikki

             reply	other threads:[~2018-10-01 15:44 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-01 15:44 Heikki Krogerus [this message]
2018-10-01 15:44 ` [PATCH v2 RESEND 3/3] usb: typec: pci: Enable Intel USB role mux on Apollo Lake platforms Heikki Krogerus
  -- strict thread matches above, loose matches on Subject: below --
2018-10-01 15:53 usb: xhci: " Heikki Krogerus
2018-10-01 15:53 ` [PATCH] " Heikki Krogerus
2018-10-01 15:49 [v2,RESEND,3/3] usb: typec: " Heikki Krogerus
2018-10-01 15:49 ` [PATCH v2 RESEND 3/3] " Heikki Krogerus
2018-10-01 15:36 [v2,RESEND,3/3] " Mathias Nyman
2018-10-01 15:36 ` [PATCH v2 RESEND 3/3] " Mathias Nyman
2018-10-01 15:36 [v2,RESEND,2/3] usb: xhci-mtk: resume USB3 roothub first Mathias Nyman
2018-10-01 15:36 ` [PATCH v2 RESEND 2/3] " Mathias Nyman
2018-10-01 15:36 [v2,RESEND,1/3] xhci: Add missing CAS workaround for Intel Sunrise Point xHCI Mathias Nyman
2018-10-01 15:36 ` [PATCH v2 RESEND 1/3] " Mathias Nyman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181001154451.GD15780@kuha.fi.intel.com \
    --to=heikki.krogerus@linux.intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mathias.nyman@linux.intel.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.