All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Ben Dooks <ben.dooks@codethink.co.uk>
Cc: netdev@vger.kernel.org, oneukum@suse.com, davem@davemloft.net,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-kernel@lists.codethink.co.uk
Subject: [1/4] usbnet: smsc95xx: add kconfig for turbo mode
Date: Tue, 2 Oct 2018 14:46:18 +0200	[thread overview]
Message-ID: <20181002124618.GD9155@lunn.ch> (raw)

On Tue, Oct 02, 2018 at 10:26:42AM +0100, Ben Dooks wrote:
> Add a configuration option for the default state of turbo mode
> on the smsc95xx networking driver. Some systems it is better
> to default this to off as it causes significant increases in
> soft-irq load.
> 
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
> ---
>  drivers/net/usb/Kconfig    | 9 +++++++++
>  drivers/net/usb/smsc95xx.c | 2 +-
>  2 files changed, 10 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/usb/Kconfig b/drivers/net/usb/Kconfig
> index 418b0904cecb..a32f1a446ce9 100644
> --- a/drivers/net/usb/Kconfig
> +++ b/drivers/net/usb/Kconfig
> @@ -351,6 +351,15 @@ config USB_NET_SMSC95XX
>  	  This option adds support for SMSC LAN95XX based USB 2.0
>  	  10/100 Ethernet adapters.
>  
> +config USB_NET_SMSC95XX_TURBO
> +	bool "Use turbo receive mode by default"
> +	depends on USB_NET_SMSC95XX
> +	default y
> +	help
> +	  This options sets the default turbo mode settings for the
> +	  driver's receive path. These can also be altered by the
> +	  turbo_mode module parameter.
> +

Hi Ben

Is it worth adding a comment here why you would want to turn it off?
To reduce soft-irq load?

Thanks
	Andrew

WARNING: multiple messages have this Message-ID (diff)
From: Andrew Lunn <andrew@lunn.ch>
To: Ben Dooks <ben.dooks@codethink.co.uk>
Cc: netdev@vger.kernel.org, oneukum@suse.com, davem@davemloft.net,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-kernel@lists.codethink.co.uk
Subject: Re: [PATCH 1/4] usbnet: smsc95xx: add kconfig for turbo mode
Date: Tue, 2 Oct 2018 14:46:18 +0200	[thread overview]
Message-ID: <20181002124618.GD9155@lunn.ch> (raw)
In-Reply-To: <20181002092645.1115-2-ben.dooks@codethink.co.uk>

On Tue, Oct 02, 2018 at 10:26:42AM +0100, Ben Dooks wrote:
> Add a configuration option for the default state of turbo mode
> on the smsc95xx networking driver. Some systems it is better
> to default this to off as it causes significant increases in
> soft-irq load.
> 
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
> ---
>  drivers/net/usb/Kconfig    | 9 +++++++++
>  drivers/net/usb/smsc95xx.c | 2 +-
>  2 files changed, 10 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/usb/Kconfig b/drivers/net/usb/Kconfig
> index 418b0904cecb..a32f1a446ce9 100644
> --- a/drivers/net/usb/Kconfig
> +++ b/drivers/net/usb/Kconfig
> @@ -351,6 +351,15 @@ config USB_NET_SMSC95XX
>  	  This option adds support for SMSC LAN95XX based USB 2.0
>  	  10/100 Ethernet adapters.
>  
> +config USB_NET_SMSC95XX_TURBO
> +	bool "Use turbo receive mode by default"
> +	depends on USB_NET_SMSC95XX
> +	default y
> +	help
> +	  This options sets the default turbo mode settings for the
> +	  driver's receive path. These can also be altered by the
> +	  turbo_mode module parameter.
> +

Hi Ben

Is it worth adding a comment here why you would want to turn it off?
To reduce soft-irq load?

Thanks
	Andrew

             reply	other threads:[~2018-10-02 12:46 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-02 12:46 Andrew Lunn [this message]
2018-10-02 12:46 ` [PATCH 1/4] usbnet: smsc95xx: add kconfig for turbo mode Andrew Lunn
  -- strict thread matches above, loose matches on Subject: below --
2018-10-08  8:41 usbnet: smsc95xx: simplify tx_fixup code David Laight
2018-10-08  8:41 ` [PATCH] " David Laight
2018-10-06 17:28 David Miller
2018-10-06 17:28 ` [PATCH] " David Miller
2018-10-06 11:27 Ben Dooks
2018-10-06 11:27 ` [PATCH] " Ben Dooks
2018-10-05 21:24 David Miller
2018-10-05 21:24 ` [PATCH] " David Miller
2018-10-04 16:55 [3/4] usbnet: smsc95xx: check for csum being in last four bytes Ben Hutchings
2018-10-04 16:55 ` [PATCH 3/4] " Ben Hutchings
2018-10-04 16:55 ` [Linux-kernel] " Ben Hutchings
2018-10-04 16:53 [2/4] usbnet: smsc95xx: align tx-buffer to word Ben Hutchings
2018-10-04 16:53 ` [PATCH 2/4] " Ben Hutchings
2018-10-04 16:53 ` [Linux-kernel] " Ben Hutchings
2018-10-03 16:25 usbnet: smsc95xx: simplify tx_fixup code Ben Dooks
2018-10-03 16:25 ` [PATCH] " Ben Dooks
2018-10-03 13:36 David Laight
2018-10-03 13:36 ` [PATCH] " David Laight
2018-10-02 16:56 Ben Dooks
2018-10-02 16:56 ` [PATCH] " Ben Dooks
2018-10-02 13:35 [2/4] usbnet: smsc95xx: align tx-buffer to word Ben Dooks
2018-10-02 13:35 ` [PATCH 2/4] " Ben Dooks
2018-10-02 13:19 [2/4] " David Laight
2018-10-02 13:19 ` [PATCH 2/4] " David Laight
2018-10-02  9:45 [3/4] usbnet: smsc95xx: check for csum being in last four bytes Sergei Shtylyov
2018-10-02  9:45 ` [PATCH 3/4] " Sergei Shtylyov
2018-10-02  9:26 [4/4] usbnet: smsc95xx: fix rx packet alignment Ben Dooks
2018-10-02  9:26 ` [PATCH 4/4] " Ben Dooks
2018-10-02  9:26 [3/4] usbnet: smsc95xx: check for csum being in last four bytes Ben Dooks
2018-10-02  9:26 ` [PATCH 3/4] " Ben Dooks
2018-10-02  9:26 [2/4] usbnet: smsc95xx: align tx-buffer to word Ben Dooks
2018-10-02  9:26 ` [PATCH 2/4] " Ben Dooks
2018-10-02  9:26 [1/4] usbnet: smsc95xx: add kconfig for turbo mode Ben Dooks
2018-10-02  9:26 ` [PATCH 1/4] " Ben Dooks
2018-10-02  9:26 SMSC95XX driver updates Ben Dooks

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181002124618.GD9155@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=ben.dooks@codethink.co.uk \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@lists.codethink.co.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=oneukum@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.