From: Vinod Koul <vkoul@kernel.org>
To: Nathan Chancellor <natechancellor@gmail.com>
Cc: Dan Williams <dan.j.williams@intel.com>,
dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org,
Nick Desaulniers <ndesaulniers@google.com>
Subject: dmaengine: ep93xx: Return proper enum in ep93xx_dma_chan_direction
Date: Tue, 2 Oct 2018 20:12:03 +0530 [thread overview]
Message-ID: <20181002144203.GC19792@vkoul-mobl> (raw)
On 11-09-18, 16:40, Nathan Chancellor wrote:
> Clang warns when implicitly converting from one enumerated type to
> another. Avoid this by using the equivalent value from the expected
> type.
>
> In file included from drivers/dma/ep93xx_dma.c:30:
> ./include/linux/platform_data/dma-ep93xx.h:88:10: warning: implicit
> conversion from enumeration type 'enum dma_data_direction' to different
> enumeration type 'enum dma_transfer_direction' [-Wenum-conversion]
> return DMA_NONE;
> ~~~~~~ ^~~~~~~~
> 1 warning generated.
Applied, thanks
WARNING: multiple messages have this Message-ID (diff)
From: Vinod <vkoul@kernel.org>
To: Nathan Chancellor <natechancellor@gmail.com>
Cc: Dan Williams <dan.j.williams@intel.com>,
dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org,
Nick Desaulniers <ndesaulniers@google.com>
Subject: Re: [PATCH] dmaengine: ep93xx: Return proper enum in ep93xx_dma_chan_direction
Date: Tue, 2 Oct 2018 20:12:03 +0530 [thread overview]
Message-ID: <20181002144203.GC19792@vkoul-mobl> (raw)
In-Reply-To: <20180911234020.9064-1-natechancellor@gmail.com>
On 11-09-18, 16:40, Nathan Chancellor wrote:
> Clang warns when implicitly converting from one enumerated type to
> another. Avoid this by using the equivalent value from the expected
> type.
>
> In file included from drivers/dma/ep93xx_dma.c:30:
> ./include/linux/platform_data/dma-ep93xx.h:88:10: warning: implicit
> conversion from enumeration type 'enum dma_data_direction' to different
> enumeration type 'enum dma_transfer_direction' [-Wenum-conversion]
> return DMA_NONE;
> ~~~~~~ ^~~~~~~~
> 1 warning generated.
Applied, thanks
--
~Vinod
next reply other threads:[~2018-10-02 14:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-02 14:42 Vinod Koul [this message]
2018-10-02 14:42 ` [PATCH] dmaengine: ep93xx: Return proper enum in ep93xx_dma_chan_direction Vinod
-- strict thread matches above, loose matches on Subject: below --
2018-09-12 18:36 Nathan Chancellor
2018-09-12 18:36 ` [PATCH] " Nathan Chancellor
2018-09-12 17:00 Nick Desaulniers
2018-09-12 17:00 ` [PATCH] " Nick Desaulniers
2018-09-11 23:40 Nathan Chancellor
2018-09-11 23:40 ` [PATCH] " Nathan Chancellor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181002144203.GC19792@vkoul-mobl \
--to=vkoul@kernel.org \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=natechancellor@gmail.com \
--cc=ndesaulniers@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.