From: greg@kroah.com (Greg KH)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] nvmem: only build nvmem_find_cell_by_index() if OF is enabled
Date: Tue, 2 Oct 2018 15:26:42 -0700 [thread overview]
Message-ID: <20181002222642.GA19204@kroah.com> (raw)
In-Reply-To: <20181002110246.3175-1-brgl@bgdev.pl>
On Tue, Oct 02, 2018 at 01:02:46PM +0200, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
>
> The following warning is produced when building nvmem core if
> CONFIG_OF is disabled:
>
> drivers/nvmem/core.c:496:1: warning: 'nvmem_find_cell_by_index' defined but not used [-Wunused-function]
> nvmem_find_cell_by_index(struct nvmem_device *nvmem, int index)
> ^~~~~~~~~~~~~~~~~~~~~~~~
>
> This is caused by the fact that the only caller of this routine is
> under an ifdef depending on this option. Fix it by adding a relevant
> ifdef to the function in question as well.
>
> Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
No "reported-by:" lines on this and the other patch?
Not nice :(
WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <greg@kroah.com>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
Arnd Bergmann <arnd@arndb.de>,
Stephen Rothwell <sfr@canb.auug.org.au>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Bartosz Golaszewski <bgolaszewski@baylibre.com>
Subject: Re: [PATCH] nvmem: only build nvmem_find_cell_by_index() if OF is enabled
Date: Tue, 2 Oct 2018 15:26:42 -0700 [thread overview]
Message-ID: <20181002222642.GA19204@kroah.com> (raw)
In-Reply-To: <20181002110246.3175-1-brgl@bgdev.pl>
On Tue, Oct 02, 2018 at 01:02:46PM +0200, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
>
> The following warning is produced when building nvmem core if
> CONFIG_OF is disabled:
>
> drivers/nvmem/core.c:496:1: warning: 'nvmem_find_cell_by_index' defined but not used [-Wunused-function]
> nvmem_find_cell_by_index(struct nvmem_device *nvmem, int index)
> ^~~~~~~~~~~~~~~~~~~~~~~~
>
> This is caused by the fact that the only caller of this routine is
> under an ifdef depending on this option. Fix it by adding a relevant
> ifdef to the function in question as well.
>
> Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
No "reported-by:" lines on this and the other patch?
Not nice :(
next prev parent reply other threads:[~2018-10-02 22:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-02 11:02 [PATCH] nvmem: only build nvmem_find_cell_by_index() if OF is enabled Bartosz Golaszewski
2018-10-02 11:02 ` Bartosz Golaszewski
2018-10-02 11:49 ` Srinivas Kandagatla
2018-10-02 11:49 ` Srinivas Kandagatla
2018-10-02 11:59 ` Bartosz Golaszewski
2018-10-02 11:59 ` Bartosz Golaszewski
2018-10-02 22:26 ` Greg KH [this message]
2018-10-02 22:26 ` Greg KH
2018-10-03 7:19 ` Bartosz Golaszewski
2018-10-03 7:19 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181002222642.GA19204@kroah.com \
--to=greg@kroah.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.