All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 3/3] syscalls/preadv202: Add new testcase
Date: Thu, 4 Oct 2018 14:19:17 +0200	[thread overview]
Message-ID: <20181004121916.GB7724@rei.lan> (raw)
In-Reply-To: <1538125851-26738-3-git-send-email-yangx.jy@cn.fujitsu.com>

Hi!
> Note:
> From preadv2(2) manpage, preadv2() with invalid flag should return
> EINVAL, but it actually returned EOPNOTSUPP in current upstream
> kernel, as below:
> ---------------------------------------------------------------
> include/uapi/linux/fs.h:
> define RWF_SUPPORTED   (RWF_HIPRI | RWF_DSYNC | RWF_SYNC | RWF_NOWAIT |\
>                          RWF_APPEND)
> ...
> 
> include/linux/fs.h:
> static inline int kiocb_set_rw_flags(struct kiocb *ki, rwf_t flags)
> {
>         if (unlikely(flags & ~RWF_SUPPORTED)) {
>                 return -EOPNOTSUPP;
>         }
> ...
> ---------------------------------------------------------------
> 
> We use EOPNOTSUPP as expected errno for the time being.

This is probably worth a patch for the man-pages project, will you take
care of that?

Pushed with a minor change, I've changed the EFAULT test to get address
from tst_get_bad_addr() instead of the hardcoded -1.

Thanks!

-- 
Cyril Hrubis
chrubis@suse.cz

  reply	other threads:[~2018-10-04 12:19 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-28  9:10 [LTP] [PATCH 1/3] lapi/syscalls: Add syscall numbers for preadv2 Xiao Yang
2018-09-28  9:10 ` [LTP] [PATCH 2/3] syscalls/preadv201: Add new testcase Xiao Yang
2018-10-04 12:16   ` Cyril Hrubis
2018-09-28  9:10 ` [LTP] [PATCH 3/3] syscalls/preadv202: " Xiao Yang
2018-10-04 12:19   ` Cyril Hrubis [this message]
2018-10-05  1:17     ` Xiao Yang
2019-02-27  8:16     ` Xiao Yang
2019-02-27  9:07       ` Jan Stancek
2019-02-27  9:36         ` Xiao Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181004121916.GB7724@rei.lan \
    --to=chrubis@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.