All of lore.kernel.org
 help / color / mirror / Atom feed
From: Xiao Yang <yangx.jy@cn.fujitsu.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 3/3] syscalls/preadv202: Add new testcase
Date: Wed, 27 Feb 2019 16:16:45 +0800	[thread overview]
Message-ID: <5C76476D.3070005@cn.fujitsu.com> (raw)
In-Reply-To: <20181004121916.GB7724@rei.lan>

Hi Jan,

preadv202 has used tst_get_bad_addr() instead of the hardcoded -1 to 
test  EFAULT, so is it
necessary to test EFAULT on s390 by truncating file as commit 856383c 
does?  Perhaps, we
can remove the truncation if it is unnecessary.   Sorry, i don't have 
s390 to confirm it.

Best Regards,
Xiao Yang
On 2018/10/04 20:19, Cyril Hrubis wrote:
> Hi!
>> Note:
>>  From preadv2(2) manpage, preadv2() with invalid flag should return
>> EINVAL, but it actually returned EOPNOTSUPP in current upstream
>> kernel, as below:
>> ---------------------------------------------------------------
>> include/uapi/linux/fs.h:
>> define RWF_SUPPORTED   (RWF_HIPRI | RWF_DSYNC | RWF_SYNC | RWF_NOWAIT |\
>>                           RWF_APPEND)
>> ...
>>
>> include/linux/fs.h:
>> static inline int kiocb_set_rw_flags(struct kiocb *ki, rwf_t flags)
>> {
>>          if (unlikely(flags&  ~RWF_SUPPORTED)) {
>>                  return -EOPNOTSUPP;
>>          }
>> ...
>> ---------------------------------------------------------------
>>
>> We use EOPNOTSUPP as expected errno for the time being.
> This is probably worth a patch for the man-pages project, will you take
> care of that?
>
> Pushed with a minor change, I've changed the EFAULT test to get address
> from tst_get_bad_addr() instead of the hardcoded -1.
>
> Thanks!
>




  parent reply	other threads:[~2019-02-27  8:16 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-28  9:10 [LTP] [PATCH 1/3] lapi/syscalls: Add syscall numbers for preadv2 Xiao Yang
2018-09-28  9:10 ` [LTP] [PATCH 2/3] syscalls/preadv201: Add new testcase Xiao Yang
2018-10-04 12:16   ` Cyril Hrubis
2018-09-28  9:10 ` [LTP] [PATCH 3/3] syscalls/preadv202: " Xiao Yang
2018-10-04 12:19   ` Cyril Hrubis
2018-10-05  1:17     ` Xiao Yang
2019-02-27  8:16     ` Xiao Yang [this message]
2019-02-27  9:07       ` Jan Stancek
2019-02-27  9:36         ` Xiao Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5C76476D.3070005@cn.fujitsu.com \
    --to=yangx.jy@cn.fujitsu.com \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.