From: Greg KH <gregkh@linuxfoundation.org>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: stable@vger.kernel.org
Subject: Re: [PATCH 4.9/4.14] serial: mvebu-uart: Fix reporting of effective CSIZE to userspace
Date: Thu, 4 Oct 2018 11:11:29 -0700 [thread overview]
Message-ID: <20181004181129.GC28484@kroah.com> (raw)
In-Reply-To: <19d49982-1755-9bf0-8dd0-5819672c7838@siemens.com>
On Mon, Oct 01, 2018 at 09:24:11AM +0200, Jan Kiszka wrote:
> From: Jan Kiszka <jan.kiszka@siemens.com>
>
> Commit e0bf2d4982fe7d9ddaf550dd023803ea286f47fc upstream.
>
> Apparently, this driver (or the hardware) does not support character
> length settings. It's apparently running in 8-bit mode, but it makes
> userspace believe it's in 5-bit mode. That makes tcsetattr with CS8
> incorrectly fail, breaking e.g. getty from busybox, thus the login shell
> on ttyMVx.
>
> Fix by hard-wiring CS8 into c_cflag.
>
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
> drivers/tty/serial/mvebu-uart.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
Now applied, thanks.
greg k-h
prev parent reply other threads:[~2018-10-05 1:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-29 23:41 FAILED: patch "[PATCH] serial: mvebu-uart: Fix reporting of effective CSIZE to" failed to apply to 4.14-stable tree gregkh
2018-10-01 7:24 ` [PATCH 4.9/4.14] serial: mvebu-uart: Fix reporting of effective CSIZE to userspace Jan Kiszka
2018-10-04 18:11 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181004181129.GC28484@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=jan.kiszka@siemens.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.