From: Stanislaw Gruszka <sgruszka@redhat.com>
To: Manikanta Pubbisetty <mpubbise@codeaurora.org>
Cc: Johannes Berg <johannes@sipsolutions.net>,
linux-wireless@vger.kernel.org
Subject: crash in ieee80211_wake_txqs
Date: Fri, 5 Oct 2018 10:37:49 +0200 [thread overview]
Message-ID: <20181005083748.GD1931@redhat.com> (raw)
Hi
I have crash in ieee80211_wake_txqs:
https://imgur.com/a/VIrU9yK
when starting mt76x0u driver. Not sure if this is beacuse the driver
do not initalize sta->txq properly, but reverting the
commit 21a5d4c3a45ca608477a083096cfbce76e449a0c
Author: Manikanta Pubbisetty <mpubbise@codeaurora.org>
Date: Wed Jul 11 00:12:53 2018 +0530
mac80211: add stop/start logic for software TXQs
make crash gone.
gdb pointed at 'if (ac != txq->ac)' line in the code:
for (i = 0; i < ARRAY_SIZE(sta->sta.txq); i++) {
struct ieee80211_txq *txq = sta->sta.txq[i];
txqi = to_txq_info(txq);
if (ac != txq->ac)
continue;
Looks txq is NULL and referencing txq->ac crashes.
Thanks
Stanislaw
next reply other threads:[~2018-10-05 8:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-05 8:37 Stanislaw Gruszka [this message]
2018-10-05 8:43 ` crash in ieee80211_wake_txqs Lorenzo Bianconi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181005083748.GD1931@redhat.com \
--to=sgruszka@redhat.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=mpubbise@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.