* crash in ieee80211_wake_txqs
@ 2018-10-05 8:37 Stanislaw Gruszka
2018-10-05 8:43 ` Lorenzo Bianconi
0 siblings, 1 reply; 2+ messages in thread
From: Stanislaw Gruszka @ 2018-10-05 8:37 UTC (permalink / raw)
To: Manikanta Pubbisetty; +Cc: Johannes Berg, linux-wireless
Hi
I have crash in ieee80211_wake_txqs:
https://imgur.com/a/VIrU9yK
when starting mt76x0u driver. Not sure if this is beacuse the driver
do not initalize sta->txq properly, but reverting the
commit 21a5d4c3a45ca608477a083096cfbce76e449a0c
Author: Manikanta Pubbisetty <mpubbise@codeaurora.org>
Date: Wed Jul 11 00:12:53 2018 +0530
mac80211: add stop/start logic for software TXQs
make crash gone.
gdb pointed at 'if (ac != txq->ac)' line in the code:
for (i = 0; i < ARRAY_SIZE(sta->sta.txq); i++) {
struct ieee80211_txq *txq = sta->sta.txq[i];
txqi = to_txq_info(txq);
if (ac != txq->ac)
continue;
Looks txq is NULL and referencing txq->ac crashes.
Thanks
Stanislaw
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: crash in ieee80211_wake_txqs
2018-10-05 8:37 crash in ieee80211_wake_txqs Stanislaw Gruszka
@ 2018-10-05 8:43 ` Lorenzo Bianconi
0 siblings, 0 replies; 2+ messages in thread
From: Lorenzo Bianconi @ 2018-10-05 8:43 UTC (permalink / raw)
To: Stanislaw Gruszka; +Cc: mpubbise, Johannes Berg, linux-wireless
>
> Hi
>
> I have crash in ieee80211_wake_txqs:
> https://imgur.com/a/VIrU9yK
> when starting mt76x0u driver. Not sure if this is beacuse the driver
> do not initalize sta->txq properly, but reverting the
>
> commit 21a5d4c3a45ca608477a083096cfbce76e449a0c
> Author: Manikanta Pubbisetty <mpubbise@codeaurora.org>
> Date: Wed Jul 11 00:12:53 2018 +0530
>
> mac80211: add stop/start logic for software TXQs
>
> make crash gone.
>
> gdb pointed at 'if (ac != txq->ac)' line in the code:
>
> for (i = 0; i < ARRAY_SIZE(sta->sta.txq); i++) {
> struct ieee80211_txq *txq = sta->sta.txq[i];
>
> txqi = to_txq_info(txq);
>
> if (ac != txq->ac)
> continue;
>
> Looks txq is NULL and referencing txq->ac crashes.
>
> Thanks
> Stanislaw
Hi Stanislaw,
I guess it is fixed here:
https://marc.info/?l=linux-kernel&m=153694084922438&w=2
Regrads,
Lorenzo
--
UNIX is Sexy: who | grep -i blonde | talk; cd ~; wine; talk; touch;
unzip; touch; strip; gasp; finger; gasp; mount; fsck; more; yes; gasp;
umount; make clean; sleep
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-10-05 8:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-10-05 8:37 crash in ieee80211_wake_txqs Stanislaw Gruszka
2018-10-05 8:43 ` Lorenzo Bianconi
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.